From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 1115047CD; Fri, 1 Sep 2017 12:40:50 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Sep 2017 03:40:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,457,1498546800"; d="scan'208";a="124661671" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by orsmga004.jf.intel.com with ESMTP; 01 Sep 2017 03:40:48 -0700 To: =?UTF-8?Q?N=c3=a9lio_Laranjeiro?= , Matan Azrad Cc: Adrien Mazarguil , dev@dpdk.org, stable@dpdk.org References: <1502627112-53405-1-git-send-email-matan@mellanox.com> <1502627112-53405-2-git-send-email-matan@mellanox.com> <20170823094413.GT12995@autoinstall.dev.6wind.com> From: Ferruh Yigit Message-ID: <24ffbe60-ad35-7096-6675-9dcfdd2fb515@intel.com> Date: Fri, 1 Sep 2017 11:40:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170823094413.GT12995@autoinstall.dev.6wind.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] net/mlx5: fix probe failure report X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Sep 2017 10:40:51 -0000 On 8/23/2017 10:44 AM, Nélio Laranjeiro wrote: > On Sun, Aug 13, 2017 at 03:25:12PM +0300, Matan Azrad wrote: >> The corrupted code doesn't return error when probe function >> fails due to error in device mac address getting. >> By this way, the probe function may return success even if the >> ETH dev is not allocated. >> >> Hence, the probe caller, for example failsafe PMD, fails when it >> tries to get ETH dev after the device was plugged out while mlx5 >> was probing it. >> >> The fix adds error report to the probe caller when priv_get_mac fails >> and in all other failure options which are missing it. >> >> By this way, it prevents the unexpected behavior to miss ETH device >> after the device was probed successfully. >> >> This bug was already present in the original code taken from mlx4. >> >> Fixes: 771fa900b73a ("mlx5: introduce new driver for Mellanox ConnectX-4 adapters") >> Fixes: 1371f4df16bc ("mlx5: check port is configured as ethernet device") >> >> Signed-off-by: Matan Azrad >> Cc: stable@dpdk.org > > Acked-by: Nelio Laranjeiro Applied to dpdk-next-net/master, thanks.