* [dpdk-dev] [PATCH] net/mlx5: fix rollback when starting device
@ 2017-05-10 17:30 Yongseok Koh
2017-05-10 19:29 ` Adrien Mazarguil
0 siblings, 1 reply; 3+ messages in thread
From: Yongseok Koh @ 2017-05-10 17:30 UTC (permalink / raw)
To: ferruh.yigit
Cc: dev, adrien.mazarguil, nelio.laranjeiro, Yongseok Koh, stable
In mlx5_dev_start(), the spinlock isn't released when returning error.
Fixes: c8d4ee50cc85 ("net/mlx5: fix startup when flow cannot be applied")
Cc: stable@dpdk.org
Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
---
drivers/net/mlx5/mlx5_trigger.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c
index 229b05e79..8c5aa6910 100644
--- a/drivers/net/mlx5/mlx5_trigger.c
+++ b/drivers/net/mlx5/mlx5_trigger.c
@@ -109,6 +109,7 @@ mlx5_dev_start(struct rte_eth_dev *dev)
priv_mac_addrs_disable(priv);
priv_destroy_hash_rxqs(priv);
priv_flow_stop(priv);
+ priv_unlock(priv);
return -err;
}
--
2.11.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: fix rollback when starting device
2017-05-10 17:30 [dpdk-dev] [PATCH] net/mlx5: fix rollback when starting device Yongseok Koh
@ 2017-05-10 19:29 ` Adrien Mazarguil
2017-05-10 19:42 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Adrien Mazarguil @ 2017-05-10 19:29 UTC (permalink / raw)
To: Yongseok Koh; +Cc: ferruh.yigit, dev, nelio.laranjeiro, stable
On Wed, May 10, 2017 at 10:30:16AM -0700, Yongseok Koh wrote:
> In mlx5_dev_start(), the spinlock isn't released when returning error.
>
> Fixes: c8d4ee50cc85 ("net/mlx5: fix startup when flow cannot be applied")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
--
Adrien Mazarguil
6WIND
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix rollback when starting device
2017-05-10 19:29 ` Adrien Mazarguil
@ 2017-05-10 19:42 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2017-05-10 19:42 UTC (permalink / raw)
To: Yongseok Koh
Cc: stable, Adrien Mazarguil, ferruh.yigit, dev, nelio.laranjeiro
10/05/2017 21:29, Adrien Mazarguil:
> On Wed, May 10, 2017 at 10:30:16AM -0700, Yongseok Koh wrote:
> > In mlx5_dev_start(), the spinlock isn't released when returning error.
> >
> > Fixes: c8d4ee50cc85 ("net/mlx5: fix startup when flow cannot be applied")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
>
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-10 19:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-10 17:30 [dpdk-dev] [PATCH] net/mlx5: fix rollback when starting device Yongseok Koh
2017-05-10 19:29 ` Adrien Mazarguil
2017-05-10 19:42 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).