From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D738A0597; Thu, 9 Apr 2020 16:00:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 069081C295; Thu, 9 Apr 2020 16:00:19 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 54E251C257 for ; Thu, 9 Apr 2020 16:00:17 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id CCF0E5C2C7A; Thu, 9 Apr 2020 10:00:16 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Thu, 09 Apr 2020 10:00:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=ZBV/1CBzv53Rao0R27vCfXgcjoMNP92sVaS1yWplPak=; b=XoC8zPDBemfT Ph08E0QLVyWOH3SPZbAESQCNUG4vussp+NHc3UcbftN6BiJIqUt7nxt3X3k1JDOZ /wTtsSOm57FmWAenu7f6+gtGYZkGsUNg3+WvLif39Z4lK1W9cLC56gx6RqfVGVvd b1zonISWCnpegBwBLWfe1EiNXU5K8OI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=ZBV/1CBzv53Rao0R27vCfXgcjoMNP92sVaS1yWplP ak=; b=DeiBCqauBWtfAvINSciapmlpkVOIoHoGv2WTYpTVL5G1Jn7b9keqWmU2Q qzpj9hnAJMKknDmxY4nvBEEdInt3D3HEbESeG24IMpnEoxSLwrXzcvB3AHdf65UQ Vr7tXSVfxOE5XHFG/Tr5OtOBYIg2IWLRa24AD2/amYMF/D3Kgq2DgAdwcRSExZB3 zePZvIx+Gl5PZzSGjQZSw4nDD4Y41Q3cQ+/SkKGDiyHgyudLkqVQSG6uBiLAv/LS wTqUp/Doi14MrNIPAAFS5uGj5eIljeOArE3VIP1AyQrhGI3p6fap68DCX6fYvPF8 lhlIVldWLK7JFLJn1S5kSpKf2RCMQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudelgdeiiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 724913060061; Thu, 9 Apr 2020 10:00:14 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob Cc: dev@dpdk.org, bruce.richardson@intel.com, david.marchand@redhat.com, mattias.ronnblom@ericsson.com, skori@marvell.com Date: Thu, 09 Apr 2020 16:00:13 +0200 Message-ID: <2501342.7s5MMGUR32@thomas> In-Reply-To: <20200403153709.3703448-1-jerinj@marvell.com> References: <20200329144342.1543749-1-jerinj@marvell.com> <20200403153709.3703448-1-jerinj@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 00/33] DPDK Trace support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, 03/04/2020 17:36, jerinj@marvell.com: > Features: > ~~~~~~~~~ > - APIs and Features are similar to rte_log dynamic framework > API(expect log prints on stdout vs it dumps on trace file) A log can print to syslog as well. As discussed somewhere else, please do not introduce global level in rte_trace. I think it is useless. If we need to change the level of all trace types, we can just use a wildcard (globbing or regexp). And about wording, "pattern" is too vague and should be replaced with "globbing". > - No specific limit on the events. A string-based event like rte_log > for pattern matching Would it be possible to replace rte_log with rte_trace? > - Dynamic enable/disable support. How dynamic it is? Can we start/stop a trace after starting DPDK? I think we need a control channel for this. I propose to introduce a general control channel in DPDK. > - Instructmention overhead is ~1 cycle. i.e cost of adding the code Nice > wth out using trace feature. > - Timestamp support for all the events using DPDK rte_rtdsc Could we use other timestamp sources, like the mbuf timestamp for Rx traces? > - No dependency on another library. Clean room native implementation of > CTF. No benefit of using an external CTF library maintained somewhere else?