From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1EF3A04D6; Mon, 21 Sep 2020 18:14:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 33D821D974; Mon, 21 Sep 2020 18:14:53 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 6D6581C199 for <dev@dpdk.org>; Mon, 21 Sep 2020 18:14:51 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 4065F4C2; Mon, 21 Sep 2020 12:14:50 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Mon, 21 Sep 2020 12:14:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= xY1xSXp5urOI0Fo8UvuLhAGHcY3r7eRP41kxMCFFgVo=; b=XnMHqK9L9LfNDk8l THmNdllyVF5U2rlNtbY+JIWKpvcp6Yc+fKXNowfwzNEQqVg/zC+olwbeAjCgJvMY TtKsUXQ8I4uBkRZGZftK7hpCvQKBH0LqV2NREPe+Yy7n9NH1yUgC1ZbmNHHB4OqB RznSroVPc/k3kuEIeDSBoJcTPX5GiizbIMrgifRTWYRo8A3ODpCXtIai4VLP90WR sZJJKnTi9TlPD6oL5Pwm2OFCZIlionXMKW+JdbQgrxuKy6RSZOiZHwd9D0KP4nIB fpuSUz0Rv5iIU4qDxJw6TJ8dlJrl0+EyEWnImQSBRBX9V/x1ZGsEw43wEh71dCoo pyN5ug== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=xY1xSXp5urOI0Fo8UvuLhAGHcY3r7eRP41kxMCFFg Vo=; b=NdO2oMwqRf+lwFPmciD0ov25q0ZceO+6wloCp0lI4bTka5XNy/5dVtvMa LDG6j4d01Piwt3sj0eqD3yL5q1agjnaDOAcGQDc1l/tpvrgaroTmfSc0HhUjP8ku hNh3W2QrMSGCjFFYkEwJ2qz4gmAq8cbvsiDX6D6ygBj7W4p4xkHsl7j1AIB1zZ+g H82VwMwLHMuobHX/BDMvz+tGwglLQWd1nSX96iRj1dSPjIe4vY/lpMrawQSm9FU6 aILD6HQuP87RXlceYneXsQauOrmCsAia44yfYTll1QEoN/+b289YGfL0gTlNDTHl fRy8Hzeto3sWppTq00k1Dvf0DNF5g== X-ME-Sender: <xms:edFoX93mf3dvUXr2OO9arN5nWoW6eidgegIql1-4PYZ9LdHO8_-KZw> <xme:edFoX0H2kYzAMcWokfQb7bV_2ag3tadGtZpLqurJjdLYgKwZRlFj3GMysLw9RGEe9 3_yq-oedWfj2dTseA> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddvgddutddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: <xmx:edFoX96XsFZDHJz5TadHrN1gvb30wAteK-YIR0FVKpoNdHKX2fxnqQ> <xmx:edFoX62JLVurbn6hI1L5tVsEvmSR7rcuXvMEX9WOCBnCWcl2LRV6Pg> <xmx:edFoXwHR1OmOKBi2h7WNUk9Ztg41IkEo7uxxQ7pZsisZpnadxNWyHQ> <xmx:edFoX0B-oYyeUlDq5Mvia-B_xGha73Os5IsY9cwObyXFDmcFqE577g> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 923C83064682; Mon, 21 Sep 2020 12:14:48 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: "Power, Ciara" <ciara.power@intel.com>, cristian.dumitrescu@intel.com Cc: "dev@dpdk.org" <dev@dpdk.org>, "Mcnamara, John" <john.mcnamara@intel.com>, "Kovacevic, Marko" <marko.kovacevic@intel.com>, "Richardson, Bruce" <bruce.richardson@intel.com> Date: Mon, 21 Sep 2020 18:14:46 +0200 Message-ID: <2501902.3BE8iA8HS7@thomas> In-Reply-To: <DM6PR11MB2555A631A6C461CF31CF510DE63E0@DM6PR11MB2555.namprd11.prod.outlook.com> References: <20200903152717.42095-23-ciara.power@intel.com> <C5H285QL88G1.16CHZIFPFTQ8S@xps> <DM6PR11MB2555A631A6C461CF31CF510DE63E0@DM6PR11MB2555.namprd11.prod.outlook.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 22/37] doc: remove references to make in contributing guides X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 17/09/2020 15:44, Power, Ciara: > Hi Thomas, > > One comment inline. > > Thanks, > Ciara > > > >-----Original Message----- > >From: Thomas Monjalon <thomas@monjalon.net> > >Sent: Monday 7 September 2020 11:21 > >To: Power, Ciara <ciara.power@intel.com>; dev@dpdk.org > >Cc: Kilheeney, Louise <louise.kilheeney@intel.com>; Mcnamara, John > ><john.mcnamara@intel.com>; Kovacevic, Marko > ><marko.kovacevic@intel.com> > >Subject: Re: [dpdk-dev] [PATCH v3 22/37] doc: remove references to make in > >contributing guides > > > > <snip> > > >[...] > >> -Library Statistics > >> ------------------- > >> - > >> -Description > >> -~~~~~~~~~~~ > >> - > >> -This document describes the guidelines for DPDK library-level > >> statistics counter -support. This includes guidelines for turning > >> library statistics on and off and -requirements for preventing ABI > >> changes when implementing statistics. > > > >I think the ABI part is still relevant. > > Looking for some clarification on this. Which parts (if any) of the library statistics section should be > added back in for the ABI section below to make sense being included? Or what do you suggest doing here? I think we can consider we still have the ability to turn stats off because of the #ifdef still being there. Cristian, do you think we should remove this doc? Is on/off still possible in the new pipeline libs? > >[...] > >> -Prevention of ABI changes due to library statistics support > >> -~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > >> - > >> -The layout of data structures and prototype of functions that are > >> part of the -library API should not be affected by whether the > >> collection of statistics -counters is turned on or off for the current > >> library. In practical terms, this -means that space should always be > >> allocated in the API data structures for -statistics counters and the > >> statistics related API functions are always built -into the code, > >> regardless of whether the statistics counter collection is turned -on > >> or off for the current library. > >> - > >> -When the collection of statistics counters for the current library is > >> turned -off, the counters retrieved through the statistics related API > >> functions should -have a default value of zero.