From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F1F6A0C53; Wed, 3 Nov 2021 14:08:52 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7B0A1426DA; Wed, 3 Nov 2021 14:08:52 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 55E8141C26; Wed, 3 Nov 2021 14:08:50 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id E05975C0135; Wed, 3 Nov 2021 09:08:48 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 03 Nov 2021 09:08:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= y+6CjEqCaNU0xwyh+jz/jRLsySkzzl1qO8t+xhR6iIE=; b=OOhz27+n7rX7LF7N FnMuF9WoGq4/XB6HnqhxNk2qPQP2/toKsyg9VHz7bIzbkp5Q4DSXvtvZzM1skc56 /dmIoeGUdEhYNm05/o1dyEZyp+D2vOsgQdee8Ekltf2IHREmc02hrQnOPiBqKu6b 60NeEbvgXwsffKe0H1hvI1jS2FzML2zuh6s5G47pSi2cv8gcYVuaQnhyie9EtEMk g5Wv03pi1q/Hxt9MbiTXj50YB5y6ZwKfrSoU3Xeh4EDfLWCy/Zb2Lv3l0c11UO6k OsLlgEpYqusgQozupIRiAHgFiaXiuFvsdidx555PHwAuySmsHct93BrWEfJDczIR 9VuEdw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=y+6CjEqCaNU0xwyh+jz/jRLsySkzzl1qO8t+xhR6i IE=; b=R1NAUF6+TIb1tn52s1jvhvprMp4NHCqrI+13soazoRxOatMEQ6luQSlJ7 1cXJsEqdNPApEqVxo9tHETqwFA2LHVWGczU6pgb9xZPwol6ZKYr7KQUdnEMX+AFa XslOBRe/aK8P+Vlq/Qr18Yn/d9ES/EnBXY0LnbjWpQdOerVjzxudG7Ba6y+pF4Vi z9WmiMh60ntoEO4Qz2Ps7wIKkPayftjRPjVxc38YMcB8UbKFanA+S6AJe/oBJFHJ u06OprZGOv4CDTDmt8fhv/rX/BmsZzsGMPZaYCJ1Nyic0LPHETqUKEbc5adDLzeR V8IBeAs3D+Wn+xAV+WqAGcnsbaj/w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrtddvgdegjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 3 Nov 2021 09:08:47 -0400 (EDT) From: Thomas Monjalon To: Radu Nicolau Cc: Akhil Goyal , dev@dpdk.org, declan.doherty@intel.com, hemant.agrawal@oss.nxp.com, anoobj@marvell.com, stable@dpdk.org Date: Wed, 03 Nov 2021 14:08:46 +0100 Message-ID: <2503525.8RzHhxm8q0@thomas> In-Reply-To: <20211103115618.3559996-1-radu.nicolau@intel.com> References: <20211103105155.3556048-1-radu.nicolau@intel.com> <20211103115618.3559996-1-radu.nicolau@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] examples/ipsec-secgw: fix potential build error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 03/11/2021 12:56, Radu Nicolau: > When STATS_INTERVAL is set to a non-zero value the core_statistics array > will be defined in multiple compilation units and this can trigger a > linker error on particular environments. In order to fix this the > core_statistics definition was moved out of the header file. So it is not fixing compilation, as we would never apply a patch which would completely break compilation. I would say (in the title) that it moves global variable from header file. > Fixes: 1329602b6c8f ("examples/ipsec-secgw: add per-core packet statistics") > Cc: stable@dpdk.org > > Signed-off-by: Radu Nicolau