Re: [dpdk-dev] [PATCH v2 01/11] eal: add common test assert macros

[Thomas Monjalon <thomas@monjalon.net>]

10/01/2018 20:16, Jerin Jacob:
> -----Original Message-----
> > Date: Fri, 15 Dec 2017 17:02:42 +0530
> > From: Pavan Nikhilesh Bhagavatula <pbhagavatula@caviumnetworks.com>
> > To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
> >  "jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
> >  "santosh.shukla@caviumnetworks.com" <santosh.shukla@caviumnetworks.com>,
> >  "Richardson, Bruce" <bruce.richardson@intel.com>, "Van Haaren, Harry"
> >  <harry.van.haaren@intel.com>, "Eads, Gage" <gage.eads@intel.com>,
> >  "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>, "nipun.gupta@nxp.com"
> >  <nipun.gupta@nxp.com>, "Ma, Liang J" <liang.j.ma@intel.com>
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev]  [PATCH v2 01/11] eal: add common test assert macros
> > User-Agent: NeoMutt/20170609 (1.8.3)
> > 
> > On Fri, Dec 15, 2017 at 10:58:10AM +0000, Ananyev, Konstantin wrote:
> > >
> > >
> > > > -----Original Message-----
> > > > From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavatula@caviumnetworks.com]
> > > > Sent: Friday, December 15, 2017 9:05 AM
> > > > To: Ananyev, Konstantin <konstantin.ananyev@intel.com>; jerin.jacob@caviumnetworks.com; santosh.shukla@caviumnetworks.com;
> > > > Richardson, Bruce <bruce.richardson@intel.com>; Van Haaren, Harry <harry.van.haaren@intel.com>; Eads, Gage <gage.eads@intel.com>;
> > > > hemant.agrawal@nxp.com; nipun.gupta@nxp.com; Ma, Liang J <liang.j.ma@intel.com>
> > > > Cc: dev@dpdk.org
> > > > Subject: Re: [dpdk-dev] [PATCH v2 01/11] eal: add common test assert macros
> > > >
> > > > On Thu, Dec 14, 2017 at 06:43:24PM +0000, Ananyev, Konstantin wrote:
> > > > >
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pavan Nikhilesh
> > > > > > Sent: Thursday, December 14, 2017 3:01 PM
> > > > > > To: jerin.jacob@caviumnetworks.com; santosh.shukla@caviumnetworks.com; Richardson, Bruce <bruce.richardson@intel.com>; Van
> > > > > > Haaren, Harry <harry.van.haaren@intel.com>; Eads, Gage <gage.eads@intel.com>; hemant.agrawal@nxp.com; nipun.gupta@nxp.com;
> > > > > > Ma, Liang J <liang.j.ma@intel.com>
> > > > > > Cc: dev@dpdk.org; Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > > > > > Subject: [dpdk-dev] [PATCH v2 01/11] eal: add common test assert macros
> > > > > >
> > > > > > Adding common test assertion macros for unit testing.
> > > > >
> > > > > Wonder what's wrong with existing RTE_ASSERT() and RTE_VERIFY()?
> > > > > Konstantin
> > > >
> > > > The existing RTE_ASSERT/VERIFY use rte_panic().
> > >
> > > Yes, and wouldn't you expect that behavior from assert() call?
> > 
> > We need to print out the number of successful/failure tests so, we need the
> > test to proceed even if an assert fails.
> > In case of `event_octeontx` we have added a new devargs 'selftest' that can be
> > used to test the driver from any given application.
> > 
> > > Seriously where do you plan to use it outside auto test framework?
> > 
> > We are moving pmd specific tests to respective pmd folder to reduce
> > clutter in auto test area (event devices for now) [1]. So, we need to access
> > the asserts from driver location instead of using CFLAGS to directly include
> > test.h for all the drivers it would be better to have it in eal/common as
> > rte_test.
> > 
> > [1] http://dpdk.org/ml/archives/dev/2017-December/083740.html
> 
> Cc: thomas@monjalon.net
> 
> Any objection to this patch and/or taking this patch through next-eventdev tree?

I am OK with the idea.
But I have some comments on the patch (in v4).