From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id D25E51B010 for ; Wed, 10 Jan 2018 21:18:33 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 74686208C7; Wed, 10 Jan 2018 15:18:33 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Wed, 10 Jan 2018 15:18:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=DIBRB1/JV2shNe5Qk331C7nIND 4+WR3cNtqipOj9Yzc=; b=G21J8pegOjm5QlzSKcNS96P4AiKGWz8VXmiaOC5jZg 1CdKYEI2kZQaLX+evPcRQRJ3sew0GzYPZdwi//sNTqfhLHnRh/Ibrr1JtoJGowEa NlD1w5rb2BZeUBwOsIBWCWQ+XTKr6RyeuqWN7+qk652B0fjiScmQk8O2K0HUkBWu Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=DIBRB1 /JV2shNe5Qk331C7nIND4+WR3cNtqipOj9Yzc=; b=H1E6NW6sk+WQOIKGOu0fn5 w397A/W7q9VUl9R7bQ1XDXHeol3BnxAwSvROIXm+65PpxF/TjFbjJTtjGGkI1pHV 0sY7CN4r3JySE111ZG3KaBi/V8m2RiRKGyic171gLmJlBLAjFyH/gegvT0Z/9NI/ qC9FS3ww3WxjePHwV9xL3+J+VEnNuE0PLF8ymEYhSTFCWXTlCQO4SaEBOlkTfU0F bWlIUcHgBFSf/H81qD7IPJ0oqAsNCXv7d4gTvQQbjulxFaknBszuxgJak7PWU+eh VLPXdPNyzzDs3xnqIFuAhDhM5Jjz+Oixz2XRpYwnaljQ1Cr7wCFqjZkHB8oHMsjw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1D8892456E; Wed, 10 Jan 2018 15:18:33 -0500 (EST) From: Thomas Monjalon To: Jerin Jacob Cc: Pavan Nikhilesh Bhagavatula , "Ananyev, Konstantin" , "santosh.shukla@caviumnetworks.com" , "Richardson, Bruce" , "Van Haaren, Harry" , "Eads, Gage" , "hemant.agrawal@nxp.com" , "nipun.gupta@nxp.com" , "Ma, Liang J" , dev@dpdk.org Date: Wed, 10 Jan 2018 21:18:06 +0100 Message-ID: <2503868.gdONxcMdBa@xps> In-Reply-To: <20180110191658.GB28342@jerin> References: <20171212192713.17620-1-pbhagavatula@caviumnetworks.com> <20171215113241.donmary6yesyssle@Pavan-LT> <20180110191658.GB28342@jerin> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 01/11] eal: add common test assert macros X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2018 20:18:34 -0000 10/01/2018 20:16, Jerin Jacob: > -----Original Message----- > > Date: Fri, 15 Dec 2017 17:02:42 +0530 > > From: Pavan Nikhilesh Bhagavatula > > To: "Ananyev, Konstantin" , > > "jerin.jacob@caviumnetworks.com" , > > "santosh.shukla@caviumnetworks.com" , > > "Richardson, Bruce" , "Van Haaren, Harry" > > , "Eads, Gage" , > > "hemant.agrawal@nxp.com" , "nipun.gupta@nxp.com" > > , "Ma, Liang J" > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v2 01/11] eal: add common test assert macros > > User-Agent: NeoMutt/20170609 (1.8.3) > > > > On Fri, Dec 15, 2017 at 10:58:10AM +0000, Ananyev, Konstantin wrote: > > > > > > > > > > -----Original Message----- > > > > From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavatula@caviumnetworks.com] > > > > Sent: Friday, December 15, 2017 9:05 AM > > > > To: Ananyev, Konstantin ; jerin.jacob@caviumnetworks.com; santosh.shukla@caviumnetworks.com; > > > > Richardson, Bruce ; Van Haaren, Harry ; Eads, Gage ; > > > > hemant.agrawal@nxp.com; nipun.gupta@nxp.com; Ma, Liang J > > > > Cc: dev@dpdk.org > > > > Subject: Re: [dpdk-dev] [PATCH v2 01/11] eal: add common test assert macros > > > > > > > > On Thu, Dec 14, 2017 at 06:43:24PM +0000, Ananyev, Konstantin wrote: > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pavan Nikhilesh > > > > > > Sent: Thursday, December 14, 2017 3:01 PM > > > > > > To: jerin.jacob@caviumnetworks.com; santosh.shukla@caviumnetworks.com; Richardson, Bruce ; Van > > > > > > Haaren, Harry ; Eads, Gage ; hemant.agrawal@nxp.com; nipun.gupta@nxp.com; > > > > > > Ma, Liang J > > > > > > Cc: dev@dpdk.org; Pavan Nikhilesh > > > > > > Subject: [dpdk-dev] [PATCH v2 01/11] eal: add common test assert macros > > > > > > > > > > > > Adding common test assertion macros for unit testing. > > > > > > > > > > Wonder what's wrong with existing RTE_ASSERT() and RTE_VERIFY()? > > > > > Konstantin > > > > > > > > The existing RTE_ASSERT/VERIFY use rte_panic(). > > > > > > Yes, and wouldn't you expect that behavior from assert() call? > > > > We need to print out the number of successful/failure tests so, we need the > > test to proceed even if an assert fails. > > In case of `event_octeontx` we have added a new devargs 'selftest' that can be > > used to test the driver from any given application. > > > > > Seriously where do you plan to use it outside auto test framework? > > > > We are moving pmd specific tests to respective pmd folder to reduce > > clutter in auto test area (event devices for now) [1]. So, we need to access > > the asserts from driver location instead of using CFLAGS to directly include > > test.h for all the drivers it would be better to have it in eal/common as > > rte_test. > > > > [1] http://dpdk.org/ml/archives/dev/2017-December/083740.html > > Cc: thomas@monjalon.net > > Any objection to this patch and/or taking this patch through next-eventdev tree? I am OK with the idea. But I have some comments on the patch (in v4).