From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1715CA04DB; Fri, 16 Oct 2020 18:55:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D038A5A40; Fri, 16 Oct 2020 18:55:53 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 810385A38 for ; Fri, 16 Oct 2020 18:55:51 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 283AF5C0093; Fri, 16 Oct 2020 12:20:35 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 16 Oct 2020 12:20:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= Pis08bkHPnUhfLEzPCFG7nBpboTnNHdL2Z1TZnXZwss=; b=wlc2aVAiVM/EpJDI CqXtbBD2llslXx1RDh74FB5mdHp8v1QDfRwLHnglnjp2G4PdM/Mm3w4jP+1lFwj1 tDDg+Ntke4NePuOFp66uxleuvHOwMdHZS9RqbOKp6LvYv9a1bj9s+r0KtXO2hDDp MhrxxsIM+fu1PNzzxxKlosPUmqgYd7RGCMhwiWasCi43XMcdEU4ofd4yRjQSPYhD bcS1SSg6yY5KFl0N41q1sfcgIpsNLr2yRZNfcGhitmyNsnq3vHdRAUb64/+uB4P3 qKQm+hLw26PiYhJdpOi2lPhmBwq8narkn8mmrpkdIphiQ6DP3BzHBEpXc4tIXnhZ arzAYw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=Pis08bkHPnUhfLEzPCFG7nBpboTnNHdL2Z1TZnXZw ss=; b=b/iUMXi00zdjD4+90mPpdTrnK1ZXkkNeOLOFlP5ykEvqRy4QOev1KlWN4 LJz4f4p1eCMGGGkU1yOqwqWCNO9RxDpnn94uOZk6YlecDLQs2YbiNxA1Pvji/K4+ b9B34Rs05oZNh1YLURMvO6XVdBdKMhPNQox+gSYYqu6GM3jsavUFRvh4/gAJfWsF hqOk8wbiIVRFPyh+hDSY5389Jih8nbdY49BMm0TmcPzywayNwxCl4zIyaXRCE7UO YXC8VbYXmI7xD95bIjSFXRwyCpaGLyQRlq7t5tGtECUfivNB7sji5QRqH8F1dMIW kXpD8A6V2UFjxZpRmJQX0Lj2T8umg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrieehgddutddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8F8FC3064683; Fri, 16 Oct 2020 12:20:33 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: Konstantin Ananyev , dev@dpdk.org, jerinj@marvell.com, ruifeng.wang@arm.com, vladimir.medvedkin@intel.com, David Marchand , olivier.matz@6wind.com Date: Fri, 16 Oct 2020 18:20:32 +0200 Message-ID: <25045955.0zPAtsh5eE@thomas> In-Reply-To: References: <20201005184526.7465-1-konstantin.ananyev@intel.com> <20201006150316.5776-13-konstantin.ananyev@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 12/14] acl: deduplicate AVX512 code paths X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/10/2020 17:56, Ferruh Yigit: > On 10/6/2020 4:03 PM, Konstantin Ananyev wrote: > > @@ -120,7 +161,7 @@ _m256_mask_gather_epi8x4(__m256i pdata, __mmask8 mask) > > > > static const uint32_t zero; > > icc complains about this, although it is static [1]. > Would it be acceptable to initialize variable explicitly to '0'? > > [1] > In file included from ../lib/librte_acl/acl_run_avx512.c(110): > ../lib/librte_acl/acl_run_avx512x8.h(162): warning #300: const variable "zero" > requires an initializer > static const uint32_t zero; icc should be fixed in my opinion It's already hard to have code warning-free for gcc and clang, I don't think we should bother with warnings from exotic compilers. It is not a blocking issue, right?