From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 751CF2E7B for ; Tue, 19 Apr 2016 15:18:21 +0200 (CEST) Received: by mail-wm0-f44.google.com with SMTP id e201so13571227wme.0 for ; Tue, 19 Apr 2016 06:18:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=H1HCxfiH4tv2NlefwLBMTIf/VeAzSKOVTOrPqD5IZK8=; b=OfUT+eTQ0yPx1uY6Q/+8/sAgjWtREDsn6L1zummdEzTJR3QjZVAlbPwNcOHPhs92fM fv7ErbtA700CoUUIGezvlC96zqC0dZ3dquowQQMRk3ANET0kyySBqP45ak4zlcOaJp8c ErjiRyvQtSPFbuFQ9Ru4NPKrKdZrYYWdm2zJDbKUkbazJ1j7ceCrHIvfxkHfmdrY1gNs dvcbzArt8HvMo2y7g/jOPR1wFDsqtZ0rpuY3LF6BhR3cYTZY2/8Nq7P2iL5gOjhl9BUc e4tDfgQmc6Pz+5id/lZ/toXIP4/Xdcmd3GBt9NOk55IdwZ00yk4Ry48DKdI9Q4qISDDQ 7TEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=H1HCxfiH4tv2NlefwLBMTIf/VeAzSKOVTOrPqD5IZK8=; b=b8rpxalGKfLihNTgFkMqEzmFEA608LSItMCyYlJ19J9JkzfMHEul9eifuo/B84kINv VWZXgQt0JvU2EIaaXSmphs0uddjf60jIDHX/fwaD0NCvtLt5uQOxpb83jWF2OVFTNpOq V9B3yUAC3WIQrS+jIInTiFwoUpG2Q1pyPiLy5++0j3OBVc+t5ZHj7MZDXKBvNwCqudWk 2JKb9uOyZYiNK8DNGVS4oO+tHWQFIWMUDMI//cZbQBqc/e8mybbsJyBUAIQQ85aajgNo 9P1KglSPS6DoSXIptJI3l1TFZT+WxLMYEGGGyTlqHKIWqrvgXbFG50MmgnNh79RNNcOV M9mg== X-Gm-Message-State: AOPr4FXXAuqinKMiMxefGGASRL3QZDeBShIpNWejhyHeLItV1YayAz2F+1ZHnpWALXKEzt6X X-Received: by 10.28.141.141 with SMTP id p135mr23361060wmd.8.1461071901297; Tue, 19 Apr 2016 06:18:21 -0700 (PDT) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id da5sm238909wjb.25.2016.04.19.06.18.20 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 19 Apr 2016 06:18:20 -0700 (PDT) From: Thomas Monjalon To: Rasesh Mody Cc: bruce.richardson@intel.com, dev@dpdk.org, stephen@networkplumber.org, ameen.rahman@qlogic.com, harish.patil@qlogic.com, sony.chacko@qlogic.com Date: Tue, 19 Apr 2016 15:18:18 +0200 Message-ID: <2505656.AloKTgdrC8@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1459476927-21387-6-git-send-email-rasesh.mody@qlogic.com> References: <1459476927-21387-1-git-send-email-rasesh.mody@qlogic.com> <1459476927-21387-6-git-send-email-rasesh.mody@qlogic.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 05/10] qede: Add core driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2016 13:18:21 -0000 2016-03-31 19:15, Rasesh Mody: > The Qlogic Everest Driver for Ethernet(QEDE) Poll Mode Driver(PMD) is > the DPDK specific module for QLogic FastLinQ QL4xxxx 25G/40G CNA family > of adapters as well as their virtual functions (VF) in SR-IOV context. > > This patch adds QEDE PMD, which interacts with base driver and > initialises the HW. After removing the BIT_MACRO check (see http://dpdk.org/patch/12113) and other false positives, there is only one warning from checkpatches.sh: CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #1933: FILE: drivers/net/qede/qede_main.c:152: + DP_NOTICE(edev, false, "Invalid fw size: %" PRIu64"\n",