From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 3AE6B952 for ; Mon, 6 Mar 2017 16:03:39 +0100 (CET) Received: by mail-wm0-f53.google.com with SMTP id t193so66886558wmt.1 for ; Mon, 06 Mar 2017 07:03:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=5CFyqYFh0kK4uSYaOZSd1HaFZHSBkkHMMLovbBuli74=; b=TLTbqY7z3nOInOX0XYDKRMGIEuafzlM6wDPaR/ryDO1TVnjoE9IXEqPrJCu8ztvlHK hE+8gNPVY2vpYonlPjP5pb91NoR8z9n4Jh/YqFOWoGsrnmGXDCnGfKZIzjWc94OO28Qz ua4heAppbLqTsgeXu9U0ZZgpTzMyVP/6Li9jdJ6qjHfdUPTdlGbqGEaw6r5w721YS2zK GL9ErKIwQPyjVm7MBRv2N8jko5x8XJi2pLPO2PDIXKW8txfWCFvhOYbsYlLT2GBoXCgv K2Jhy49uM8Q6y4/oDwXUvx2afNaZUXB4O66WB1vrx+mnmx2cg/3QKp5ytR0h+W16pfUd /+OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=5CFyqYFh0kK4uSYaOZSd1HaFZHSBkkHMMLovbBuli74=; b=NMQiQ02qxg8Bz/FamG/S0uViAkL/qA2BuRX/10+Zvhe6A5pk/qMcGchPJRvDXyEImU F2VKMqyboKid2HwD+hWTBEeX9M1TW0rrP+ITKu7XmTDP45bV8VxbyHthxvysUjVXMduA H7fT85ByHXlvRVUSFKKMl8z7afe/5wmUijswQV0Ey/TfwMQpr7EWx9CKJCJEYD8SFs13 DQvsG7fBEIt0Tmbxf5g47SPEhUx41pjX39+m4rDDNlRLohHwI7Hnm9O87Gtg4ybuy4Cs uBWjErMZEhHeqphD424SAGreW+O8gtNwI5QMoNh/xnbuHt9ndCUVOsWCtY09VXACM2VV ojXw== X-Gm-Message-State: AMke39nCR2yiXvRLQaREIjrJ0tq/YAGcrxLc71+9hpuc4+V/fLwix1u8QBT3rDe5LuKQFJ4O X-Received: by 10.28.152.212 with SMTP id a203mr13591475wme.36.1488812618683; Mon, 06 Mar 2017 07:03:38 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id b63sm5549386wrd.15.2017.03.06.07.03.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Mar 2017 07:03:38 -0800 (PST) From: Thomas Monjalon To: Allain Legacy Cc: dev@dpdk.org Date: Mon, 06 Mar 2017 16:03:37 +0100 Message-ID: <2505793.pX2btbRxNH@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1488390259-40462-1-git-send-email-allain.legacy@windriver.com> References: <1488390259-40462-1-git-send-email-allain.legacy@windriver.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] devtools: add long lines to the list of options X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Mar 2017 15:03:39 -0000 2017-03-01 12:44, Allain Legacy: > The checkpatch.pl tool is flagging warnings on long debug log strings. > Since splitting these strings makes it difficult to search for logs it is > preferred to allow these as exceptions to the long line rule. The addition > of the LONG_LINE_STRINGS to the list of exceptions will allow lines that > end with a string to exceed the maximum line length, but lines that end > with variables or other constructs will still be flagged as errors. Also, > lines that make use of PRIx64 with string concatenation will still be > flagged if the beginning of the last string fragment begins after the 80 > character threshold. > > Signed-off-by: Allain Legacy [...] > --- a/devtools/checkpatches.sh > +++ b/devtools/checkpatches.sh > @@ -45,7 +45,7 @@ options="$options --ignore=LINUX_VERSION_CODE,FILE_PATH_CHANGES,\ > VOLATILE,PREFER_PACKED,PREFER_ALIGNED,PREFER_PRINTF,\ > PREFER_KERNEL_TYPES,BIT_MACRO,CONST_STRUCT,\ > SPLIT_STRING,LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\ > -NEW_TYPEDEFS,COMPARISON_TO_NULL" > +NEW_TYPEDEFS,COMPARISON_TO_NULL,LONG_LINE_STRING" Applied and gathered LONG_LINE_STRING and SPLIT_STRING on the same line. Thanks