From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5518FA04DD; Wed, 28 Oct 2020 08:43:27 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 23BF79B04; Wed, 28 Oct 2020 08:43:26 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id C06D42BD5 for ; Wed, 28 Oct 2020 08:43:23 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 6AA155C012C; Wed, 28 Oct 2020 03:43:22 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 28 Oct 2020 03:43:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= p+K6s58/jvwT66KeXM/N8iSjeN4M9u7VpOnNwnyzHuI=; b=a35FIBv4XJSz6J6f XE0ecdhiM6VxSJ/6JC1h/XmA0nI+ABqNSSTGASn3j7j9JbUBniuEWnBTXRNAnzXI paB1SPLzK1u7Xoj9LktHIg/9f7WPCxZjs9bA/k0kTnKU0N1ZriD/Xj9+aWtJRooQ 8i8+EZvbVcW4NIEVF6FKeg2oIQVYpZiL3UGgLNqgxiNKu/Q6VSr1CuKUbb2WBCiY BDqBJd3VPpIDntMAM2/i1MXV2I8+zllA11qKTUa7LGcmZVCGUgAWRybdbbGdF+ZU naTkWXe2+b8wXLo1lhiTftJ7XSS35KHerkmr5fuV9/yFbp6dqm6UQMEaGpIBdjoT l3wxQw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=p+K6s58/jvwT66KeXM/N8iSjeN4M9u7VpOnNwnyzH uI=; b=SM69l3nH9JEWgNpqICqUJUdmbFKA66Zid7W4Hr9iK/ZSbXdFc/EnvrFra t/Eq08S5YkVMIhw3Eo9ee1yPj5Mr/Y/uHxtXbaAF9c7Bmh7J6vXjaVh6vDoLV0RZ H3K+vfpQsfB8epZEfwgJvq6OGcdxcfQnkFfDsGHfCsDeEp4hhuOUixYg1lL4l9Cz 863Smmhkv/+WTWIoWvmNbJuDqqlcizl+YOrwalNBlFYh1ab4U6QtboRKcM84eyBq bt1m3/siVk+0Xex8KogTpx6L4SOkSC3kiZTq+wVQatDiOCKFJrhae12GfZT7efA1 rxxt8+d5t8FBFl36vQMsv5ruRZAUw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrledtgddutdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 701AA3064674; Wed, 28 Oct 2020 03:43:20 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob , Jerin Jacob Cc: "McDaniel, Timothy" , dpdk-dev , Ferruh Yigit , David Marchand , "Richardson, Bruce" , Olivier Matz , Andrew Rybchenko , Akhil Goyal Date: Wed, 28 Oct 2020 08:43:19 +0100 Message-ID: <25061618.yxkc6rsGur@thomas> In-Reply-To: References: <20201026052105.1561859-1-thomas@monjalon.net> <20201027210115.2529025-13-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 12/15] app/eventdev: switch flow ID to dynamic mbuf field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 28/10/2020 05:54, Jerin Jacob: > On Wed, Oct 28, 2020 at 2:35 AM Thomas Monjalon wrote: > > > > The order test stored the flow ID in the deprecated mbuf field udata64. > > It is moved to a dynamic field in order to allow removal of udata64. > > > > Signed-off-by: Thomas Monjalon > > --- > > + static const struct rte_mbuf_dynfield flow_id_dynfield_desc = { > > + .name = "test_event_dynfield_flow_id", > > + .size = sizeof(flow_id_t), > > + .align = __alignof__(flow_id_t), > > + }; > > + flow_id_dynfield_offset = > > + rte_mbuf_dynfield_register(&flow_id_dynfield_desc); > > > Since this path used in fastpath, could you move flow_id_dynfield_offset to > test_order's initial entry as that cache will be warm always. I don't understand. Are you talking about the offset value? This field will be in the second part of mbuf, as udata64 was. Or are you talking about the storage of the offset variable? > > + if (flow_id_dynfield_offset < 0) { > > + evt_err("failed to register mbuf field"); > > + return -rte_errno; > > + } > > + > > test_order = rte_zmalloc_socket(test->name, sizeof(struct test_order), > > RTE_CACHE_LINE_SIZE, opt->socket_id); > > See above You mean the offset should be stored in this struct test_order?