From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7628DA04FA; Thu, 6 Feb 2020 10:26:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0318B1C0AA; Thu, 6 Feb 2020 10:26:29 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id A74FA1C02E for ; Thu, 6 Feb 2020 10:26:27 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A34DE21F8A; Thu, 6 Feb 2020 04:26:24 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 06 Feb 2020 04:26:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Uilpr4X3Hv5emlWCrFbxJN1ijNNmRDt/vxku5oI9pso=; b=ZsVW62nckK1Q xJCxXbHzE4HnLb/AYqPbb2ljoKeeyp0GapJhbmYIet0/+cWlyJ1uKoFeCMaaAUms NV0bnGTRFJK9R9GBuLnMSWaeacQtgUHaVfl1LhDkWUnIxuUQAdikTbpaTQpW5sDJ 8om5kjo1vtzF3mdFFSoMha4p5tziJjI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Uilpr4X3Hv5emlWCrFbxJN1ijNNmRDt/vxku5oI9p so=; b=ftQ4Vs+YH9gmiJc+7F1DG5/NfSZgSHjH4yFdCMmD8MhANgTFs69tw6nrZ n53lqYjxPY1hxu3wjjzNO7XyBIA8lrtESQM7S3ZFglSnQM60/ieNtgnQ28t68Dh+ RIvMUXKs6L8WZvWsqcxdTNClA3EZ9SYgcGNXYCHJ/KEtFENoakm9Am8jsfkAGHqy OC8KKwMFsp53XcbZDm7320Z+kHTuYjerDETT8bIHCDFSN1/8jhDVPDAB4QuvtVNm yZS8AoCDhjVCd3DNZYR0l6CLaoW6IQSSt2q8NT0Jh+seO0ecsEGQCNTZWLU1hMTB lOt5LRtMzR4AvBfkzPYIcNmO7eb4g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrheefgddtvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3D13A3280059; Thu, 6 Feb 2020 04:26:23 -0500 (EST) From: Thomas Monjalon To: Pallavi Kadam , Dmitry Kozlyuk , Harini.Ramakrishnan@microsoft.com, ranjit.menon@intel.com Cc: dev@dpdk.org, keith.wiles@intel.com, bruce.richardson@intel.com, david.marchand@redhat.com, jerinjacobk@gmail.com, antara.ganesh.kolar@intel.com Date: Thu, 06 Feb 2020 10:26:22 +0100 Message-ID: <2506476.uZKlY2gecq@xps> In-Reply-To: <20200206094137.66a3bc7e@Sovereign> References: <20200131000307.10608-1-pallavi.kadam@intel.com> <50a4ad5d-d1f2-52a7-5265-e3f0c88114c5@intel.com> <20200206094137.66a3bc7e@Sovereign> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v7 9/9] eal: add minimum viable code to support parsing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" As discussed in community meeting, the goal was to have core parsing in Windows EAL 20.02. Given that there is a crash and a doubt on the imported getopt library, I think it's better to postpone this series to 20.05. 06/02/2020 07:41, Dmitry Kozlyuk: > > On 2/5/2020 4:39 PM, Pallavi Kadam wrote: > > > On 2/5/2020 11:54 AM, Dmitry Kozlyuk wrote: > > >> Crashes at argument parsing, WinDbg log attached. > > > This patch works fine with meson=0.49. > > > I was able to execute the 'helloworld' app. > > > > > > When I tried to build with meson=0.52 it failed with the error: > > > [9/25] Linking target lib/librte_kvargs-20.0.dll. > > > FAILED: lib/librte_kvargs-20.0.dll > > > clang @lib/librte_kvargs-20.0.dll.rsp > > > clang: error: no such file or directory: '/OPT:REF' > > > > Fixed this error with the patch you sent before. > > were able to execute parsing: > > > > $ ./build/examples/dpdk-helloworld.exe -l 4-8 > > EAL: Detected 20 lcore(s) > > EAL: Detected 2 NUMA nodes > > hello from core 5 > > hello from core 6 > > hello from core 7 > > hello from core 8 > > hello from core 4 > > > > > > > > Not completely sure, if this could be the reason for the crash. > > The crash does not happen with any arguments, "-l 4-8" works fine as do > "-cf" and "-v", but "--log-level=eal:8" crashes reproducibly. I assume > application should not crash on invalid options, but report an error and exit. > For the reference, I applied your patchset to the latest dpdk:master. > > Z:\>build\native\clang\examples\dpdk-helloworld.exe > EAL: Detected 4 lcore(s) > EAL: Detected 1 NUMA nodes > > OK, no lcores specified. > > Z:\>build\native\clang\examples\dpdk-helloworld.exe -cf > EAL: Detected 4 lcore(s) > EAL: Detected 1 NUMA nodes > hello from core 1 > hello from core 2 > hello from core 3 > hello from core 0 > > OK, 4 lcores enabled. > > Z:\>build\native\clang\examples\dpdk-helloworld.exe -cf --log-level=eal:8 > > Crash, WinDbg log attached to bug report. > > Z:\>echo %errorlevel% > -1073741819 > > Z:\> > > Attaching the build log, but I don't think it matters, it's something with > getopt implementation or it's use, judging by stack trace. > > P.S. I can also see "--syslog" option in the help message, you should > probably hide it via #ifndef, as you did with said option handling.