From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 30A96A0C61; Fri, 5 Nov 2021 10:58:02 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 13989410DC; Fri, 5 Nov 2021 10:58:02 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 07D2D40E5A for ; Fri, 5 Nov 2021 10:58:00 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 754985C0121; Fri, 5 Nov 2021 05:57:59 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 05 Nov 2021 05:57:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= /feI7mMd6LZarvY1Z/z3pnRT/e/rE5LJeq/6jBQUe9Y=; b=Kfl28lXUpA75qC5U BTSlu575GL3+3vmIhsdGgpvEs5qilJ74av5LkNO3mToQsB86cuZGUy/+l8JBYBDq Q29GJvDrqzbGXmwMTmIB4P2vnzS7UX2OkKyYc6lO1/nha962cwUCRGXU/udwGbgY JawluaAEyqGRtONp5TZlMjs27qkMgsvDbIw9Or2L3d9kbMFblDDn5sdLpSes5R8M G0T1Bq2uuGUNToVJYiDz383auX+1UsVQq9glKo+Il9kgY1CE4j2yXeEKlM21JqWf SqPZ7+tfR+kSgqWC3ekV5RTHkYvP7KZEivB+JUqXYNzXj3CR/B1LvaYAwGqaE891 6f1kpg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=/feI7mMd6LZarvY1Z/z3pnRT/e/rE5LJeq/6jBQUe 9Y=; b=BcU7UKAmROVcdFjO9E4wCDQSGONoxQyp9b/mHXWzqAbYvWpuTlo6XIFow A0y2mHNvUCFmejg8GmB9+RQbLp+340Jkjr1g3q83nVVJ0GnUyw1xmDHEw3ZqiF2K cmvsQxCzQC9qJ//6tYmqtjjhKOPzzk07R843A8GNReqmQYwSrdsnkVhhzbwG4lMI iWVXrnZBAW+NryLQ4tLW7Zjel47eezQIEoDL+4O4pFA4z+TO4jdgkrjwOYUHckhu sHzOKJF81SNcOu7801kGuDhlpVdL7ctl+7wVqwAODWlijyCAmj7Q/WcSQBCfwxiu xWw51qJ/+LVgDhJx0dBjOxF/ITz8g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrtdeigddtkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeekteehtdeivefhieegjeelgedufeejheekkeetueevieeuvdevuedt jeevheevteenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 5 Nov 2021 05:57:58 -0400 (EDT) From: Thomas Monjalon To: Wisam Jaddo , Rongwei Liu Cc: matan@nvidia.com, viacheslavo@nvidia.com, orika@nvidia.com, dev@dpdk.org, rasland@nvidia.com, Haifei Luo , Jiawei Wang Date: Fri, 05 Nov 2021 10:57:57 +0100 Message-ID: <2507603.9PVMiUTV9K@thomas> In-Reply-To: <20211028032600.638212-2-rongweil@nvidia.com> References: <20211028032600.638212-1-rongweil@nvidia.com> <20211028032600.638212-2-rongweil@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 1/3] app/flow-perf: support meter policy API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 28/10/2021 05:25, Rongwei Liu: > @@ -854,6 +862,46 @@ args_parse(int argc, char **argv) > RTE_MAX_LCORE); > } > } > + if (strcmp(lgopts[opt_idx].name, "policy-mtr") =3D=3D 0) { > + j =3D 0; > + k =3D 0; > + arg =3D optarg; > + policy_mtr =3D true; > + token =3D strsep(&arg, ":\0"); > + while (token !=3D NULL && j < RTE_COLORS) { > + actions_str[j++] =3D token; > + token =3D strsep(&arg, ":\0"); > + } > + j =3D 0; > + token =3D strtok(actions_str[0], ",\0"); > + while (token =3D=3D NULL && j < RTE_COLORS - 1) > + token =3D strtok(actions_str[++j], ",\0"); > + while (j < RTE_COLORS && token !=3D NULL) { > + for (i =3D 0; > + i < RTE_DIM(flow_options); i++) { > + if (!strcmp(token, > + flow_options[i].str)) { > + all_actions[j][k++] =3D > + flow_options[i].mask; > + break; > + } > + } > + /* Reached last item with no match */ > + if (i >=3D RTE_DIM(flow_options)) { > + fprintf(stderr, > + "Invalid actions " > + "item: %s\n", token); > + usage(argv[0]); > + rte_exit(EXIT_SUCCESS, "Invalid actions item\n"); > + } > + token =3D strtok(NULL, ",\0"); > + while (!token && j < RTE_COLORS - 1) { > + token =3D strtok(actions_str[++j], > + ",\0"); > + k =3D 0; > + } > + } > + } Could we avoid having so many indents? Checkpatch suggest considering a refactoring. [...] > + fill_actions(actions[i], all_actions[i], 0, 0, 0, > + 0, 0, 0, unique_data, rx_queues_count); error: too few arguments to function =E2=80=98fill_actions=E2=80=99 That's a rebase issue because I merged first the patch "app/flow-perf: add destination ports parameter"