* [dpdk-dev] [PATCH] raw/ioat: fix compiler warning for incorrect include
@ 2019-07-23 16:26 Bruce Richardson
2019-07-23 18:51 ` Thomas Monjalon
2019-07-23 18:53 ` David Marchand
0 siblings, 2 replies; 3+ messages in thread
From: Bruce Richardson @ 2019-07-23 16:26 UTC (permalink / raw)
To: dev; +Cc: david.marchand, Bruce Richardson
Some builds with clang report an error because '<>' rather than '""' were
used for including the ioat spec header file.
Target: x86_64-native-bsdapp-clang
22:10: error: 'rte_ioat_spec.h' file not found with <angled> include; use "quotes" instead
#include <rte_ioat_spec.h>
^~~~~~~~~~~~~~~~~
"rte_ioat_spec.h"
1 error generated.
Since this file should always be in the same directory as the main header,
we can safely change the include line to fix this error.
Fixes: abff4333ec20 ("raw/ioat: create device on probe and destroy on release")
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
drivers/raw/ioat/rte_ioat_rawdev.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/raw/ioat/rte_ioat_rawdev.h b/drivers/raw/ioat/rte_ioat_rawdev.h
index 7a89632e7..4b271f174 100644
--- a/drivers/raw/ioat/rte_ioat_rawdev.h
+++ b/drivers/raw/ioat/rte_ioat_rawdev.h
@@ -19,7 +19,7 @@
#include <rte_memory.h>
#include <rte_memzone.h>
#include <rte_prefetch.h>
-#include <rte_ioat_spec.h>
+#include "rte_ioat_spec.h"
/** Name of the device driver */
#define IOAT_PMD_RAWDEV_NAME rawdev_ioat
--
2.21.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] raw/ioat: fix compiler warning for incorrect include
2019-07-23 16:26 [dpdk-dev] [PATCH] raw/ioat: fix compiler warning for incorrect include Bruce Richardson
@ 2019-07-23 18:51 ` Thomas Monjalon
2019-07-23 18:53 ` David Marchand
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2019-07-23 18:51 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev, david.marchand
23/07/2019 18:26, Bruce Richardson:
> Some builds with clang report an error because '<>' rather than '""' were
> used for including the ioat spec header file.
>
> Target: x86_64-native-bsdapp-clang
> 22:10: error: 'rte_ioat_spec.h' file not found with <angled> include; use "quotes" instead
> #include <rte_ioat_spec.h>
> ^~~~~~~~~~~~~~~~~
> "rte_ioat_spec.h"
> 1 error generated.
>
> Since this file should always be in the same directory as the main header,
> we can safely change the include line to fix this error.
>
> Fixes: abff4333ec20 ("raw/ioat: create device on probe and destroy on release")
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] raw/ioat: fix compiler warning for incorrect include
2019-07-23 16:26 [dpdk-dev] [PATCH] raw/ioat: fix compiler warning for incorrect include Bruce Richardson
2019-07-23 18:51 ` Thomas Monjalon
@ 2019-07-23 18:53 ` David Marchand
1 sibling, 0 replies; 3+ messages in thread
From: David Marchand @ 2019-07-23 18:53 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev
On Tue, Jul 23, 2019 at 6:27 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> Some builds with clang report an error because '<>' rather than '""' were
> used for including the ioat spec header file.
>
> Target: x86_64-native-bsdapp-clang
> 22:10: error: 'rte_ioat_spec.h' file not found with <angled> include; use "quotes" instead
> #include <rte_ioat_spec.h>
> ^~~~~~~~~~~~~~~~~
> "rte_ioat_spec.h"
> 1 error generated.
>
> Since this file should always be in the same directory as the main header,
> we can safely change the include line to fix this error.
>
> Fixes: abff4333ec20 ("raw/ioat: create device on probe and destroy on release")
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Still a bit skeptical at why we did not see this on linux..
But this can't hurt and hopefully it fixes the issue :-)
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-23 18:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-23 16:26 [dpdk-dev] [PATCH] raw/ioat: fix compiler warning for incorrect include Bruce Richardson
2019-07-23 18:51 ` Thomas Monjalon
2019-07-23 18:53 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).