From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B3D6AA04A4; Sun, 24 May 2020 17:39:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1F01E1D452; Sun, 24 May 2020 17:39:30 +0200 (CEST) Received: from wnew3-smtp.messagingengine.com (wnew3-smtp.messagingengine.com [64.147.123.17]) by dpdk.org (Postfix) with ESMTP id E48EA1D44F for ; Sun, 24 May 2020 17:39:27 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.west.internal (Postfix) with ESMTP id 24A798AC; Sun, 24 May 2020 11:39:26 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Sun, 24 May 2020 11:39:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= F8tHFWHjov6B8WIq3OsqOKRSdW50qALDN1JH1sBNeIE=; b=FtKEAFje9EvemyWa g/7jvK6dz8GsZoF0ilSV9sslLs+rU7Rn083LEhKCFfVvq82TQ3xuah8Dw2EaH5dm mZvOj/hMF9j2tyG7GjdQFG7kcD/smDKnJtGVaTdW3jZdo3ZImqB2L+U41v5BkX55 ZzzaLQqEdkn4vPH4LhUiiKsG4ZSN8EVyNBIPg0umRc3Q88zKsThcuFGHGg9BRN/H oN9I679Yefek6oDdXuOZC2nttKbA+ANyuPhmKD35NdKCfwTdMZYcG31qLgg+CV24 LtYPYKDMJGdPqKn47uKqVTmt4OmTkfT4Hi1yUkg4a0YB3/II+S3Q+b1Y2zCFN9SA FdagwQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=F8tHFWHjov6B8WIq3OsqOKRSdW50qALDN1JH1sBNe IE=; b=ZF56u8eI2GRJ3qE9iah1hoEMCIt7VMN2BdSuoCOfcrGqPbuk4qZUj51Ex L4GsUvgiFkQdX3OMVwT6nOAt4RRaD3ZYhvOQppKE1pPoIslxGxM5BIuwjmydkzZq LrwRp0YM0TaMNfD0SBQChKkvNpzrB5i9FVDxroPLw5WcWFswjxU2z4eJ4KYCy36Q 2vJ7LtFHQ2Ah3xcVTfvFGKyqCAbwXmn1iTQlOWpDS52OiS9A9alqfGbmVW/Iya/6 t4TPKxpUUQQdlMjF4UIOe7SER7KXUma1zVvx1MqYWiq7Ozv4g38jkm9k8BQec1nS 8u+1GPrsENcSh49qOMu+XCCwPtOuA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedruddukedgledtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttddunecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepfeegffeihfeftedthfdvgfetkeffffdukeevtdevtddvgfevuedu veegvdeggedtnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id AED06328005E; Sun, 24 May 2020 11:39:22 -0400 (EDT) From: Thomas Monjalon To: guohongzhi1@huawei.com, Morten =?ISO-8859-1?Q?Br=F8rup?= Cc: dev@dpdk.org, olivier.matz@6wind.com, konstantin.ananyev@intel.com, jiayu.hu@intel.com, ferruh.yigit@intel.com, nicolas.chautru@intel.com, cristian.dumitrescu@intel.com, zhoujingbin@huawei.com, chenchanghu@huawei.com, jerry.lilijun@huawei.com, haifeng.lin@huawei.com Date: Sun, 24 May 2020 17:39:21 +0200 Message-ID: <2509615.2cdVMNa4ag@thomas> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35C60FE7@smartserver.smartshare.dk> References: <20200515130850.12760-1-guohongzhi1@huawei.com> <2292747.XxK6CxzJO9@thomas> <98CBD80474FA8B44BF855DF32C47DC35C60FE7@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Subject: Re: [dpdk-dev] [PATCH] lib/librte_net: fix bug for checksum calculating X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 24/05/2020 17:31, Morten Br=F8rup: > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > Sent: Sunday, May 24, 2020 5:12 PM > >=20 > > 15/05/2020 15:08, guohongzhi: > > > 1.rte_ipv4_cksum will return invalid checksum value like 0xffff.(rfc1= 624) > > > 2.__rte_raw_cksum should consider Big Endian. > > > 3.checksum 0x0000 is invalid for udp, but valid for tcp.(rfc768) > >=20 > > Please consider doing 3 patches, thanks. > >=20 > > It was sent late for 20.05, I prefer not taking any risk, > > and wait for maintainers approval. > > The patches must be reviewed and discussed in 20.08 timeframe. >=20 > This patch fixes a bug, which is incompatible with some very popular Broa= dcom switch silicon, so the patch should be treated as such. >=20 > However, I agree that the review responsibility is not Thomas' alone; mai= ntainers should step up if they consider this bugfix critical. Unfortunately, the lack of "Signed-off-by" is really blocking the merge. I am not allowed adding such thing. Given the bug was already there for a long time, it is probably not so much critical anyway.