From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id EDA523253; Mon, 13 May 2019 17:08:46 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6E5C223555; Mon, 13 May 2019 11:08:46 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 13 May 2019 11:08:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=/kvu4Xfi/L/gXY2QWLLS8XrrkAUr97/zTaKktnOGzlo=; b=Bnnfh5vOchy4 E1iy/qiBviwhGIwLCDDGSDNG49rC5NS1vFhD8Hj7tXVXzbS52eq2rZiVAUhtLH1D zwPzYw81rX/oFe9gglBKT2aTwvVIGyzVOB3qPlBaoagcwMi3CqzK/SFPfjwTgN4b FxQV0fufE+xvuWYbC/JEJ7oolk/Rbqc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=/kvu4Xfi/L/gXY2QWLLS8XrrkAUr97/zTaKktnOGz lo=; b=meAiwHaGZ+9OVva8pBPu7D493o0Mhe7ZsgP0ugU/N2UIdgb5mE1Zpv2g9 VSn/CXTh4Y0dKj0LLvzl5JuWrLSQB99qCEHn/K1iZpE2oTPSnBDJ6b2CWnmOzre0 za8ZbHLKOo8iyeYCWJ0b6TKqXz7oepIzJd2cGmL+Vm2Ly7wzfKv6jALreTApXHqY fPhdRxfVzEjWMlrJwPo01cjdFaUfR+ji9hbtdcjPpk6feaZZ8pznJfL+xHFTWUWb z3cjCAwUKqoLRcOnK67q2esvFUzdGJCibbwrfJ74p9cOtJ3vll0kpATAeHFGke2T 0EWaBsW4o1ESv7aRda5g8gE/rNZ+A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrleeggdekgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C96A7103CB; Mon, 13 May 2019 11:08:44 -0400 (EDT) From: Thomas Monjalon To: "Zhao1, Wei" Cc: stable@dpdk.org, "dev@dpdk.org" , "Peng, Yuan" , "Yigit, Ferruh" , "Lu, Wenzhuo" Date: Mon, 13 May 2019 17:08:43 +0200 Message-ID: <2509963.rd1WEIMWAk@xps> In-Reply-To: References: <1557386447-57225-1-git-send-email-wei.zhao1@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix offloads overwrite by default configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 May 2019 15:08:47 -0000 13/05/2019 05:30, Zhao1, Wei: > From: Zhao1, Wei > > There is an error in function rxtx_port_config(), which may overwrite offloads > > configuration get from function launch_args_parse() when run testpmd app. So > > rxtx_port_config() should do "or" for port offloads. > > > > Fixes: d44f8a485f5d ("app/testpmd: enable per queue configure") > > cc: stable@dpdk.org > > > > Signed-off-by: Wei Zhao > Tested-by: Peng Yuan Applied, thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id B29BFA00E6 for ; Mon, 13 May 2019 17:08:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 391204CA0; Mon, 13 May 2019 17:08:49 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id EDA523253; Mon, 13 May 2019 17:08:46 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6E5C223555; Mon, 13 May 2019 11:08:46 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 13 May 2019 11:08:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=/kvu4Xfi/L/gXY2QWLLS8XrrkAUr97/zTaKktnOGzlo=; b=Bnnfh5vOchy4 E1iy/qiBviwhGIwLCDDGSDNG49rC5NS1vFhD8Hj7tXVXzbS52eq2rZiVAUhtLH1D zwPzYw81rX/oFe9gglBKT2aTwvVIGyzVOB3qPlBaoagcwMi3CqzK/SFPfjwTgN4b FxQV0fufE+xvuWYbC/JEJ7oolk/Rbqc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=/kvu4Xfi/L/gXY2QWLLS8XrrkAUr97/zTaKktnOGz lo=; b=meAiwHaGZ+9OVva8pBPu7D493o0Mhe7ZsgP0ugU/N2UIdgb5mE1Zpv2g9 VSn/CXTh4Y0dKj0LLvzl5JuWrLSQB99qCEHn/K1iZpE2oTPSnBDJ6b2CWnmOzre0 za8ZbHLKOo8iyeYCWJ0b6TKqXz7oepIzJd2cGmL+Vm2Ly7wzfKv6jALreTApXHqY fPhdRxfVzEjWMlrJwPo01cjdFaUfR+ji9hbtdcjPpk6feaZZ8pznJfL+xHFTWUWb z3cjCAwUKqoLRcOnK67q2esvFUzdGJCibbwrfJ74p9cOtJ3vll0kpATAeHFGke2T 0EWaBsW4o1ESv7aRda5g8gE/rNZ+A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrleeggdekgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C96A7103CB; Mon, 13 May 2019 11:08:44 -0400 (EDT) From: Thomas Monjalon To: "Zhao1, Wei" Cc: stable@dpdk.org, "dev@dpdk.org" , "Peng, Yuan" , "Yigit, Ferruh" , "Lu, Wenzhuo" Date: Mon, 13 May 2019 17:08:43 +0200 Message-ID: <2509963.rd1WEIMWAk@xps> In-Reply-To: References: <1557386447-57225-1-git-send-email-wei.zhao1@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix offloads overwrite by default configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190513150843.rrLK3H2PcYAd3X7Z4fJJsydxqCrOeHmTZG8IaB_2uUg@z> 13/05/2019 05:30, Zhao1, Wei: > From: Zhao1, Wei > > There is an error in function rxtx_port_config(), which may overwrite offloads > > configuration get from function launch_args_parse() when run testpmd app. So > > rxtx_port_config() should do "or" for port offloads. > > > > Fixes: d44f8a485f5d ("app/testpmd: enable per queue configure") > > cc: stable@dpdk.org > > > > Signed-off-by: Wei Zhao > Tested-by: Peng Yuan Applied, thanks