From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 52663FEB; Wed, 31 Oct 2018 19:30:02 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id EA27F21949; Wed, 31 Oct 2018 14:30:01 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 31 Oct 2018 14:30:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=cp3+NEFT/K8mV8CW9zXhBkvc1+yyvBY//mDK/stpgmY=; b=ip8EQYdvQSUu Zwzrvp4zotnPi9KUj9lVwcT8ga/tXVobOY2Ywlfgjj/feKo9ubrNwfFlXTJdJz0G z0TVepDgLTTJ+5tDdae40jIRL7r8yQBIUwj661sI2fSr2YoeKolz+jxt4NmG4d9Y p83qrDSPMRRr4c45ZBcLxsi1F+d8EC0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=cp3+NEFT/K8mV8CW9zXhBkvc1+yyvBY//mDK/stpg mY=; b=AbvzuYm4MfrNV5O+g7Vx2SQ6nBBDRERDUvxbKU/yEA6lwlqVkLcOrZBn2 DKFjmNJuGGZO9s2PMTKSFNcsDWYOVT/ozUEGSNjBqM8zSj11/9WC38C+80dZKOoA j4qXRasUr2GucIp9PWCoaiZDzWpf3spI1wT1TWS+Qr1C+GkunlZcZkNoe3u5eEOu xo50rZEI6R06wKkAiT1GAvRslbD/6fET69RcGGU+OHuAWKesCW/XxcAQtElzqhhG JXJ9gvw1iicK9ixPaEr3Qe6JNW7yzW/8amEAG+WzrmXLopiM4ULE6rLRRrw9Ob9i nE5srxfMO/tWctUCR+Y1O4TCpcTIw== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8DDA6E427A; Wed, 31 Oct 2018 14:29:59 -0400 (EDT) From: Thomas Monjalon To: Qi Zhang Cc: stable@dpdk.org, dev@dpdk.org, anatoly.burakov@intel.com, ferruh.yigit@intel.com, geoffrey.lv@gmail.com, ajit.khaparde@broadcom.com Date: Wed, 31 Oct 2018 19:30:05 +0100 Message-ID: <2510930.zaILCgKxQ4@xps> In-Reply-To: <20181030152720.3728-1-qi.z.zhang@intel.com> References: <20180903084005.29706-1-qi.z.zhang@intel.com> <20181030152720.3728-1-qi.z.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3] bus/pci: fix unexpected resource mapping override X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Oct 2018 18:30:02 -0000 Hi Qi, 30/10/2018 16:27, Qi Zhang: > When scanning an already plugged device, the virtual address > of mapped PCI resource in rte_pci_device will be overridden > with 0, that may cause driver does not work correctly. > The fix is not to update any rte_pci_device's field if the being > scanned device's driver is already probed. > > Bugzilla ID: 85 > Fixes: c752998b5e2e ("pci: introduce library and driver") > Cc: stable@dpdk.org > > Reported-by: Lv Geoffrey > Signed-off-by: Qi Zhang > --- > drivers/bus/pci/linux/pci.c | 35 ++++++++++++++++++++++++++++++----- > 1 file changed, 30 insertions(+), 5 deletions(-) When sending a new version, please use --in-reply-to, and add a changelog somewhere. Applied, thanks