From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 2BCAF1B01C for <dev@dpdk.org>; Wed, 17 Jan 2018 09:25:27 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6F51920E98; Wed, 17 Jan 2018 03:25:27 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 17 Jan 2018 03:25:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=5e5mC+VHo8df47kAtNMsSAaro/ 9DwnLqPg5PUYUY1ew=; b=PtTxXrwvojtfs67ulIwlaKoeyqxhhaqCCdj9dlVtik qzVJjn0anaZeJrq5EbNwBeUNGCTdW+EmAmsEEVhhr+g9v4fVWMJUqM2DjMSe+qm2 FcNHxrMCm6k5V5B8ceAYv4cJLtxQS7fvFzOHJ/a9zfCc9gBc/nPmd5wivlAMMMN6 w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=5e5mC+ VHo8df47kAtNMsSAaro/9DwnLqPg5PUYUY1ew=; b=arf2aiwNaacuPd0V5cGkVA CptS8y5X1hlsErmpROrDOvLF69vgYIXprMWgcEPKTRpGE1Qe4QzMHc9bfKPCpcBI v7Ov0rC7gRG9AFmof4fu7DuEJAcE5uxLQD2+AJMY1ooKvVdr6zyVyoAn0rfWPFEM f9h1DYsfuUO7n1mlqpXP8VowZj7I4PE4/r9gP2ghHIegWZo6AJzXH/SBWTKtNbvF o7xk5f1L/xSR+RR/aD5yDm+pco/kR+86MbE+DqrktMCvTENxNfM5X/0dpdkSZMLu yo3+Fw4rINvdb40PQzdmsII89HQ/MssTTxYZIzAV1JoYJYVd8JMynxR5dH7HP76Q == X-ME-Sender: <xms:dwhfWpP66p0OudTOP3ScbUqj0sPYRx42UnS2viwiFyTQ7S5lQD65uQ> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 192DB7E322; Wed, 17 Jan 2018 03:25:27 -0500 (EST) From: Thomas Monjalon <thomas@monjalon.net> To: Jia He <hejianet@gmail.com> Cc: dev@dpdk.org, Jerin Jacob <jerin.jacob@caviumnetworks.com>, Jianbo Liu <jianbo.liu@arm.com>, Jan Viktorin <viktorin@rehivetech.com>, Olivier Matz <olivier.matz@6wind.com>, konstantin.ananyev@intel.com, hemant.agrawal@nxp.com, Jia He <jia.he@hxt-semitech.com> Date: Wed, 17 Jan 2018 09:24:54 +0100 Message-ID: <2512442.13rg75T8JE@xps> In-Reply-To: <1516161831-28719-4-git-send-email-hejianet@gmail.com> References: <1516161831-28719-1-git-send-email-hejianet@gmail.com> <1516161831-28719-4-git-send-email-hejianet@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 3/3] ring: introduce new header file to support C11 memory model X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 17 Jan 2018 08:25:28 -0000 17/01/2018 05:03, Jia He: > To support C11 memory model barrier, 2 options are suggested by Jerin: > 1. use rte_smp_rmb > 2. use load_acquire/store_release(refer to [1]). > CONFIG_RTE_RING_USE_C11_MEM_MODEL is provided, and by default it is "n" > on any architectures so far. In previous patches, it was enabled for ARM. You decided to not enable it at all? > config/common_linuxapp | 2 + It should be defined in common_base, not common_linuxapp. > --- /dev/null > +++ b/lib/librte_ring/rte_ring_c11_mem.h > @@ -0,0 +1,193 @@ > +/*- > + * Copyright(c) 2017 Intel Corporation. All rights reserved. > + * All rights reserved. > + * > + * SPDX-License-Identifier: BSD-3-Clause > + */ It is not complying with the template. Please check the license/ directory. Why is it Intel Copyright? "All rights reserved" is probably not needed. > +/* > + * Derived from FreeBSD's bufring.h > + * > + ************************************************************************** > + * > + * Copyright (c) 2007-2009 Kip Macy kmacy@freebsd.org > + * All rights reserved. > + * > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted provided that the following conditions are met: > + * > + * 1. Redistributions of source code must retain the above copyright notice, > + * this list of conditions and the following disclaimer. > + * > + * 2. The name of Kip Macy nor the names of other > + * contributors may be used to endorse or promote products derived from > + * this software without specific prior written permission. > + * > + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" > + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE > + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE > + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE > + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR > + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF > + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS > + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN > + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) > + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE > + * POSSIBILITY OF SUCH DAMAGE. > + * > + ***************************************************************************/ This double license may be an issue. Hemant, comment?