From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E12DA42FB1; Tue, 1 Aug 2023 12:37:13 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D153640F16; Tue, 1 Aug 2023 12:37:13 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id 555C540A89 for ; Tue, 1 Aug 2023 12:37:12 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 91C1E32008C3; Tue, 1 Aug 2023 06:37:10 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 01 Aug 2023 06:37:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1690886230; x=1690972630; bh=V4x+k2ThqZdHUlgSHtPl5W0IkV5WkvapcTq /fkeUQcs=; b=W3GNYh/yIqidFeynMI9PZknhfXXxW/f6OMokDY3tEQa/voUEWI8 zfqMoDnBYvfmSvebQMPEOV/82/gmiLhEG5Oe6WzFgMjGFJn0/GiYuEIgAv6WBrn6 qYclMQQCnDml5v5VB2rMNGotbSJ+vnHXdOfFqCrlTnhjXMYJ73abzw0vSGN8OdAo MG/K+bWxx6i3m0sMGskVM20CWO0GGwnaSmJb2w7h91haESO9TkD8eFdqKi38kNlR qG96R5tHn30DyCLtXl8DE/d5u3MOs8+lnLBHOugCQxhHnAAuXuaQI65+6rWWj9LX cxFP8eVYwWRrGa5Tre6EDVK+6DBorAKIKcA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1690886230; x=1690972630; bh=V4x+k2ThqZdHUlgSHtPl5W0IkV5WkvapcTq /fkeUQcs=; b=xnHiT66u7O61pckL6Y92lRJsaY1ercT0j9MdYGXHJG4qOcOh5zC HhK1Eo1AvP52d3OjhoZA9788sCh109+eBRv2/QU57SIgwkjLPZqZ8qtwMxsZpeD/ QfFUlNO6NZvkvmKMR9h4+woeF5FSyzzYD87lz9wr52wtJekazGN5sb14Gzbt3Fiy 87588XeSaR/CJM8x4qnDI5qdv0mMSK6iJTzvxjrX7e94ZFuNnLy5jjB0g44eTmcU N+iJW2Du1h7+R0Z9GKFlgeXJuxGeFSuoXB3C1eaxLZHNp0Vf/DFbtLHHqDN43mgi Nk8y9408vXBdbzFt/HVQLa5NHhs6WNx2ByQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrjeeigddvkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepledtledtteekvedvuddtieduleevfeduudegteeludetlefhfeek feeuveelveeunecuffhomhgrihhnpehpmhgurdhnvghtnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdr nhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 1 Aug 2023 06:37:08 -0400 (EDT) From: Thomas Monjalon To: Patrick Robb , Bruce Richardson , alialnu@nvidia.com Cc: Tyler Retzlaff , dev@dpdk.org, Morten =?ISO-8859-1?Q?Br=F8rup?= , david.marchand@redhat.com, rasland@nvidia.com Subject: Re: [PATCH v3] build: update DPDK to use C11 standard Date: Tue, 01 Aug 2023 12:37:07 +0200 Message-ID: <2514064.TLnPLrj5Ze@thomas> In-Reply-To: References: <20230731103858.1491751-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 01/08/2023 12:19, Bruce Richardson: > On Mon, Jul 31, 2023 at 08:39:31PM -0400, Patrick Robb wrote: > > Hi Bruce, > > I see some failures for this series for our Ubuntu 20.04 containers. > > And, our DTS testbeds which are on ubuntu 20.04 are skipping running > > testsuites because they can't compile DPDK. So, that's why it has some > > missing results for a couple of the Intel NICs. For context, I'll paste > > below where the compile job terminates in one of our containerized > > compile test runs. The GCC in use here is version 9.4, so it meets the > > requirements as described in your patch as far as I can tell. I'll > > check it out more tomorrow to see whether it's an infra failure, like > > some missing dependencies. Please let me know if we expect to have no > > issues with 20.04 or if this is anticipated. > > Thanks! > > [1638/2730] Generating symbol file > > 'drivers/a715181@@rte_net_ixgbe@sha/librte_net_ixgbe.so.24.0.symbols'. > > [1639/2730] Compiling C object > > 'drivers/a715181@@tmp_rte_net_mlx4@sta/net_mlx4_mlx4.c.o'. > > FAILED: drivers/a715181@@tmp_rte_net_mlx4@sta/net_mlx4_mlx4.c.o > > ccache cc -Idrivers/a715181@@tmp_rte_net_mlx4@sta -Idrivers > > -I../drivers -Idrivers/net/mlx4 -I../drivers/net/mlx4 -Ilib/ethdev > > -I../lib/ethdev -I. -I../ -Iconfig -I../config -Ilib/eal/include > > -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include > > -Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/common > > -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs > > -Ilib/telemetry/../metrics -I../lib/telemetry/../metrics > > -Ilib/telemetry -I../lib/telemetry -Ilib/net -I../lib/net -Ilib/mbuf > > -I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring > > -Ilib/meter -I../lib/meter -Idrivers/bus/pci -I../drivers/bus/pci > > -I../drivers/bus/pci/linux -Ilib/pci -I../lib/pci -Idrivers/bus/vdev > > -I../drivers/bus/vdev -I/usr/include/libnl3 -fdiagnostics-color=always > > -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror > > -std=c11 -O3 -include rte_config.h -Wcast-qual -Wdeprecated -Wformat > > -Wformat-nonliteral -Wformat-security -Wmissing-declarations > > -Wmissing-prototypes -Wnested-externs -Wold-style-definition > > -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef > > -Wwrite-strings -Wno-address-of-packed-member -Wno-packed-not-aligned > > -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=native > > -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-truncation > > -std=c11 -Wno-strict-prototypes -D_BSD_SOURCE -D_DEFAULT_SOURCE > > -D_XOPEN_SOURCE=600 -UPEDANTIC -DRTE_LOG_DEFAULT_LOGTYPE=pmd.net.mlx4 > > -MD -MQ 'drivers/a715181@@tmp_rte_net_mlx4@sta/net_mlx4_mlx4.c.o' -MF > > 'drivers/a715181@@tmp_rte_net_mlx4@sta/net_mlx4_mlx4.c.o.d' -o > > 'drivers/a715181@@tmp_rte_net_mlx4@sta/net_mlx4_mlx4.c.o' -c > > ../drivers/net/mlx4/mlx4.c > > In file included from ../drivers/net/mlx4/mlx4_rxtx.h:27, > > from ../drivers/net/mlx4/mlx4.c:49: > > ../drivers/net/mlx4/mlx4_prm.h:111:8: error: redefinition of 'struct > > mlx4_wqe_lso_seg' > > 111 | struct mlx4_wqe_lso_seg { > > | ^~~~~~~~~~~~~~~~ > > In file included from ../drivers/net/mlx4/mlx4_glue.h:16, > > from ../drivers/net/mlx4/mlx4.c:46: > > /usr/include/infiniband/mlx4dv.h:410:8: note: originally defined here > > 410 | struct mlx4_wqe_lso_seg { > > | ^~~~~~~~~~~~~~~~ > > ninja: build stopped: subcommand failed. > > Hi again, > > I've attempted to reproduce this on my Ubuntu 20.04 VM and failed, > everything seems to build ok. > > Looking through the logs, though, there does appear to be a difference in > the configurations in the two cases. I suspect my Ubuntu has an updated > verbs package compared to the image you are using. In the log of the failed > build, I see: > > Checking whether type "struct mlx4_wqe_lso_seg" has member "mss_hdr_size" with dependencies libmlx4, libibverbs: NO > Configuring mlx4_autoconf.h using configuration > > While building in my VM, I have: > > Checking whether type "struct mlx4_wqe_lso_seg" has member "mss_hdr_size" with dependencies libmlx4, libibverbs: YES (cached) > Configuring mlx4_autoconf.h using configuration > > So my verbs mlx4 header has got a different set of definitions to those in > the CI machine. My Ubuntu reports as 20.04.6 with libibverbs-dev package > version "28.0-1ubuntu1" > > Can the CI image be updated to latest 20.04 packages? I'm surprised there is such issue. The autoconf mechanism should manage any old package. Ali, do you have an idea what happens?