From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 440611B6F0 for ; Tue, 24 Oct 2017 01:23:44 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id DE18E20C9B; Mon, 23 Oct 2017 19:23:43 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Mon, 23 Oct 2017 19:23:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=I2ngwDOEJA9pJ5NdIrGRp4xDBz cKxcAMwa01tSQFACU=; b=O1ArpjmzgkE4KS7DVn+LDjfX4jKdeqTjgyeEh23FHF +sLxA/nUUv9Lrdv/KV0lau8UNVeIxivFnqQft79jXALmpeQ+eghsgBlPbMP9GWsv P0w5Rx5VdP70dNHy3jOTOhTBVgQiiu/oLN0y3n4lvgN7PMV5flC9Y0IdOwy94c9e 4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=I2ngwD OEJA9pJ5NdIrGRp4xDBzcKxcAMwa01tSQFACU=; b=V3PnBdwg1SrMsvufIOBEa1 B5hr3UrD8u5hIWnBQKBtloc0YPH3IfVYlSFVHPLnH5oIqb7IhOV0eOG+FusXAf7Y s5qxMI+eJXjOn0ASQAnPt0E33F4Zxd0CadZH9OR1WwRzhH1sdyrcz7vREIuhAU0L txRPmNiCkZh9fkl2nTWNAW9QVhtNSxSVX3kgQyAesJrhYPkvQvOOo8ZXCSqW7pMV s2rap/NpZ1fxxhl6mvkBv08so9yjj2tBiPwT9nPWDtJFqdnQ2uIqhBj8ItAgytHw 3pz0o8jWkWNJ81TJLf17Z6jGKdwjwkXMpaZi5pZV5VvCSl8thPpwITqgn1IeeeaA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8D2927F91E; Mon, 23 Oct 2017 19:23:43 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org Date: Tue, 24 Oct 2017 01:23:42 +0200 Message-ID: <25159799.6mpjox5pv3@xps> In-Reply-To: <20171019164559.GA20056@bricha3-MOBL3.ger.corp.intel.com> References: <20171019163629.28618-1-bruce.richardson@intel.com> <20171019164559.GA20056@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 0/5] Merge Linux and BSD EAL map files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2017 23:23:44 -0000 19/10/2017 18:45, Bruce Richardson: > On Thu, Oct 19, 2017 at 05:36:24PM +0100, Bruce Richardson wrote: > > Both Linux and BSD EALs should provide exactly the same set of functions > > to the user, even if in some cases the function is a stub returning > > ENOTSUP. Because of this we should only need a single version.map file for > > all of EAL - not one each for Linux and FreeBSD. > > > > Unfortunately, there was some inconsistencies in the two EALs, specifically > > 4 functions were missing from the BSD interrupts files. As part of adding > > the needed stubs, I also discovered that there was nothing terribly > > Linux-specific about the Linux-specific rte_interrupts.h file, which > > appeared to contain a superset of the BSD contents. Therefore, this file > > could be made common also. > > > > The net result is that there are now zero BSD-specific EAL headers, and > > only a single Linux one for KNI. The version.map file is now moved to a > > common location also, just inside rte_eal directory. > > > > [While an argument could be made to put it in common, this location works > > best for integration with the existing meson build-sysetm work. It also > > allows the same version file to be used for non-posix-like environments > > which may not use the "common" folder as much] > > > > > > Bruce Richardson (5): > > eal/bsdapp: align interrupt include file with Linux version > > eal/bsdapp: fix missing interrupt stub functions > > eal: merge bsdapp and linuxapp interrupt headers > > eal: mark internal interrupts file as such to doxygen > > eal: use a single version map file > > > > Compilation tested for both static and shared builds on FreeBSD 11.0 and > Fedora 26. Applied, thanks