Re: [dpdk-dev] [PATCH v8 0/7] link bonding

[Thomas Monjalon <thomas.monjalon@6wind.com>]

Declan,
There are still some missing spaces:

WARNING:MISSING_SPACE: break quoted strings at a space character
#2002: FILE: lib/librte_pmd_bond/rte_eth_bond_pmd.c:1406:
+                                       "Invalid lsc polling interval value specified for bonded"
+                                       "device %s\n", name);
WARNING:MISSING_SPACE: break quoted strings at a space character
#2016: FILE: lib/librte_pmd_bond/rte_eth_bond_pmd.c:1420:
+                               "LSC polling interval can be specified only once for bonded"
+                               "device %s\n", name);
WARNING:MISSING_SPACE: break quoted strings at a space character
#2040: FILE: lib/librte_pmd_bond/rte_eth_bond_pmd.c:1444:
+                                       "Failed to set link up propagation delay (%u ms) on bonded"
+                                       "device %s\n", link_up_delay_ms, name);
WARNING:MISSING_SPACE: break quoted strings at a space character
#2061: FILE: lib/librte_pmd_bond/rte_eth_bond_pmd.c:1465:
+                                       "Invalid link down propagation delay value specified for"
+                                       "bonded device %s\n", name);
WARNING:MISSING_SPACE: break quoted strings at a space character
#3674: FILE: app/test/test_link_bonding.c:3672:
+                               "slave port (%d) mac address not set to that of new primary"
+                               "port", test_params->slave_port_ids[i]);

I'm fixing it for you because I'm losing confidence all bonding patches will
be ready on time.
Some i40e patches won't be applied today because I spend more time on bonding.
For next release cycle, I'll have to be more strict.

Please Declan, could you be the bonding maintainer and ensure other bonding
patches (mode 4, mode 5, fixes) to come are ready and nothing will delay
their integration?
Thanks
-- 
Thomas

2014-11-24 16:33, Declan Doherty:
> v8:
> - Missing typo fix
> - Missing whitespace
> 
> v7:
> - Fixes for checkpatch issues and typo fixes
> - Removed patch "test app: adding support for generating variable sized" as this
>   was already committed in commit aca4360340f169dcc11b1a9be955b44de8b9f6eb

> Declan Doherty (7):
>   bond: link status interrupt support
>   bond: removing switch statement from rx burst method
>   bond: fix naming inconsistency in tx_burst_round_robin
>   bond: free mbufs if transmission fails in bonding tx_burst functions
>   testpmd: adding parameter to reconfig method to set socket_id when
>     adding new port to portlist
>   bond: lsc polling support
>   bond: unit test test macro refactor