From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 47E45A0C47; Wed, 27 Oct 2021 17:00:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 35575411C3; Wed, 27 Oct 2021 17:00:58 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 804C6411B8 for ; Wed, 27 Oct 2021 17:00:56 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 22ED05C0245; Wed, 27 Oct 2021 11:00:56 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 27 Oct 2021 11:00:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= cvDU1TF4isAxslwAdR4bQ+2KF65exWupoE13sqN2Oas=; b=ZyN9QB+9y377dIEw krkfS/a8BmZrNlchiT9PIqkCMTjd1up7qQ5CWry44d/YRqiKa4Hi6oak3kfWhf4v bR2umBt17Ti/i8vL3tAg/HLO46wHmLgIVcUCvRIlPLrkwI7hqtGDwFXKabMUuTvu F9p3eKIzoFGvz3dB0nA81Z6TFqM35Fs0jWJWFoFTU3abt/NWk9tDTB4M8ZC4m6rQ 61ljXgt1JRNhGDIvpom+AsOJ1JQ/tRTslb4zTpe5FuSnOgVl9FNH8T4oBJmPV73X qR55x3MtuYQoY9JiGvGR9XnS9WDJSu+cK2BF2eu0ZqE6A8Md/EkKT3LKdgS6ar+4 4My8aw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=cvDU1TF4isAxslwAdR4bQ+2KF65exWupoE13sqN2O as=; b=LiPIlB30XhU7/sNZI5oMG7jVbpHUrUhezppE+08L7wv4ODyANeoyrQHsc MTF9A+8JVuJ69CEWGTuLS2r9/pBWMS6nBMwiKPV38Giwbc8VN0qeLgp1Vam1Uki+ kTX694IIMAsslusS+JqlXcZO1a90V1+O1Z8Wyf8MiEGC+dhBAwrArieWsP80/TIx /jMzxMbBM1qHn7TcZlHrIxLtfShrdVoCMOKcu8bHE6HThy5/5HM9GoknAWzxwRed Dr/sxT8JRT/l/J/hQ3AHh2qN+KGZDk9kqu5KVdT3EwOdQ+6rCd3ryemYA5qmjY3Z VmzcV2G9mBUqAp4GJHiBVAnTa97Tw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvdegtddgkedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 27 Oct 2021 11:00:55 -0400 (EDT) From: Thomas Monjalon To: Kevin Laatz Cc: dev@dpdk.org, Bruce Richardson Date: Wed, 27 Oct 2021 17:00:54 +0200 Message-ID: <2517999.mVafrqInaF@thomas> In-Reply-To: References: <20211026142045.2996949-1-kevin.laatz@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] dma/idxd: fix truncated error code in status check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 27/10/2021 15:08, Bruce Richardson: > On Tue, Oct 26, 2021 at 02:20:45PM +0000, Kevin Laatz wrote: > > When checking if the DMA device is active, the result of the operand will > > always be zero since the err_code is truncated to 8 bits which makes > > checking the 31st bit impossible. > > > > This is fixed by changing the type of err_code to uint32_t so that it is > > not truncated. > > > > Coverity issue: 373657 > > Fixes: 9449330a8458 ("dma/idxd: create dmadev instances on PCI probe") > > > > Signed-off-by: Kevin Laatz > > --- > Acked-by: Bruce Richardson Applied, thanks.