DPDK patches and discussions
 help / color / Atom feed
* [dpdk-dev] [PATCH] config: disable all kmods by default from v20.02
@ 2019-12-12 13:13 jerinj
  2020-01-16 13:11 ` Jerin Jacob
                   ` (2 more replies)
  0 siblings, 3 replies; 17+ messages in thread
From: jerinj @ 2019-12-12 13:13 UTC (permalink / raw)
  To: dev, Thomas Monjalon; +Cc: techboard, Jerin Jacob

From: Jerin Jacob <jerinj@marvell.com>

Based on the techboard meeting held on 2019-11-06,
It's been decided to disable all kmods by default from v20.02.

http://mails.dpdk.org/archives/dev/2019-November/151763.html

Signed-off-by: Jerin Jacob <jerinj@marvell.com>
---
 config/common_linux | 2 --
 1 file changed, 2 deletions(-)

diff --git a/config/common_linux b/config/common_linux
index c5cf3d662..583efadc7 100644
--- a/config/common_linux
+++ b/config/common_linux
@@ -8,9 +8,7 @@ CONFIG_RTE_EXEC_ENV_LINUX=y
 CONFIG_RTE_EXEC_ENV_LINUXAPP=y
 
 CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y
-CONFIG_RTE_EAL_IGB_UIO=y
 CONFIG_RTE_EAL_VFIO=y
-CONFIG_RTE_KNI_KMOD=y
 CONFIG_RTE_LIBRTE_KNI=y
 CONFIG_RTE_LIBRTE_PMD_KNI=y
 CONFIG_RTE_LIBRTE_VHOST=y
-- 
2.24.0


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [dpdk-dev] [PATCH] config: disable all kmods by default from v20.02
  2019-12-12 13:13 [dpdk-dev] [PATCH] config: disable all kmods by default from v20.02 jerinj
@ 2020-01-16 13:11 ` Jerin Jacob
  2020-01-16 18:33   ` [dpdk-dev] [dpdk-techboard] " Maxime Coquelin
  2020-01-17 19:14 ` [dpdk-dev] [PATCH v2] " jerinj
  2020-01-22  6:34 ` [dpdk-dev] [PATCH] " Stephen Hemminger
  2 siblings, 1 reply; 17+ messages in thread
From: Jerin Jacob @ 2020-01-16 13:11 UTC (permalink / raw)
  To: Jerin Jacob; +Cc: dpdk-dev, Thomas Monjalon, techboard

Ping.

On Thu, Dec 12, 2019 at 6:42 PM <jerinj@marvell.com> wrote:
>
> From: Jerin Jacob <jerinj@marvell.com>
>
> Based on the techboard meeting held on 2019-11-06,
> It's been decided to disable all kmods by default from v20.02.
>
> http://mails.dpdk.org/archives/dev/2019-November/151763.html
>
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> ---
>  config/common_linux | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/config/common_linux b/config/common_linux
> index c5cf3d662..583efadc7 100644
> --- a/config/common_linux
> +++ b/config/common_linux
> @@ -8,9 +8,7 @@ CONFIG_RTE_EXEC_ENV_LINUX=y
>  CONFIG_RTE_EXEC_ENV_LINUXAPP=y
>
>  CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y
> -CONFIG_RTE_EAL_IGB_UIO=y
>  CONFIG_RTE_EAL_VFIO=y
> -CONFIG_RTE_KNI_KMOD=y
>  CONFIG_RTE_LIBRTE_KNI=y
>  CONFIG_RTE_LIBRTE_PMD_KNI=y
>  CONFIG_RTE_LIBRTE_VHOST=y
> --
> 2.24.0
>

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [dpdk-dev] [dpdk-techboard] [PATCH] config: disable all kmods by default from v20.02
  2020-01-16 13:11 ` Jerin Jacob
@ 2020-01-16 18:33   ` " Maxime Coquelin
  2020-01-16 18:43     ` Jerin Jacob
  0 siblings, 1 reply; 17+ messages in thread
From: Maxime Coquelin @ 2020-01-16 18:33 UTC (permalink / raw)
  To: Jerin Jacob, Jerin Jacob; +Cc: dpdk-dev, Thomas Monjalon, techboard



On 1/16/20 2:11 PM, Jerin Jacob wrote:
> Ping.
> 
> On Thu, Dec 12, 2019 at 6:42 PM <jerinj@marvell.com> wrote:
>>
>> From: Jerin Jacob <jerinj@marvell.com>
>>
>> Based on the techboard meeting held on 2019-11-06,
>> It's been decided to disable all kmods by default from v20.02.
>>
>> http://mails.dpdk.org/archives/dev/2019-November/151763.html
>>
>> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
>> ---
>>  config/common_linux | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/config/common_linux b/config/common_linux
>> index c5cf3d662..583efadc7 100644
>> --- a/config/common_linux
>> +++ b/config/common_linux
>> @@ -8,9 +8,7 @@ CONFIG_RTE_EXEC_ENV_LINUX=y
>>  CONFIG_RTE_EXEC_ENV_LINUXAPP=y
>>
>>  CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y
>> -CONFIG_RTE_EAL_IGB_UIO=y
>>  CONFIG_RTE_EAL_VFIO=y
>> -CONFIG_RTE_KNI_KMOD=y
>>  CONFIG_RTE_LIBRTE_KNI=y
>>  CONFIG_RTE_LIBRTE_PMD_KNI=y
>>  CONFIG_RTE_LIBRTE_VHOST=y
>> --
>> 2.24.0
>>
> 

Looks good for make build system, but what about Meson?
as per meson_options.txt, isn't it enabled by default?
$ grep -rn enable_kmods meson_options.txt
7:option('enable_kmods', type: 'boolean', value: true,

Thanks,
Maxime


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [dpdk-dev] [dpdk-techboard] [PATCH] config: disable all kmods by default from v20.02
  2020-01-16 18:33   ` [dpdk-dev] [dpdk-techboard] " Maxime Coquelin
@ 2020-01-16 18:43     ` Jerin Jacob
  2020-01-16 22:38       ` Honnappa Nagarahalli
  2020-01-17  8:29       ` Maxime Coquelin
  0 siblings, 2 replies; 17+ messages in thread
From: Jerin Jacob @ 2020-01-16 18:43 UTC (permalink / raw)
  To: Maxime Coquelin
  Cc: Jerin Jacob, dpdk-dev, Thomas Monjalon, techboard, Richardson, Bruce

On Fri, Jan 17, 2020 at 12:04 AM Maxime Coquelin
<maxime.coquelin@redhat.com> wrote:
>
>
>
> On 1/16/20 2:11 PM, Jerin Jacob wrote:
> > Ping.
> >
> > On Thu, Dec 12, 2019 at 6:42 PM <jerinj@marvell.com> wrote:
> >>
> >> From: Jerin Jacob <jerinj@marvell.com>
> >>
> >> Based on the techboard meeting held on 2019-11-06,
> >> It's been decided to disable all kmods by default from v20.02.
> >>
> >> http://mails.dpdk.org/archives/dev/2019-November/151763.html
> >>
> >> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> >> ---
> >>  config/common_linux | 2 --
> >>  1 file changed, 2 deletions(-)
> >>
> >> diff --git a/config/common_linux b/config/common_linux
> >> index c5cf3d662..583efadc7 100644
> >> --- a/config/common_linux
> >> +++ b/config/common_linux
> >> @@ -8,9 +8,7 @@ CONFIG_RTE_EXEC_ENV_LINUX=y
> >>  CONFIG_RTE_EXEC_ENV_LINUXAPP=y
> >>
> >>  CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y
> >> -CONFIG_RTE_EAL_IGB_UIO=y
> >>  CONFIG_RTE_EAL_VFIO=y
> >> -CONFIG_RTE_KNI_KMOD=y
> >>  CONFIG_RTE_LIBRTE_KNI=y
> >>  CONFIG_RTE_LIBRTE_PMD_KNI=y
> >>  CONFIG_RTE_LIBRTE_VHOST=y
> >> --
> >> 2.24.0
> >>
> >
>
> Looks good for make build system, but what about Meson?
> as per meson_options.txt, isn't it enabled by default?
> $ grep -rn enable_kmods meson_options.txt
> 7:option('enable_kmods', type: 'boolean', value: true,

+ Bruce,

Since meson autodetect the presence of Linux kernel dependency for the
kmod build,
I thought of keeping as it is as there is no harm. I am fine with
either way, let me the
know the feedback, I will send the v2 based on the comment.



>
> Thanks,
> Maxime
>

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [dpdk-dev] [dpdk-techboard] [PATCH] config: disable all kmods by default from v20.02
  2020-01-16 18:43     ` Jerin Jacob
@ 2020-01-16 22:38       ` Honnappa Nagarahalli
  2020-01-17  4:07         ` Jerin Jacob
  2020-01-17  8:29       ` Maxime Coquelin
  1 sibling, 1 reply; 17+ messages in thread
From: Honnappa Nagarahalli @ 2020-01-16 22:38 UTC (permalink / raw)
  To: Jerin Jacob, Maxime Coquelin
  Cc: jerinj, dpdk-dev, thomas, techboard, Richardson, Bruce, nd,
	Honnappa Nagarahalli, nd

<snip>

> >
> > On 1/16/20 2:11 PM, Jerin Jacob wrote:
> > > Ping.
> > >
> > > On Thu, Dec 12, 2019 at 6:42 PM <jerinj@marvell.com> wrote:
> > >>
> > >> From: Jerin Jacob <jerinj@marvell.com>
> > >>
> > >> Based on the techboard meeting held on 2019-11-06, It's been
> > >> decided to disable all kmods by default from v20.02.
> > >>
> > >> http://mails.dpdk.org/archives/dev/2019-November/151763.html
> > >>
> > >> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> > >> ---
> > >>  config/common_linux | 2 --
> > >>  1 file changed, 2 deletions(-)
> > >>
> > >> diff --git a/config/common_linux b/config/common_linux index
> > >> c5cf3d662..583efadc7 100644
> > >> --- a/config/common_linux
> > >> +++ b/config/common_linux
> > >> @@ -8,9 +8,7 @@ CONFIG_RTE_EXEC_ENV_LINUX=y
> > >> CONFIG_RTE_EXEC_ENV_LINUXAPP=y
> > >>
> > >>  CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y
> > >> -CONFIG_RTE_EAL_IGB_UIO=y
> > >>  CONFIG_RTE_EAL_VFIO=y
> > >> -CONFIG_RTE_KNI_KMOD=y
Suggest to keep the lines, but set them to 'n'. It will be easier to enable.
Does this require update to release notes?

> > >>  CONFIG_RTE_LIBRTE_KNI=y
> > >>  CONFIG_RTE_LIBRTE_PMD_KNI=y
> > >>  CONFIG_RTE_LIBRTE_VHOST=y
> > >> --
> > >> 2.24.0
> > >>
> > >
> >
> > Looks good for make build system, but what about Meson?
> > as per meson_options.txt, isn't it enabled by default?
> > $ grep -rn enable_kmods meson_options.txt 7:option('enable_kmods',
> > type: 'boolean', value: true,
> 
> + Bruce,
> 
> Since meson autodetect the presence of Linux kernel dependency for the kmod
> build, I thought of keeping as it is as there is no harm. I am fine with either way,
> let me the know the feedback, I will send the v2 based on the comment.
> 
> 
> 
> >
> > Thanks,
> > Maxime
> >

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [dpdk-dev] [dpdk-techboard] [PATCH] config: disable all kmods by default from v20.02
  2020-01-16 22:38       ` Honnappa Nagarahalli
@ 2020-01-17  4:07         ` Jerin Jacob
  2020-01-17 15:48           ` Honnappa Nagarahalli
  0 siblings, 1 reply; 17+ messages in thread
From: Jerin Jacob @ 2020-01-17  4:07 UTC (permalink / raw)
  To: Honnappa Nagarahalli
  Cc: Maxime Coquelin, jerinj, dpdk-dev, thomas, techboard, Richardson,
	Bruce, nd

On Fri, Jan 17, 2020 at 4:08 AM Honnappa Nagarahalli
<Honnappa.Nagarahalli@arm.com> wrote:
>
> <snip>
>
> > >
> > > On 1/16/20 2:11 PM, Jerin Jacob wrote:
> > > > Ping.
> > > >
> > > > On Thu, Dec 12, 2019 at 6:42 PM <jerinj@marvell.com> wrote:
> > > >>
> > > >> From: Jerin Jacob <jerinj@marvell.com>
> > > >>
> > > >> Based on the techboard meeting held on 2019-11-06, It's been
> > > >> decided to disable all kmods by default from v20.02.
> > > >>
> > > >> http://mails.dpdk.org/archives/dev/2019-November/151763.html
> > > >>
> > > >> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> > > >> ---
> > > >>  config/common_linux | 2 --
> > > >>  1 file changed, 2 deletions(-)
> > > >>
> > > >> diff --git a/config/common_linux b/config/common_linux index
> > > >> c5cf3d662..583efadc7 100644
> > > >> --- a/config/common_linux
> > > >> +++ b/config/common_linux
> > > >> @@ -8,9 +8,7 @@ CONFIG_RTE_EXEC_ENV_LINUX=y
> > > >> CONFIG_RTE_EXEC_ENV_LINUXAPP=y
> > > >>
> > > >>  CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y
> > > >> -CONFIG_RTE_EAL_IGB_UIO=y
> > > >>  CONFIG_RTE_EAL_VFIO=y
> > > >> -CONFIG_RTE_KNI_KMOD=y
> Suggest to keep the lines, but set them to 'n'. It will be easier to enable.

In config/common_base it is set as =n. it can be enabled there just
like other config.
I just did this way to have symmetry with other configs.
Thoughts?


> Does this require update to release notes?

I will send the next version with updating the release notes if there
is no objection.

>
> > > >>  CONFIG_RTE_LIBRTE_KNI=y
> > > >>  CONFIG_RTE_LIBRTE_PMD_KNI=y
> > > >>  CONFIG_RTE_LIBRTE_VHOST=y
> > > >> --
> > > >> 2.24.0
> > > >>
> > > >
> > >
> > > Looks good for make build system, but what about Meson?
> > > as per meson_options.txt, isn't it enabled by default?
> > > $ grep -rn enable_kmods meson_options.txt 7:option('enable_kmods',
> > > type: 'boolean', value: true,
> >
> > + Bruce,
> >
> > Since meson autodetect the presence of Linux kernel dependency for the kmod
> > build, I thought of keeping as it is as there is no harm. I am fine with either way,
> > let me the know the feedback, I will send the v2 based on the comment.
> >
> >
> >
> > >
> > > Thanks,
> > > Maxime
> > >

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [dpdk-dev] [dpdk-techboard] [PATCH] config: disable all kmods by default from v20.02
  2020-01-16 18:43     ` Jerin Jacob
  2020-01-16 22:38       ` Honnappa Nagarahalli
@ 2020-01-17  8:29       ` Maxime Coquelin
  2020-01-17  9:19         ` Kevin Traynor
  2020-01-17  9:55         ` Jerin Jacob
  1 sibling, 2 replies; 17+ messages in thread
From: Maxime Coquelin @ 2020-01-17  8:29 UTC (permalink / raw)
  To: Jerin Jacob
  Cc: Jerin Jacob, dpdk-dev, Thomas Monjalon, techboard, Richardson, Bruce



On 1/16/20 7:43 PM, Jerin Jacob wrote:
> On Fri, Jan 17, 2020 at 12:04 AM Maxime Coquelin
> <maxime.coquelin@redhat.com> wrote:
>>
>>
>>
>> On 1/16/20 2:11 PM, Jerin Jacob wrote:
>>> Ping.
>>>
>>> On Thu, Dec 12, 2019 at 6:42 PM <jerinj@marvell.com> wrote:
>>>>
>>>> From: Jerin Jacob <jerinj@marvell.com>
>>>>
>>>> Based on the techboard meeting held on 2019-11-06,
>>>> It's been decided to disable all kmods by default from v20.02.
>>>>
>>>> http://mails.dpdk.org/archives/dev/2019-November/151763.html
>>>>
>>>> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
>>>> ---
>>>>  config/common_linux | 2 --
>>>>  1 file changed, 2 deletions(-)
>>>>
>>>> diff --git a/config/common_linux b/config/common_linux
>>>> index c5cf3d662..583efadc7 100644
>>>> --- a/config/common_linux
>>>> +++ b/config/common_linux
>>>> @@ -8,9 +8,7 @@ CONFIG_RTE_EXEC_ENV_LINUX=y
>>>>  CONFIG_RTE_EXEC_ENV_LINUXAPP=y
>>>>
>>>>  CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y
>>>> -CONFIG_RTE_EAL_IGB_UIO=y
>>>>  CONFIG_RTE_EAL_VFIO=y
>>>> -CONFIG_RTE_KNI_KMOD=y
>>>>  CONFIG_RTE_LIBRTE_KNI=y
>>>>  CONFIG_RTE_LIBRTE_PMD_KNI=y
>>>>  CONFIG_RTE_LIBRTE_VHOST=y
>>>> --
>>>> 2.24.0
>>>>
>>>
>>
>> Looks good for make build system, but what about Meson?
>> as per meson_options.txt, isn't it enabled by default?
>> $ grep -rn enable_kmods meson_options.txt
>> 7:option('enable_kmods', type: 'boolean', value: true,
> 
> + Bruce,
> 
> Since meson autodetect the presence of Linux kernel dependency for the
> kmod build,
> I thought of keeping as it is as there is no harm. I am fine with
> either way, let me the
> know the feedback, I will send the v2 based on the comment.

Actually, it would defeat the main reason I pushed for the kmods to be
disabled by default. Indeed, even if the kernel dependencies are
installed, build can break if internal kernel API changes, e.g.:

commit c128a4e6317d49362e2158edc29887c844067c65
Author: David Zeng <zengxhsh@cn.ibm.com>
Date:   Sat Dec 22 00:27:33 2018 +0800

    kni: fix build on RHEL8 for arm and Power9

    [ upstream commit 3d5501d568aacbcf71832691278f5656d3a9b649 ]

    Signed-off-by: David Zeng <zengxhsh@cn.ibm.com>
    Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [dpdk-dev] [dpdk-techboard] [PATCH] config: disable all kmods by default from v20.02
  2020-01-17  8:29       ` Maxime Coquelin
@ 2020-01-17  9:19         ` Kevin Traynor
  2020-01-17  9:55         ` Jerin Jacob
  1 sibling, 0 replies; 17+ messages in thread
From: Kevin Traynor @ 2020-01-17  9:19 UTC (permalink / raw)
  To: Maxime Coquelin, Jerin Jacob
  Cc: Jerin Jacob, dpdk-dev, Thomas Monjalon, techboard, Richardson, Bruce

On 17/01/2020 08:29, Maxime Coquelin wrote:
> 
> 
> On 1/16/20 7:43 PM, Jerin Jacob wrote:
>> On Fri, Jan 17, 2020 at 12:04 AM Maxime Coquelin
>> <maxime.coquelin@redhat.com> wrote:
>>>
>>>
>>>
>>> On 1/16/20 2:11 PM, Jerin Jacob wrote:
>>>> Ping.
>>>>
>>>> On Thu, Dec 12, 2019 at 6:42 PM <jerinj@marvell.com> wrote:
>>>>>
>>>>> From: Jerin Jacob <jerinj@marvell.com>
>>>>>
>>>>> Based on the techboard meeting held on 2019-11-06,
>>>>> It's been decided to disable all kmods by default from v20.02.
>>>>>
>>>>> http://mails.dpdk.org/archives/dev/2019-November/151763.html
>>>>>
>>>>> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
>>>>> ---
>>>>>  config/common_linux | 2 --
>>>>>  1 file changed, 2 deletions(-)
>>>>>
>>>>> diff --git a/config/common_linux b/config/common_linux
>>>>> index c5cf3d662..583efadc7 100644
>>>>> --- a/config/common_linux
>>>>> +++ b/config/common_linux
>>>>> @@ -8,9 +8,7 @@ CONFIG_RTE_EXEC_ENV_LINUX=y
>>>>>  CONFIG_RTE_EXEC_ENV_LINUXAPP=y
>>>>>
>>>>>  CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y
>>>>> -CONFIG_RTE_EAL_IGB_UIO=y
>>>>>  CONFIG_RTE_EAL_VFIO=y
>>>>> -CONFIG_RTE_KNI_KMOD=y
>>>>>  CONFIG_RTE_LIBRTE_KNI=y
>>>>>  CONFIG_RTE_LIBRTE_PMD_KNI=y
>>>>>  CONFIG_RTE_LIBRTE_VHOST=y
>>>>> --
>>>>> 2.24.0
>>>>>
>>>>
>>>
>>> Looks good for make build system, but what about Meson?
>>> as per meson_options.txt, isn't it enabled by default?
>>> $ grep -rn enable_kmods meson_options.txt
>>> 7:option('enable_kmods', type: 'boolean', value: true,
>>
>> + Bruce,
>>
>> Since meson autodetect the presence of Linux kernel dependency for the
>> kmod build,
>> I thought of keeping as it is as there is no harm. I am fine with
>> either way, let me the
>> know the feedback, I will send the v2 based on the comment.
> 
> Actually, it would defeat the main reason I pushed for the kmods to be
> disabled by default. Indeed, even if the kernel dependencies are
> installed, build can break if internal kernel API changes, e.g.:
> 
> commit c128a4e6317d49362e2158edc29887c844067c65
> Author: David Zeng <zengxhsh@cn.ibm.com>
> Date:   Sat Dec 22 00:27:33 2018 +0800
> 
>     kni: fix build on RHEL8 for arm and Power9
> 
>     [ upstream commit 3d5501d568aacbcf71832691278f5656d3a9b649 ]
> 
>     Signed-off-by: David Zeng <zengxhsh@cn.ibm.com>
>     Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 

That's a good point. We take these types of patches into stable, but
there would be a few months delay between a new kernel causing breakage
and the time when stable releases containing the fix are released.
Disabling would at least avoid non-kmod interested user being impacted
by default.


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [dpdk-dev] [dpdk-techboard] [PATCH] config: disable all kmods by default from v20.02
  2020-01-17  8:29       ` Maxime Coquelin
  2020-01-17  9:19         ` Kevin Traynor
@ 2020-01-17  9:55         ` Jerin Jacob
  1 sibling, 0 replies; 17+ messages in thread
From: Jerin Jacob @ 2020-01-17  9:55 UTC (permalink / raw)
  To: Maxime Coquelin
  Cc: Jerin Jacob, dpdk-dev, Thomas Monjalon, techboard, Richardson, Bruce

On Fri, Jan 17, 2020 at 1:59 PM Maxime Coquelin
<maxime.coquelin@redhat.com> wrote:
>
>
>
> On 1/16/20 7:43 PM, Jerin Jacob wrote:
> > On Fri, Jan 17, 2020 at 12:04 AM Maxime Coquelin
> > <maxime.coquelin@redhat.com> wrote:
> >>
> >>
> >>
> >> On 1/16/20 2:11 PM, Jerin Jacob wrote:
> >>> Ping.
> >>>
> >>> On Thu, Dec 12, 2019 at 6:42 PM <jerinj@marvell.com> wrote:
> >>>>
> >>>> From: Jerin Jacob <jerinj@marvell.com>
> >>>>
> >>>> Based on the techboard meeting held on 2019-11-06,
> >>>> It's been decided to disable all kmods by default from v20.02.
> >>>>
> >>>> http://mails.dpdk.org/archives/dev/2019-November/151763.html
> >>>>
> >>>> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> >>>> ---
> >>>>  config/common_linux | 2 --
> >>>>  1 file changed, 2 deletions(-)
> >>>>
> >>>> diff --git a/config/common_linux b/config/common_linux
> >>>> index c5cf3d662..583efadc7 100644
> >>>> --- a/config/common_linux
> >>>> +++ b/config/common_linux
> >>>> @@ -8,9 +8,7 @@ CONFIG_RTE_EXEC_ENV_LINUX=y
> >>>>  CONFIG_RTE_EXEC_ENV_LINUXAPP=y
> >>>>
> >>>>  CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y
> >>>> -CONFIG_RTE_EAL_IGB_UIO=y
> >>>>  CONFIG_RTE_EAL_VFIO=y
> >>>> -CONFIG_RTE_KNI_KMOD=y
> >>>>  CONFIG_RTE_LIBRTE_KNI=y
> >>>>  CONFIG_RTE_LIBRTE_PMD_KNI=y
> >>>>  CONFIG_RTE_LIBRTE_VHOST=y
> >>>> --
> >>>> 2.24.0
> >>>>
> >>>
> >>
> >> Looks good for make build system, but what about Meson?
> >> as per meson_options.txt, isn't it enabled by default?
> >> $ grep -rn enable_kmods meson_options.txt
> >> 7:option('enable_kmods', type: 'boolean', value: true,
> >
> > + Bruce,
> >
> > Since meson autodetect the presence of Linux kernel dependency for the
> > kmod build,
> > I thought of keeping as it is as there is no harm. I am fine with
> > either way, let me the
> > know the feedback, I will send the v2 based on the comment.
>
> Actually, it would defeat the main reason I pushed for the kmods to be
> disabled by default. Indeed, even if the kernel dependencies are
> installed, build can break if internal kernel API changes, e.g.:

Agree. I will send the next version with disabling kmod in meson by default.


> commit c128a4e6317d49362e2158edc29887c844067c65
> Author: David Zeng <zengxhsh@cn.ibm.com>
> Date:   Sat Dec 22 00:27:33 2018 +0800
>
>     kni: fix build on RHEL8 for arm and Power9
>
>     [ upstream commit 3d5501d568aacbcf71832691278f5656d3a9b649 ]
>
>     Signed-off-by: David Zeng <zengxhsh@cn.ibm.com>
>     Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
>

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [dpdk-dev] [dpdk-techboard] [PATCH] config: disable all kmods by default from v20.02
  2020-01-17  4:07         ` Jerin Jacob
@ 2020-01-17 15:48           ` Honnappa Nagarahalli
  2020-01-18  0:06             ` Thomas Monjalon
  0 siblings, 1 reply; 17+ messages in thread
From: Honnappa Nagarahalli @ 2020-01-17 15:48 UTC (permalink / raw)
  To: Jerin Jacob
  Cc: Maxime Coquelin, jerinj, dpdk-dev, thomas, techboard, Richardson,
	Bruce, nd, Honnappa Nagarahalli, nd

> > <snip>
> >
> > > >
> > > > On 1/16/20 2:11 PM, Jerin Jacob wrote:
> > > > > Ping.
> > > > >
> > > > > On Thu, Dec 12, 2019 at 6:42 PM <jerinj@marvell.com> wrote:
> > > > >>
> > > > >> From: Jerin Jacob <jerinj@marvell.com>
> > > > >>
> > > > >> Based on the techboard meeting held on 2019-11-06, It's been
> > > > >> decided to disable all kmods by default from v20.02.
> > > > >>
> > > > >> http://mails.dpdk.org/archives/dev/2019-November/151763.html
> > > > >>
> > > > >> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> > > > >> ---
> > > > >>  config/common_linux | 2 --
> > > > >>  1 file changed, 2 deletions(-)
> > > > >>
> > > > >> diff --git a/config/common_linux b/config/common_linux index
> > > > >> c5cf3d662..583efadc7 100644
> > > > >> --- a/config/common_linux
> > > > >> +++ b/config/common_linux
> > > > >> @@ -8,9 +8,7 @@ CONFIG_RTE_EXEC_ENV_LINUX=y
> > > > >> CONFIG_RTE_EXEC_ENV_LINUXAPP=y
> > > > >>
> > > > >>  CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y
> > > > >> -CONFIG_RTE_EAL_IGB_UIO=y
> > > > >>  CONFIG_RTE_EAL_VFIO=y
> > > > >> -CONFIG_RTE_KNI_KMOD=y
> > Suggest to keep the lines, but set them to 'n'. It will be easier to enable.
> 
> In config/common_base it is set as =n. it can be enabled there just like other
> config.
> I just did this way to have symmetry with other configs.
> Thoughts?
Sounds good.
CONFIG_RTE_LIBRTE_PMD_IFPGA_RAWDEV=n can also be removed as it is set in common_base.
CONFIG_RTE_LIBRTE_VHOST_POSTCOPY is set to 'n' in common_linux, but it is not present in common_base.

> 
> 
> > Does this require update to release notes?
> 
> I will send the next version with updating the release notes if there is no
> objection.
> 
> >
> > > > >>  CONFIG_RTE_LIBRTE_KNI=y
> > > > >>  CONFIG_RTE_LIBRTE_PMD_KNI=y
> > > > >>  CONFIG_RTE_LIBRTE_VHOST=y
> > > > >> --
> > > > >> 2.24.0
> > > > >>
> > > > >
> > > >
> > > > Looks good for make build system, but what about Meson?
> > > > as per meson_options.txt, isn't it enabled by default?
> > > > $ grep -rn enable_kmods meson_options.txt 7:option('enable_kmods',
> > > > type: 'boolean', value: true,
> > >
> > > + Bruce,
> > >
> > > Since meson autodetect the presence of Linux kernel dependency for
> > > the kmod build, I thought of keeping as it is as there is no harm. I
> > > am fine with either way, let me the know the feedback, I will send the v2
> based on the comment.
> > >
> > >
> > >
> > > >
> > > > Thanks,
> > > > Maxime
> > > >

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [dpdk-dev] [PATCH v2] config: disable all kmods by default from v20.02
  2019-12-12 13:13 [dpdk-dev] [PATCH] config: disable all kmods by default from v20.02 jerinj
  2020-01-16 13:11 ` Jerin Jacob
@ 2020-01-17 19:14 ` " jerinj
  2020-01-20 17:42   ` Thomas Monjalon
  2020-02-12 17:18   ` Lipiec, Herakliusz
  2020-01-22  6:34 ` [dpdk-dev] [PATCH] " Stephen Hemminger
  2 siblings, 2 replies; 17+ messages in thread
From: jerinj @ 2020-01-17 19:14 UTC (permalink / raw)
  To: dev, Thomas Monjalon, John McNamara, Marko Kovacevic, Bruce Richardson
  Cc: techboard, Jerin Jacob

From: Jerin Jacob <jerinj@marvell.com>

Based on the techboard meeting held on 2019-11-06,
It's been decided to disable all kmods by default from v20.02.

http://mails.dpdk.org/archives/dev/2019-November/151763.html

Signed-off-by: Jerin Jacob <jerinj@marvell.com>
---
v2:
- Updated meson config file to disable the kmods by default(Maxime)
- Updated the release notes(Honnappa)

I am not sure, in which section, we need to update the release notes for
this specific case.I have updated on the "New Features" section.
Thoughts ?

 config/common_linux                    | 2 --
 doc/guides/rel_notes/release_20_02.rst | 5 +++++
 meson_options.txt                      | 2 +-
 3 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/config/common_linux b/config/common_linux
index c5cf3d662..583efadc7 100644
--- a/config/common_linux
+++ b/config/common_linux
@@ -8,9 +8,7 @@ CONFIG_RTE_EXEC_ENV_LINUX=y
 CONFIG_RTE_EXEC_ENV_LINUXAPP=y
 
 CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y
-CONFIG_RTE_EAL_IGB_UIO=y
 CONFIG_RTE_EAL_VFIO=y
-CONFIG_RTE_KNI_KMOD=y
 CONFIG_RTE_LIBRTE_KNI=y
 CONFIG_RTE_LIBRTE_PMD_KNI=y
 CONFIG_RTE_LIBRTE_VHOST=y
diff --git a/doc/guides/rel_notes/release_20_02.rst b/doc/guides/rel_notes/release_20_02.rst
index 9cc257168..afd645e7a 100644
--- a/doc/guides/rel_notes/release_20_02.rst
+++ b/doc/guides/rel_notes/release_20_02.rst
@@ -61,6 +61,11 @@ New Features
   A new API has been added to wait for a memory location to be updated with a
   16-bit, 32-bit, 64-bit value.
 
+* **Disabled all the Linux kernel modules build by default.**
+
+  In order to remove the build time dependency with Linux kernel,
+  The techboard decided to disable all the kernel modules build by
+  default from v20.02 version.
 
 Removed Items
 -------------
diff --git a/meson_options.txt b/meson_options.txt
index bc369d06c..53dfe13c3 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -6,7 +6,7 @@ option('drivers_install_subdir', type: 'string', value: 'dpdk/pmds-<VERSION>',
 	description: 'Subdirectory of libdir where to install PMDs. Defaults to using a versioned subdirectory.')
 option('enable_docs', type: 'boolean', value: false,
 	description: 'build documentation')
-option('enable_kmods', type: 'boolean', value: true,
+option('enable_kmods', type: 'boolean', value: false,
 	description: 'build kernel modules')
 option('examples', type: 'string', value: '',
 	description: 'Comma-separated list of examples to build by default')
-- 
2.24.1


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [dpdk-dev] [dpdk-techboard] [PATCH] config: disable all kmods by default from v20.02
  2020-01-17 15:48           ` Honnappa Nagarahalli
@ 2020-01-18  0:06             ` Thomas Monjalon
  0 siblings, 0 replies; 17+ messages in thread
From: Thomas Monjalon @ 2020-01-18  0:06 UTC (permalink / raw)
  To: Jerin Jacob, Honnappa Nagarahalli
  Cc: Maxime Coquelin, jerinj, dpdk-dev, techboard, Richardson, Bruce,
	nd, Honnappa Nagarahalli, nd

17/01/2020 16:48, Honnappa Nagarahalli:
> > > > > On 1/16/20 2:11 PM, Jerin Jacob wrote:
> > > > > > On Thu, Dec 12, 2019 at 6:42 PM <jerinj@marvell.com> wrote:
> > > > > >> --- a/config/common_linux
> > > > > >> +++ b/config/common_linux
> > > > > >> @@ -8,9 +8,7 @@ CONFIG_RTE_EXEC_ENV_LINUX=y
> > > > > >> CONFIG_RTE_EXEC_ENV_LINUXAPP=y
> > > > > >>
> > > > > >>  CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y
> > > > > >> -CONFIG_RTE_EAL_IGB_UIO=y
> > > > > >>  CONFIG_RTE_EAL_VFIO=y
> > > > > >> -CONFIG_RTE_KNI_KMOD=y
> > > Suggest to keep the lines, but set them to 'n'. It will be easier to enable.

Configs should be enabled in the generated .config,
not in the versioned template.

> > In config/common_base it is set as =n. it can be enabled there just like other
> > config.
> > I just did this way to have symmetry with other configs.
> > Thoughts?
> Sounds good.
> CONFIG_RTE_LIBRTE_PMD_IFPGA_RAWDEV=n can also be removed as it is set in common_base.
> CONFIG_RTE_LIBRTE_VHOST_POSTCOPY is set to 'n' in common_linux, but it is not present in common_base.

Good catch.
All options should be in common_base.




^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [dpdk-dev] [PATCH v2] config: disable all kmods by default from v20.02
  2020-01-17 19:14 ` [dpdk-dev] [PATCH v2] " jerinj
@ 2020-01-20 17:42   ` Thomas Monjalon
  2020-02-12 17:18   ` Lipiec, Herakliusz
  1 sibling, 0 replies; 17+ messages in thread
From: Thomas Monjalon @ 2020-01-20 17:42 UTC (permalink / raw)
  To: Jerin Jacob
  Cc: dev, John McNamara, Marko Kovacevic, Bruce Richardson, techboard

17/01/2020 20:14, jerinj@marvell.com:
> From: Jerin Jacob <jerinj@marvell.com>
> 
> Based on the techboard meeting held on 2019-11-06,
> It's been decided to disable all kmods by default from v20.02.
> 
> http://mails.dpdk.org/archives/dev/2019-November/151763.html
> 
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> ---
> v2:
> - Updated meson config file to disable the kmods by default(Maxime)
> - Updated the release notes(Honnappa)
> 
> I am not sure, in which section, we need to update the release notes for
> this specific case.I have updated on the "New Features" section.
> Thoughts ?

I moved (and reworded a bit) in "Removed Items".

Applied, thanks




^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [dpdk-dev] [PATCH] config: disable all kmods by default from v20.02
  2019-12-12 13:13 [dpdk-dev] [PATCH] config: disable all kmods by default from v20.02 jerinj
  2020-01-16 13:11 ` Jerin Jacob
  2020-01-17 19:14 ` [dpdk-dev] [PATCH v2] " jerinj
@ 2020-01-22  6:34 ` " Stephen Hemminger
  2020-01-22  9:08   ` Thomas Monjalon
  2 siblings, 1 reply; 17+ messages in thread
From: Stephen Hemminger @ 2020-01-22  6:34 UTC (permalink / raw)
  To: jerinj; +Cc: dev, Thomas Monjalon, techboard

On Thu, 12 Dec 2019 18:43:02 +0530
<jerinj@marvell.com> wrote:

> From: Jerin Jacob <jerinj@marvell.com>
> 
> Based on the techboard meeting held on 2019-11-06,
> It's been decided to disable all kmods by default from v20.02.
> 
> http://mails.dpdk.org/archives/dev/2019-November/151763.html
> 
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> ---
>  config/common_linux | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/config/common_linux b/config/common_linux
> index c5cf3d662..583efadc7 100644
> --- a/config/common_linux
> +++ b/config/common_linux
> @@ -8,9 +8,7 @@ CONFIG_RTE_EXEC_ENV_LINUX=y
>  CONFIG_RTE_EXEC_ENV_LINUXAPP=y
>  
>  CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y
> -CONFIG_RTE_EAL_IGB_UIO=y
>  CONFIG_RTE_EAL_VFIO=y
> -CONFIG_RTE_KNI_KMOD=y
>  CONFIG_RTE_LIBRTE_KNI=y
>  CONFIG_RTE_LIBRTE_PMD_KNI=y
>  CONFIG_RTE_LIBRTE_VHOST=y

On a related topic. All the documented examples should be changed to use vfio.
Everyone just cut and paste from the documentation and expects igb_uio.

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [dpdk-dev] [PATCH] config: disable all kmods by default from v20.02
  2020-01-22  6:34 ` [dpdk-dev] [PATCH] " Stephen Hemminger
@ 2020-01-22  9:08   ` Thomas Monjalon
  0 siblings, 0 replies; 17+ messages in thread
From: Thomas Monjalon @ 2020-01-22  9:08 UTC (permalink / raw)
  To: jerinj, Stephen Hemminger; +Cc: dev, techboard

22/01/2020 07:34, Stephen Hemminger:
> On a related topic. All the documented examples should be changed to use vfio.
> Everyone just cut and paste from the documentation and expects igb_uio.

Yes, good catch Stephen.
Who is volunteer?




^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [dpdk-dev] [PATCH v2] config: disable all kmods by default from v20.02
  2020-01-17 19:14 ` [dpdk-dev] [PATCH v2] " jerinj
  2020-01-20 17:42   ` Thomas Monjalon
@ 2020-02-12 17:18   ` Lipiec, Herakliusz
  2020-02-12 17:39     ` Thomas Monjalon
  1 sibling, 1 reply; 17+ messages in thread
From: Lipiec, Herakliusz @ 2020-02-12 17:18 UTC (permalink / raw)
  To: jerinj, dev, Thomas Monjalon, Mcnamara, John, Kovacevic, Marko,
	Richardson, Bruce
  Cc: techboard

This change also affects usertools/dpdk-setup.sh
When following this: https://doc.dpdk.org/guides/linux_gsg/quick_start.html
And trying to insert igb_uio, it gives following error:

## ERROR: Target does not have the DPDK UIO Kernel Module.
       To fix, please try to rebuild target.

Should this script (and docs) be changed too?

Regards,
Herakliusz

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of jerinj@marvell.com
> Sent: Friday, January 17, 2020 7:14 PM
> To: dev@dpdk.org; Thomas Monjalon <thomas@monjalon.net>; Mcnamara,
> John <john.mcnamara@intel.com>; Kovacevic, Marko
> <marko.kovacevic@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>
> Cc: techboard@dpdk.org; Jerin Jacob <jerinj@marvell.com>
> Subject: [dpdk-dev] [PATCH v2] config: disable all kmods by default from
> v20.02
> 
> From: Jerin Jacob <jerinj@marvell.com>
> 
> Based on the techboard meeting held on 2019-11-06, It's been decided to
> disable all kmods by default from v20.02.
> 
> http://mails.dpdk.org/archives/dev/2019-November/151763.html
> 
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> ---
> v2:
> - Updated meson config file to disable the kmods by default(Maxime)
> - Updated the release notes(Honnappa)
> 
> I am not sure, in which section, we need to update the release notes for this
> specific case.I have updated on the "New Features" section.
> Thoughts ?
> 
>  config/common_linux                    | 2 --
>  doc/guides/rel_notes/release_20_02.rst | 5 +++++
>  meson_options.txt                      | 2 +-
>  3 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/config/common_linux b/config/common_linux index
> c5cf3d662..583efadc7 100644
> --- a/config/common_linux
> +++ b/config/common_linux
> @@ -8,9 +8,7 @@ CONFIG_RTE_EXEC_ENV_LINUX=y
> CONFIG_RTE_EXEC_ENV_LINUXAPP=y
> 
>  CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=y
> -CONFIG_RTE_EAL_IGB_UIO=y
>  CONFIG_RTE_EAL_VFIO=y
> -CONFIG_RTE_KNI_KMOD=y
>  CONFIG_RTE_LIBRTE_KNI=y
>  CONFIG_RTE_LIBRTE_PMD_KNI=y
>  CONFIG_RTE_LIBRTE_VHOST=y
> diff --git a/doc/guides/rel_notes/release_20_02.rst
> b/doc/guides/rel_notes/release_20_02.rst
> index 9cc257168..afd645e7a 100644
> --- a/doc/guides/rel_notes/release_20_02.rst
> +++ b/doc/guides/rel_notes/release_20_02.rst
> @@ -61,6 +61,11 @@ New Features
>    A new API has been added to wait for a memory location to be updated
> with a
>    16-bit, 32-bit, 64-bit value.
> 
> +* **Disabled all the Linux kernel modules build by default.**
> +
> +  In order to remove the build time dependency with Linux kernel,  The
> + techboard decided to disable all the kernel modules build by  default
> + from v20.02 version.
> 
>  Removed Items
>  -------------
> diff --git a/meson_options.txt b/meson_options.txt index
> bc369d06c..53dfe13c3 100644
> --- a/meson_options.txt
> +++ b/meson_options.txt
> @@ -6,7 +6,7 @@ option('drivers_install_subdir', type: 'string', value:
> 'dpdk/pmds-<VERSION>',
>  	description: 'Subdirectory of libdir where to install PMDs. Defaults to
> using a versioned subdirectory.')  option('enable_docs', type: 'boolean',
> value: false,
>  	description: 'build documentation')
> -option('enable_kmods', type: 'boolean', value: true,
> +option('enable_kmods', type: 'boolean', value: false,
>  	description: 'build kernel modules')
>  option('examples', type: 'string', value: '',
>  	description: 'Comma-separated list of examples to build by default')
> --
> 2.24.1


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [dpdk-dev] [PATCH v2] config: disable all kmods by default from v20.02
  2020-02-12 17:18   ` Lipiec, Herakliusz
@ 2020-02-12 17:39     ` Thomas Monjalon
  0 siblings, 0 replies; 17+ messages in thread
From: Thomas Monjalon @ 2020-02-12 17:39 UTC (permalink / raw)
  To: jerinj, Mcnamara, John, Kovacevic, Marko, Richardson, Bruce,
	Lipiec, Herakliusz
  Cc: dev, techboard

12/02/2020 18:18, Lipiec, Herakliusz:
> This change also affects usertools/dpdk-setup.sh
> When following this: https://doc.dpdk.org/guides/linux_gsg/quick_start.html
> And trying to insert igb_uio, it gives following error:
> 
> ## ERROR: Target does not have the DPDK UIO Kernel Module.
>        To fix, please try to rebuild target.
> 
> Should this script (and docs) be changed too?

Yes, please update scripts and docs to recommend using VFIO.




^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, back to index

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-12 13:13 [dpdk-dev] [PATCH] config: disable all kmods by default from v20.02 jerinj
2020-01-16 13:11 ` Jerin Jacob
2020-01-16 18:33   ` [dpdk-dev] [dpdk-techboard] " Maxime Coquelin
2020-01-16 18:43     ` Jerin Jacob
2020-01-16 22:38       ` Honnappa Nagarahalli
2020-01-17  4:07         ` Jerin Jacob
2020-01-17 15:48           ` Honnappa Nagarahalli
2020-01-18  0:06             ` Thomas Monjalon
2020-01-17  8:29       ` Maxime Coquelin
2020-01-17  9:19         ` Kevin Traynor
2020-01-17  9:55         ` Jerin Jacob
2020-01-17 19:14 ` [dpdk-dev] [PATCH v2] " jerinj
2020-01-20 17:42   ` Thomas Monjalon
2020-02-12 17:18   ` Lipiec, Herakliusz
2020-02-12 17:39     ` Thomas Monjalon
2020-01-22  6:34 ` [dpdk-dev] [PATCH] " Stephen Hemminger
2020-01-22  9:08   ` Thomas Monjalon

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox