From: Luca Vizzarro <Luca.Vizzarro@arm.com>
To: Dean Marx <dmarx@iol.unh.edu>,
probb@iol.unh.edu, npratte@iol.unh.edu, yoan.picchi@foss.arm.com,
Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com
Cc: dev@dpdk.org
Subject: Re: [PATCH v1 4/4] change verification field in unified packet suite
Date: Wed, 14 May 2025 16:42:02 +0100 [thread overview]
Message-ID: <251e5f57-9a4b-49b3-a495-3f8444e365b4@arm.com> (raw)
In-Reply-To: <20250306214747.579340-5-dmarx@iol.unh.edu>
The changes look fine, so this is for them:
Reviewed-by: Luca Vizzarro <luca.vizzarro@arm.com>
But the commit subject/body need amendment. The `dts: ` component prefix
is missing in the subject
On 06/03/2025 22:47, Dean Marx wrote:
> Changes the unified packet testing suite to use layer 4
> destination ports as packet verification IDs.
and the body is not following an imperative form. This actually also
applies for the commit 2/4.
next prev parent reply other threads:[~2025-05-14 15:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 21:47 [PATCH v1 0/4] dts: change verbose packet verification to layer 4 ports Dean Marx
2025-03-06 21:47 ` [PATCH v1 1/4] dts: add layer 4 port field to verbose parser Dean Marx
2025-05-14 15:37 ` Luca Vizzarro
2025-05-14 20:12 ` Nicholas Pratte
2025-03-06 21:47 ` [PATCH v1 2/4] dts: change verification field in checksum offload suite Dean Marx
2025-05-14 15:38 ` Luca Vizzarro
2025-05-14 20:20 ` Nicholas Pratte
2025-03-06 21:47 ` [PATCH v1 3/4] dts: remove unnecessary capability requirement Dean Marx
2025-05-14 15:38 ` Luca Vizzarro
2025-05-14 20:21 ` Nicholas Pratte
2025-03-06 21:47 ` [PATCH v1 4/4] change verification field in unified packet suite Dean Marx
2025-05-14 15:42 ` Luca Vizzarro [this message]
2025-05-14 20:23 ` Nicholas Pratte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=251e5f57-9a4b-49b3-a495-3f8444e365b4@arm.com \
--to=luca.vizzarro@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=dev@dpdk.org \
--cc=dmarx@iol.unh.edu \
--cc=npratte@iol.unh.edu \
--cc=paul.szczepanek@arm.com \
--cc=probb@iol.unh.edu \
--cc=yoan.picchi@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).