From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by dpdk.org (Postfix) with ESMTP id 53168C35E for ; Thu, 16 Jul 2015 14:27:00 +0200 (CEST) Received: by widic2 with SMTP id ic2so13833229wid.0 for ; Thu, 16 Jul 2015 05:27:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=7UCiTClyVxlgG7+qVoBrEG66e5xqvPAa7sZ0VDhqX8g=; b=CAC98H/eBqobQKQ63f1SblKPoDLHVqEp5zoprXfzo2JMgXJ26hX4qWGssakhEZ2DpW lU/nkMq7veq+dFW6J4ZTWcQR2amfZZ6aDTQTrVQtaKJcIXmdhjzgxaelXmFbxjtO8bT4 WunSm90TPlZst0FvNzTZM0fh0SAb+dWPikuKfV+Se5qVxhLcrg7HI2YuCpWyfM1rRX/R tW35XnWAt4HicMVMs6T5vlkBNbND7w1i/z5pHl5K9nt4N6Er5NaWLsHx96wE9eGKxoNN c4kzOYTtlsBsrh/Ntk21rI/rzCBd+sDPYV4v62iNXwAxPL+sZl/PJNqc6Cid53sfU5ec Wz2A== X-Gm-Message-State: ALoCoQndf7yZLu8ptTabpnL7Db0oN3GkltvcnvIYBcQMaodcEm8YPYBsJge9CVu1zJTA+DPEs65g X-Received: by 10.180.96.170 with SMTP id dt10mr4837903wib.42.1437049620197; Thu, 16 Jul 2015 05:27:00 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.151.210]) by smtp.gmail.com with ESMTPSA id nb9sm2947229wic.10.2015.07.16.05.26.58 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Jul 2015 05:26:59 -0700 (PDT) From: Thomas Monjalon To: Cristian Dumitrescu Date: Thu, 16 Jul 2015 14:25:49 +0200 Message-ID: <2522078.kODQ7Zxo1C@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <1437049176-6866-1-git-send-email-cristian.dumitrescu@intel.com> References: <1437049176-6866-1-git-send-email-cristian.dumitrescu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for librte_port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jul 2015 12:27:00 -0000 2015-07-16 13:19, Cristian Dumitrescu: > +* librte_port (rte_port.h): Macros to access the packet meta-data stored within > + the packet buffer will be adjusted to cover the packet mbuf structure as well, > + as currently they are able to access any packet buffer location except the > + packet mbuf structure. The consequence is that applications currently using > + these macros will have to adjust the value of the offset parameter of these > + macros by increasing it with sizeof(struc rte_mbuf). The affected macros are: > + RTE_MBUF_METADATA_UINT<8, 16, 32, 64>_PTR and > + RTE_MBUF_METADATA_UINT<8, 16, 32, 64>. In terms of code changes, most likely > + only the definition of RTE_MBUF_METADATA_UINT8_PTR macro will be changed from > + ``(&((uint8_t *) &(mbuf)[1])[offset])`` to > + ``(&((uint8_t *) (mbuf))[offset])``. Cristian, General comment: you are too verbose :) Specifically on this patch: same comment ;)