From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 01D6AA0A05; Wed, 20 Jan 2021 00:39:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8BBAA140F3B; Wed, 20 Jan 2021 00:39:39 +0100 (CET) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id 94B7F140E9A for ; Wed, 20 Jan 2021 00:39:38 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 3F22F15D2; Tue, 19 Jan 2021 18:39:37 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 19 Jan 2021 18:39:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= DZDhng6nDpnMbc21tP73yaynUMOp+e4Xpw1gzuYNAfQ=; b=HyOds9LCEd0QiFAc ByaXqTMN+WQPvrodN3K7RKnVDiRwWNQcYoUxHn/7d2ydkTMY8Db9Uy1LOUt6hsv5 F+be+d3EXKyxMd3VN8m1JiU2g+E2iA8z7zewY2vqlU5ErgW7WmDs/IejjPi7wP/q STEFrO0047lzPFPQQnY8mQu09doESJL1BUHb+preRkSUIeWmMzrIzDXj8zJamBR3 N6L2xJuKYZmsE1+Nf7DRGCDgEe3X14hGjUs+4A9QUDQN2sZNd2UiAhF179bQvQWg tOvh2VLzJt3XokkIdn5SfyHhMo9fBkFqKsL3qTNF4FVPhtX3bhxn4H1beWS7lbPJ gP/zKw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=DZDhng6nDpnMbc21tP73yaynUMOp+e4Xpw1gzuYNA fQ=; b=XiBzZsZf802Q89pI0LhPgI2pP482VNhmMp6M8lyTAZbOwhkwMupmdNX9h EplPheb/tOb2WR9nHTJjdkbwasK3f73qzbmC7A+yQtXUy3fgMEvA+KNfVFmPEOLI GlwgXz+d6HYKjDdPhzvwiAM5/o/T7k/tNek/zSUlddw8vbtMQWHNEa1y+vl4uRuA MYgWFV5gWcJnLw6gE8EGSK/i31rFMPS+UBgbZy6vfAf92/oE8BOabr0j/f5O4aFT FjugqJAEXSm03AE8aN04oZOykIPcKiTyhQ/qSIZ//MNrLKn4IcEQQ9RWlT6DINm5 eM42IrMSIU+2V6ZwVD6H1WV6IkDEg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddugddugecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3DE6E1080059; Tue, 19 Jan 2021 18:39:36 -0500 (EST) From: Thomas Monjalon To: Anatoly Burakov Cc: dev@dpdk.org Date: Wed, 20 Jan 2021 00:39:33 +0100 Message-ID: <25223796.ZyEVLiDlFK@thomas> In-Reply-To: <20ad523bdee024979dfc74cc32c8c02954cd1d4c.1610984505.git.anatoly.burakov@intel.com> References: <9843593ce51003ea5e372a8107a96acdc01e8958.1610712939.git.anatoly.burakov@intel.com> <20ad523bdee024979dfc74cc32c8c02954cd1d4c.1610984505.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] mem: improve parameter checking on memory hotplug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 18/01/2021 16:41, Anatoly Burakov: > + /* now that we've validated the request, time for a PSA */ What is PSA? > + eal_memalloc_mem_event_notify(RTE_MEM_EVENT_FREE, > + m->free_req.addr, m->free_req.len); [...] > + /* this is checked by the API, but we need to prevent divide by zero */ > + if (ar->page_sz == 0 || !rte_is_power_of_2(ar->page_sz)) { > + RTE_LOG(ERR, EAL, "Attempting to allocate with page size\n"); Is there a missing part in the log message?