From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 50BEA7EC7 for ; Fri, 3 May 2019 19:30:56 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id D7FAA2662E; Fri, 3 May 2019 13:30:55 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 03 May 2019 13:30:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=0mSmTsbT4k5oD4xNVi0zrtiGnADEAL+aSeruiZbU3ic=; b=GNQOihSGqJsZ 6Ny4S6fiQOJGtM3U22hWK31Ykc7ZUgeTqmHfh7jM4/vxUYCyQ0MCw+8lr1fJO+Bx TOyqtEg5DrJdD5o7xkAkYMRGI3bbIs+sCPhTaFkD0+NpVLOCYVLOmKSzZ1+XVoxG D1T1ozTx70INlAQCNIO320w6MeTf8iU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=0mSmTsbT4k5oD4xNVi0zrtiGnADEAL+aSeruiZbU3 ic=; b=6xtxlHPVlQwVZ51zLF5ZcOP4EgMqCiyJQzwPtvCBFh6A2AJmDs82yfGNg /Voxhqx/gT20b3kJyVteJjCdAnM4Q0raDc1rUw3VbmJeDZcq73x7npLwnJ5kbB/c eQGVx4d2aUYOb9TzUwayPebTb5ZYkusNeUqkHsVdR2wfPkXeAidwEXy0sr/j3Ml6 +Em//Mxx0hdrJeKg+7RYiaL4XrHvUuD7LAUuPpWVsFsUC0MCH9Q/IrP29kUwia8m 4qt7XDKlOhBlKzUpaa8TAQPFaSIMKHQ+SdUV/YeolpLr6E3TUQiMeKsO2O0XHxdb Jxy7HpU0JUv/SQNiWegFKedsEY2BA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrjedugdduudekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 833E6E4122; Fri, 3 May 2019 13:30:54 -0400 (EDT) From: Thomas Monjalon To: "Burakov, Anatoly" Cc: dev@dpdk.org Date: Fri, 03 May 2019 19:30:50 +0200 Message-ID: <2523412.2DFPPxjE94@xps> In-Reply-To: References: <20190503153539.17993-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ipc: replace bool checks with explicit non-zero X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 May 2019 17:30:56 -0000 03/05/2019 17:52, Burakov, Anatoly: > On 03-May-19 4:35 PM, Thomas Monjalon wrote: > > The function check_input() was returning a bool as error code. > > It is changed to return an int, semantically more correct. > > While at it, make checks of validate_action_name() return > > explicit as described in the coding guidelines. > > > > Signed-off-by: Thomas Monjalon > > Acked-by: Anatoly Burakov Applied From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 1DBCEA0AC5 for ; Fri, 3 May 2019 19:30:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EF95B1B113; Fri, 3 May 2019 19:30:56 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 50BEA7EC7 for ; Fri, 3 May 2019 19:30:56 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id D7FAA2662E; Fri, 3 May 2019 13:30:55 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 03 May 2019 13:30:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=0mSmTsbT4k5oD4xNVi0zrtiGnADEAL+aSeruiZbU3ic=; b=GNQOihSGqJsZ 6Ny4S6fiQOJGtM3U22hWK31Ykc7ZUgeTqmHfh7jM4/vxUYCyQ0MCw+8lr1fJO+Bx TOyqtEg5DrJdD5o7xkAkYMRGI3bbIs+sCPhTaFkD0+NpVLOCYVLOmKSzZ1+XVoxG D1T1ozTx70INlAQCNIO320w6MeTf8iU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=0mSmTsbT4k5oD4xNVi0zrtiGnADEAL+aSeruiZbU3 ic=; b=6xtxlHPVlQwVZ51zLF5ZcOP4EgMqCiyJQzwPtvCBFh6A2AJmDs82yfGNg /Voxhqx/gT20b3kJyVteJjCdAnM4Q0raDc1rUw3VbmJeDZcq73x7npLwnJ5kbB/c eQGVx4d2aUYOb9TzUwayPebTb5ZYkusNeUqkHsVdR2wfPkXeAidwEXy0sr/j3Ml6 +Em//Mxx0hdrJeKg+7RYiaL4XrHvUuD7LAUuPpWVsFsUC0MCH9Q/IrP29kUwia8m 4qt7XDKlOhBlKzUpaa8TAQPFaSIMKHQ+SdUV/YeolpLr6E3TUQiMeKsO2O0XHxdb Jxy7HpU0JUv/SQNiWegFKedsEY2BA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrjedugdduudekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 833E6E4122; Fri, 3 May 2019 13:30:54 -0400 (EDT) From: Thomas Monjalon To: "Burakov, Anatoly" Cc: dev@dpdk.org Date: Fri, 03 May 2019 19:30:50 +0200 Message-ID: <2523412.2DFPPxjE94@xps> In-Reply-To: References: <20190503153539.17993-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] ipc: replace bool checks with explicit non-zero X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190503173050.M2YBSeC2bnW_z6YXUX_vWeRpeuuQxFr7D0mpEeMdt5Q@z> 03/05/2019 17:52, Burakov, Anatoly: > On 03-May-19 4:35 PM, Thomas Monjalon wrote: > > The function check_input() was returning a bool as error code. > > It is changed to return an int, semantically more correct. > > While at it, make checks of validate_action_name() return > > explicit as described in the coding guidelines. > > > > Signed-off-by: Thomas Monjalon > > Acked-by: Anatoly Burakov Applied