From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 317D64339F; Thu, 23 Nov 2023 02:59:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AEEC0402BD; Thu, 23 Nov 2023 02:59:03 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 3000D40041 for ; Thu, 23 Nov 2023 02:59:02 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id B9B8E5C00D5; Wed, 22 Nov 2023 20:59:01 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 22 Nov 2023 20:59:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1700704741; x=1700791141; bh=o/pbwBMM42UedqdY7va1e//GJiYTXWLSxVv ZoUWbLzY=; b=j9mnnl01tJD7xI3rANHcZvXwx14oz17Fn8bHov61fXHvFcX7aF2 nGL/QiD03C47lDR7TBkaSw2yw0rbAS3V7y19+YIFP6sfn5msjkXzyLkedL9WxDP+ 8bNP6BS8HzdDuqFytJH7iAHhKt6+vP5BGt0GL72qEEUsOtSJJNsIUKqmtGte5j1x X+Q40TDp28YXV2itRj5QPQOh8UarUxzeOWTbA/bp0l/5DAXsUubcup/GA98kCTFw H5jQGpy1R7fIxt+ZVdilfdFjxoH9qqypLiHLoJhrzokImS+ppaoZAwC3AX+a1cg3 mWPjcK6YATsETnmLfZZ2Wwb84fac5ZLqwnQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1700704741; x=1700791141; bh=o/pbwBMM42UedqdY7va1e//GJiYTXWLSxVv ZoUWbLzY=; b=FtTdjmsSoKZO6LXdHXtIZ1aLgXgiIud1GWeTKw9lZvXYwz0wSKO y7a+9IIEPHxtHuQ+6ibonrHf3yJqHyqVEqNi7srfbkqgUlIjPdd195Qym8uTj4zh VzVQhhS1xAOz1oTZW6bBukhBdMJjhk6SHqaaiTDZUCO3R8GkP6mry6g+JE1c0sfF Ftl6bEKXU8S9d7ParppxjLBKSNRpBA+Hv6VnPJDN3KP9wqFaqjDt1X9Nki/GJmUo 1RQR8ymw7/nbP6efOyowaQrl3Bawe48f/hzto1nqUZnfZJ0jodC9FJb+NlVoaqjd 223tI0kXpBYeb9fTnSzoJ5y489sbu0ug3OQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudehvddggeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 22 Nov 2023 20:59:00 -0500 (EST) From: Thomas Monjalon To: Sivaprasad Tummala Cc: david.hunt@intel.com, anatoly.burakov@intel.com, david.marchand@redhat.com, dev@dpdk.org, john.mcnamara@intel.com, ferruh.yigit@amd.com, karen.kelly@intel.com Subject: Re: [PATCH] examples/l3fwd-power: fix to configure the uncore env Date: Thu, 23 Nov 2023 02:58:58 +0100 Message-ID: <25240705.EfDdHjke4D@thomas> In-Reply-To: <20231026151959.1458112-1-sivaprasad.tummala@amd.com> References: <20231026151959.1458112-1-sivaprasad.tummala@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 26/10/2023 17:19, Sivaprasad Tummala: > Updated the l3fwd-power app to configure the uncore env before invoking > any uncore APIs. With auto-detection in 'rte_power_uncore_init()' it is > too late because other APIs already called. You are also updating the uncore API. > + if (env == RTE_UNCORE_PM_ENV_AUTO_DETECT) > + /* Currently only intel_uncore is supported. This will be > + * extended with auto-detection support for multiple uncore > + * implementations. > + */ > + env = RTE_UNCORE_PM_ENV_INTEL_UNCORE; It looks like this patch does not make sense without AMD support.