From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id C39CD1B272 for ; Wed, 30 Jan 2019 12:31:26 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 8DCD41783; Wed, 30 Jan 2019 06:31:24 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 30 Jan 2019 06:31:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Y0jH8bNwrFUhhw+hruNkaav5Fd8jAoi81yLSKr/LCqE=; b=fvByfCYwrqw3 xt69Le4adC1GqhqeeC9pQU3uG6uKKXQePREcfV8F0S7D+I5ujQn2xRO/3caFhhsp cfx8NdJgK91EG5TIvBt1U7Ac9O7Cdjj9/Xh/pzMc1+R4Z5gEJUvE+FRllwuIjTNc 1QKHQdVrAmB11poZiqf+4hHYGQWbjQU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=Y0jH8bNwrFUhhw+hruNkaav5Fd8jAoi81yLSKr/LC qE=; b=V1pem4sqlJ9Xed9V216JCXQkKuljZxKwAw8gob0j2LKBjWXxTlmYibKko Vwmb1Hur+HFZEv6HvaDy7OCL+tLJ0qKVw9RFGbA/D1FBB0ILlI0rvTrTkq8tep9b +cj6EVosBN+1yTwxFYu9cQLeyLtqeInfEikSwY4i/CBaU2qYIzQPE1Jatxqrx9dJ dicsi/w2IMchio7m0iDeqc1/vWFcVoNKKpqGm4jIgVMPgoZBjWFRIKsHJMhes5yh I7rzXeDTFdBT/QHRrSKmfDif0k8g0BSEiI7DW91s6kPnaVTNKNvlQaEbkcNYXmOv GAt5603+/GQb3BRO0HTsFk7/CioUA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrjeeggddvlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecufedt tdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufffkfgjfh gggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceo thhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfe drudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A453CE4068; Wed, 30 Jan 2019 06:31:22 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: Ferruh Yigit , dev@dpdk.org, Qi Zhang , david.marchand@redhat.com Date: Wed, 30 Jan 2019 12:31:21 +0100 Message-ID: <2527672.4HATR1JlfD@xps> In-Reply-To: <20190130112934.GB157424@bricha3-MOBL.ger.corp.intel.com> References: <20190129153052.38634-1-ferruh.yigit@intel.com> <20190130112934.GB157424@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] devtools: check commit log fixes syntax X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2019 11:31:27 -0000 30/01/2019 12:29, Bruce Richardson: > On Wed, Jan 30, 2019 at 11:15:44AM +0000, Ferruh Yigit wrote: > > On 1/29/2019 8:41 PM, Thomas Monjalon wrote: > > > 29/01/2019 16:30, Ferruh Yigit: > > >> Fixes line commit id length defined as 12 in fixline alias: > > >> fixline = log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %ae' > > >> > > >> Check if the Fixes line commit id length matches the defined value. > > > > > > This check was missing on purpose, in order to not be too strict. > > > I think it's OK if the length of the SHA1 is not always the same. > > > > That is OK, if we don't want to be strict on this, I will update patch as rejected. > > > I think having this check is still good. It's not enforcing the rule, just > warning when violated. In 99% of cases this warning should be fixed IMHO, > especially if you guys are fixing these manually anyway. I don't fix it manually. I think SHA1 length has no importance. Why do you think it should be fixed?