From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1EE49A0C41; Thu, 30 Sep 2021 15:46:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F283D410E5; Thu, 30 Sep 2021 15:46:07 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 8510C40DDA for ; Thu, 30 Sep 2021 15:46:06 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10122"; a="212445441" X-IronPort-AV: E=Sophos;i="5.85,336,1624345200"; d="scan'208";a="212445441" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2021 06:46:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,336,1624345200"; d="scan'208";a="709013499" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga005.fm.intel.com with ESMTP; 30 Sep 2021 06:46:05 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 30 Sep 2021 06:46:04 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 30 Sep 2021 06:46:04 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 30 Sep 2021 06:46:04 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.170) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 30 Sep 2021 06:46:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A6nvEQokpFyODg/XnMwZ0gMTURVyhafRoDZmKWmJkBHV6rtto9At0fl9sVVNm0mp9IvVhvsdVlUWIK1st3rxW3K0LJtoZGQ5gaTppTvMjYRT3bSO5nTnlz3jFJTyz9KqPswQWupht64qcB4WUhWaoLtmV6I1YmX/gH0p9Z8FsDNP6631E9diYiX4Vs8SCBibz9bvYXsSpfe0OV3EBy+pDe+h/Xh2w2tdpOL2Um21UP+l12mZ7r7H1PImYZUXg3UGRdo8D1z5GfVyuB7gIPoboucNAxn9fAa+DVDQ6sWYwlLRUgCkKc+yaa1jIrPHo+7rxwsyUFohOrvjhjpKY3G2OA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=YWw1qyRhwmd406u/Dz0z+t+QydKGmgqHB4clG+GE/CY=; b=AAa7hdLkAXpjVfgnpUzo7jZpB/yHEQPXLHbsxJEPbfGZXFehbFh4JOka0fbb73l97dVbSn15V7LH1GKP96SrA2jvpShQjkVdWdMtqTp+eaCPIFIIdUyg4uzvM9E6w5BLzM782npdNjjHycil8BuNw2jw+uaHE8cSxVcKstQX7bWzBm00KuUN0ITE0NTtOTOIO/w+ytJv2BDs2DU4/htqw4HPT6DyfImLEII944ELwizXQTkYQcjCghozgTVWUhyZqNENFsz1aP2YV3vXt2787j1yDAFaR+M5JloTcJLvvwVfQiSLF+L/T82OxEt4k/TjkUsqf/6tL0fM7A+VM5rpYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YWw1qyRhwmd406u/Dz0z+t+QydKGmgqHB4clG+GE/CY=; b=iwwaMCbHT4UHfVAdkLNuN8/124UiB4zQBOQdIxyP/YUy6XiOpHR8H/F1bu2RP/P2GNAlheTVO6gIKTDp6Csoh9TiKjB1izYUOGTkN02Iuwej/d5CU78FEcLe7mM9WGoQ7hke39hqpFixkHvghflyTlcuCmbp2awJxalbXsf8rtI= Authentication-Results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5111.namprd11.prod.outlook.com (2603:10b6:510:3c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14; Thu, 30 Sep 2021 13:46:02 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4544.021; Thu, 30 Sep 2021 13:46:02 +0000 To: , CC: , , , , Jun Yang References: <20210928110850.21184-1-nipun.gupta@nxp.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <2528e0db-713e-8c46-c978-304905a80466@intel.com> Date: Thu, 30 Sep 2021 14:45:55 +0100 In-Reply-To: <20210928110850.21184-1-nipun.gupta@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB6PR0301CA0064.eurprd03.prod.outlook.com (2603:10a6:4:54::32) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR0301CA0064.eurprd03.prod.outlook.com (2603:10a6:4:54::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15 via Frontend Transport; Thu, 30 Sep 2021 13:46:00 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e38a005e-3a21-4f9d-bd33-08d98418a4a2 X-MS-TrafficTypeDiagnostic: PH0PR11MB5111: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GQ1PmT/zJW/h226ehxleJdp+ZzbKCH92nrSvllCdWAp2/cqDLTMEDYVP88B0o94HtGxlGjv9iWFWSdJF8c+EkWrciumqCwlIeYB6MZYrpnrJm0Aao5PDDERZ3tHt+QgFT10yXBX5DB6SaOFVdej8p2YU1FEChwQEKae28KQck4vxQn3ZM5K9YiH/Y7Yt0xKiA3ARce6zMtiwVkpPaO/iwbLu0QPAKadJHNJmswCTm1EflVJ3Yqd7esMI4UTz7ZS3ZGgSYz88EnGUZDlSyiVsSwq5V/cRkmoGRXz799lCc3fJqsnEpR+VcDvHIsz2/fOd1Vx79yjloxRn4TmGllXp8Dr99uEC3NPhtvOtIwfa2RNy48x/Eyrf+GUKp+SJdOSATtJ+dMXXcXyTk7SA5qPZ82974HSbpYJMQ4bkwr7T1ERC80SxbRSHJiWqFWaRDd1qdIcfgbACFqJ1vf6zCWpJJEWFCcYDOrfr1xTUvcwCfeF4MFg4rymnpaXtQ8xSPV5mKVXJ5OtXjN/IG+ZvCazMqf6y5CLH5RYj0chuDUBBEh7afVGuDacKJXy1JU9bFn5KOq0NG9gUS5NwUDBqqLHGueHvU10bguFdptpTEt+zA8fvbeD9tvTECRtEOXnvBPksj6nFvCpzUnqzjhhNYVlOMoE2GibCqawtO8vho3P+gNcsUu6FR4ySDNrbLf600q9FWzIeErCWIs53T+uqQ3QZoQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(8936002)(83380400001)(36756003)(66946007)(4326008)(31686004)(508600001)(316002)(86362001)(2906002)(31696002)(66476007)(38100700002)(16576012)(8676002)(66556008)(2616005)(53546011)(6486002)(44832011)(956004)(5660300002)(186003)(26005)(6666004)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RWMzL29hZktVZ0c4Z04rc0U3MS9HTkJJZ3VWNm5va1A1MkdKZStpYWYxM3Nt?= =?utf-8?B?SmRGYi9GL3greUJUVEZPMFpSWG5tU0JqZXFkVktWYzVTZjNxTFBnTkpuTjdU?= =?utf-8?B?aklzTlBUdCtHcTZYUW0waldrR3dnWStsZE1aRlhkR1pJWTZSdWQ1Qm5ZeVVw?= =?utf-8?B?eGtPbFF1aGFtQkxtMlJhald2c3ZqMVFpL1hCZGhXcWkyQ1FYb0hSZm1QeTVD?= =?utf-8?B?YjJac0lQN2xvRDE4RGM1VnpzZlFvclFadnl2c0dma1JTT3ljRnpHSEdNZUJC?= =?utf-8?B?R3E4d0FTb3lEUzBHMXA2V3AraEhBSXN6Qzg2cVYrZjhWQy9pNGtISVhFeW9U?= =?utf-8?B?UnRDSXpDUGxpQnNybDVMMXJxZWdkNjdPU1Bqd3VNTzgzOXkrd0RnNWtQN0Jl?= =?utf-8?B?T0hCVnAwMFZqUDVKUTl3NHFrUGZsMCswQ0d0THlyOXpqTytrVlFzcnJPUG9V?= =?utf-8?B?T25EYmlYODcxRzFpOFNheWFrYnhLRmMzMnh5dXJMSXJoZUpHRUVaYlNKY1ZY?= =?utf-8?B?VjlCL3NjdFpSSTlBSFZya0FncDV6QkdvaWdLWE9UaStyNmVZUGVCbllEcEZ0?= =?utf-8?B?ZWwzRmF6UGhaTVNEZXFBWXVZYmd1elpqTnhwVHdZaHpvSENjUTNsSmFSZENJ?= =?utf-8?B?Um9TV2JqSi90T0ZZdHNtSHUyR1EwQWZHOG1LWmlZQWI0cFd3MjFhb2RMWGUy?= =?utf-8?B?L2R2ZHpZYVk0Mlk0UkpjSGh1SUI2UDBNNFluWFErZGZKQUtqWE5OcDVQQ1Ez?= =?utf-8?B?VDlmdm9XTVNsY3p1UlFnYWE2TTNnbmtTZU1nODlVNy8vY0FpY2lFWUxyWGNM?= =?utf-8?B?TllYY3N4bElXUHJlS24vTnVJK0J1ajBvTFlIZEYyNStzbWhjbFdMakpEWWp3?= =?utf-8?B?WUpJaUpha2I4WlFDVUw4SzZjNjhxeWFKcFhMWHJ1dG1oVFlYRjlKanZOdjlx?= =?utf-8?B?YWRORHdDWWhsY2VmNERyN00rLzNHbDVQYUEwcDMxTnQzejFMdW5RQzg3TnJM?= =?utf-8?B?MFROR0ZURWZVd0FsMEY3WGpVRjVzdEhnZkIzeEFuaW1tWFVXT3J2R2xRK2t6?= =?utf-8?B?K0c3VjVuUnhJS1U5dGtQQk1TbzlDM3Q0V2FaZXNOOXQrYm02bVIvQzNPWElV?= =?utf-8?B?aGwzcm9yZ20wV2dsaHNLRkVKNlk1c2NIa0FQU3prZVB0ZUpkVmd1ZnMzUGov?= =?utf-8?B?dStHOEl6aWpMS0dGbGkwMTZWNko0bHRLSDQ4M2kwV0xuOUNXZGEva05LL1Fa?= =?utf-8?B?a3JuNlBGMEVETTBjdzZSSStGZXBZTkhhekQvS2JtTU1jS2hUb0k4VmJ2TjV1?= =?utf-8?B?YVU5L1RVOFEvdS91Z29Qc1g2VjNEd3h5WlF6OFFPUVBwMjJ4V0NlQVB3aDd2?= =?utf-8?B?U3VPVWxYbVZEOXo4TVUyL0MxK2pzNGV3V1RtOE1HWUVpcGE3bHllSnpHU0VE?= =?utf-8?B?cUtlK01ocWhvYTZoQ3UybTBLU3dkZmFWU2lqVkdKY083SmVxSG1xdDgyV0Qw?= =?utf-8?B?M3ZhV1UwZTFEZEdmRkdZT0dXdVFPR0l3NjB5Zm1BSUdGejY2UG1jUnJGMmJN?= =?utf-8?B?UTZpOVZoMTdhQ3kyTEIwSXc2V1VOdEVWVW5BM0RSTk5jeTMxOUFiQys4SHpL?= =?utf-8?B?U09ONDg4WWRJKzRlU0x5TkVzVzQwM0xreEZwRHIrZFJ0NXBoQVA1bU1aQ1I2?= =?utf-8?B?S25zcS9ka0hSN2VkOTh3R0hJRzh2MHpaS0x2QlNCOWFjSHVJZkFRTzdUSEpW?= =?utf-8?Q?543+6Ecxmg522JGsdR5hJ7F8FKIrQrtt7pEvDHx?= X-MS-Exchange-CrossTenant-Network-Message-Id: e38a005e-3a21-4f9d-bd33-08d98418a4a2 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2021 13:46:02.7508 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Te1qb8Zi54rg5CYCwdr+qwL2yc7NWrn4EkcVzMeFyXfx1OTlKkEtWZzQW3zwfJly66WchowVaBlxZONQg4OE+Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5111 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support unequal number of RXQ and TXQ X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/28/2021 12:08 PM, nipun.gupta@nxp.com wrote: > From: Jun Yang > > The existing forwarding mode configures the total number of > queues as the minimum of rxq and txq, so eventually the number > of txq are same as rxq. > However in some scenarios, specially for flow control the > number of rxq and txq can be different. > This patch makes the txq and function of rxq for all such > scenario instead of keeping 1:1 relationship between the two. > Hi Nipun, I expect more code exists that assumes Rx queue number and Tx queue number is equal, did you able to test unequal queue numbers with below change? And can you please describe your usecase more, is the device has uneven Rx/Tx queues? > Signed-off-by: Jun Yang > --- > app/test-pmd/config.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index f5765b34f7..7e17f233ba 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -3000,8 +3000,6 @@ rss_fwd_config_setup(void) > int end; > > nb_q = nb_rxq; > - if (nb_q > nb_txq) > - nb_q = nb_txq; > cur_fwd_config.nb_fwd_lcores = (lcoreid_t) nb_fwd_lcores; > cur_fwd_config.nb_fwd_ports = nb_fwd_ports; > cur_fwd_config.nb_fwd_streams = > @@ -3038,7 +3036,7 @@ rss_fwd_config_setup(void) > fs->rx_port = fwd_ports_ids[rxp]; > fs->rx_queue = rxq; > fs->tx_port = fwd_ports_ids[txp]; > - fs->tx_queue = rxq; > + fs->tx_queue = (rxq % nb_txq); Is this assumes number of Rx queue is always more than number of Tx queue? > fs->peer_addr = fs->tx_port; > fs->retry_enabled = retry_enabled; > rxp++; > @@ -3253,7 +3251,7 @@ fwd_config_setup(void) > return; > } > > - if ((nb_rxq > 1) && (nb_txq > 1)){ > + if ((nb_rxq > 1) && (nb_txq > 1)) { > if (dcb_config) { > for (i = 0; i < nb_fwd_ports; i++) { > pt_id = fwd_ports_ids[i]; >