From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id EE0761B21A for ; Fri, 2 Nov 2018 11:39:40 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id D49286A3; Fri, 2 Nov 2018 06:39:39 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 02 Nov 2018 06:39:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=F1P7gxX+BwlENu5v5wEhvKIic5dU6Jaf7V3bn9E6c8U=; b=E8mEOL+Bkvvs Zm0hzAa6AqKVCIZ688ql2zB35p4h/koXITRV0xNwRP99I40fntp5FLUKrLnphwgv uG4GkCZbtVD+yCZvtfe1yC2lInsaLWIDmtLzK7MvQhhTNXDM8D/XQWOuqZc2Xd6z lGui7GgAKMyYIk55dWKHizbNuh6P0xk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=F1P7gxX+BwlENu5v5wEhvKIic5dU6Jaf7V3bn9E6c 8U=; b=y4gUlgWhwipCB2Q3ZC37BPmpjgVweBAC4HGs+W90N9xx2plshguXfJteM 5WDNb20XArgdebhTG16MJFcT3RfKwMJpPjDSK0epm47jdYwLvuAtO0Lnom6vDB/5 zdK2q/9rYM4mH7jEcS/DjRWQrlWhSAe400bh/EAkOflNA9nyrMCJ+yBfWRw99sk9 rA3WVMSchS9txxJb9sdbtTsDbuO5AsRhZz02SFeb/wJQCOxOYS9gLbrj1uwMDNnC hS4f5wYVylXXHYS/16SXtq2XjSDAQW/jxmgZlCe5dNDYFCS5VzeR9OBGDQLYqzpv SvMd+7hJSoHgxKiEmGAwspnrsmtQg== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 49F13103E9; Fri, 2 Nov 2018 06:39:38 -0400 (EDT) From: Thomas Monjalon To: "Zhang, Roy Fan" Cc: "dev@dpdk.org" , "alejandro.lucero@netronome.com" , bruce.richardson@intel.com, ferruh.yigit@intel.com Date: Fri, 02 Nov 2018 11:39:37 +0100 Message-ID: <2529427.7ESO8GYSS3@xps> In-Reply-To: <9F7182E3F746AB4EA17801C148F3C604334D4B41@IRSMSX101.ger.corp.intel.com> References: <20181101121009.86287-1-roy.fan.zhang@intel.com> <2772595.iFPTlCQAWG@xps> <9F7182E3F746AB4EA17801C148F3C604334D4B41@IRSMSX101.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] bus/pci: fix missing case for virtio-crypto X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Nov 2018 10:39:41 -0000 +Cc Bruce and Ferruh 02/11/2018 11:01, Zhang, Roy Fan: > Hi Thomas, > > You are right, the problem can happen with any PMD falls into RTE_KDRV_UIO_GENERIC and RTE_KDRV_NIC_UIO driver type. As riginally rte_pci_read_config() only covered 2 out of 4 possible driver types' . > > The patch was submitted for fixing the Virtio Crypto Initialization Segmentation Fault problem introduced in 18.11 RC1, and it did. The problem is I don't think the patch will fix all problems of rte_pci_read_config(). Even I added RTE_KDRV_UIO_GENERIC type into the switch case there is a remaining RTE_KDRV_NIC_UIO type I am not sure where to fit due to the limited knowledge. > > That's why I write the patch title like this. I hope someone else with better bus knowledge could submit a complete fix patch. > > Best regards, > Fan > > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > Sent: Thursday, November 1, 2018 1:35 PM > > To: Zhang, Roy Fan > > Cc: dev@dpdk.org; alejandro.lucero@netronome.com > > Subject: Re: [PATCH] bus/pci: fix missing case for virtio-crypto > > > > 01/11/2018 13:10, Fan Zhang: > > > The recent change to rte_pci_read_config() caused virtio-crypto device > > > initialization always failed as it has a RTE_KDRV_UIO_GENERIC driver > > > type. This patch fixes the problem. > > > > Hi Fan, > > this issue is not related at all to virtio-crypto. > > It can happen with any PMD, right? > > > > In the title, we should mention UIO generic driver. > > > > >