From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id E0C342B92 for ; Wed, 29 Aug 2018 16:09:01 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Aug 2018 07:08:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,303,1531810800"; d="scan'208";a="84367492" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.252.19.107]) ([10.252.19.107]) by fmsmga004.fm.intel.com with ESMTP; 29 Aug 2018 07:08:50 -0700 To: Bruce Richardson Cc: dev@dpdk.org, dpdk@stormmq.com References: <4694d02efdd764a45e84d2da00f1dff284694963.1535543250.git.anatoly.burakov@intel.com> <20180829123505.GA39260@bricha3-MOBL.ger.corp.intel.com> From: "Burakov, Anatoly" Message-ID: <252cc35c-270a-5c29-8e4f-ba07234cbabb@intel.com> Date: Wed, 29 Aug 2018 15:08:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180829123505.GA39260@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/7] pci/vfio: improve musl compatibility X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2018 14:09:02 -0000 On 29-Aug-18 1:35 PM, Bruce Richardson wrote: > On Wed, Aug 29, 2018 at 12:56:16PM +0100, Anatoly Burakov wrote: >> Musl already has PAGE_SIZE defined, and our define clashed with it. >> Rename our define to SYS_PAGE_SIZE. >> >> Bugzilla ID: 36 >> >> Signed-off-by: Anatoly Burakov >> --- > > Would it not be easier to just do? > > #ifndef PAGE_SIZE > #define PAGE_SIZE ... > #endif Sure, that can work. -- Thanks, Anatoly