[dpdk-dev] [PATCH] ena: icc fix compilation warning #3656

[dpdk-dev] [PATCH] ena: icc fix compilation warning #3656

[Ferruh Yigit]

 With (ICC) 16.0.2 20160204, getting following warnings:

 .../drivers/net/ena/base/ena_com.c(492): error #3656: variable
 "flags" may be used before its value is set
 ENA_SPINLOCK_LOCK(admin_queue->q_lock, flags);

.../drivers/net/ena/base/ena_com.c(1971): error #3656: variable
 "mem_handle" may be used before its value is set
 ENA_MEM_ALLOC_COHERENT(ena_dev->dmadev, len,

For both warnings the variable value is ignored, so there is no defect.
To comfort compiler warning, a initial value provided to variables.

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 drivers/net/ena/base/ena_com.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ena/base/ena_com.c b/drivers/net/ena/base/ena_com.c
index f886760..a21a951 100644
--- a/drivers/net/ena/base/ena_com.c
+++ b/drivers/net/ena/base/ena_com.c
@@ -478,7 +478,7 @@ ena_com_wait_and_process_admin_cq_polling(
 		struct ena_comp_ctx *comp_ctx,
 		struct ena_com_admin_queue *admin_queue)
 {
-	unsigned long flags;
+	unsigned long flags = 0;
 	u64 start_time;
 	int ret;
 
@@ -1964,7 +1964,7 @@ int ena_com_get_dev_extended_stats(struct ena_com_dev *ena_dev, char *buff,
 	int ret = 0;
 	struct ena_admin_aq_get_stats_cmd get_cmd;
 	struct ena_admin_acq_get_stats_resp get_resp;
-	ena_mem_handle_t mem_handle;
+	ena_mem_handle_t mem_handle = 0;
 	void *virt_addr;
 	dma_addr_t phys_addr;
 
-- 
2.5.5

Re: [dpdk-dev] [PATCH] ena: icc fix compilation warning #3656

[Thomas Monjalon]

2016-04-06 13:17, Ferruh Yigit:
>  With (ICC) 16.0.2 20160204, getting following warnings:
> 
>  .../drivers/net/ena/base/ena_com.c(492): error #3656: variable
>  "flags" may be used before its value is set
>  ENA_SPINLOCK_LOCK(admin_queue->q_lock, flags);
> 
> .../drivers/net/ena/base/ena_com.c(1971): error #3656: variable
>  "mem_handle" may be used before its value is set
>  ENA_MEM_ALLOC_COHERENT(ena_dev->dmadev, len,
> 
> For both warnings the variable value is ignored, so there is no defect.
> To comfort compiler warning, a initial value provided to variables.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks