DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
	dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>,
	david.marchand@redhat.com
Subject: Re: [dpdk-dev] [PATCH] devtools: check commit log fixes syntax
Date: Wed, 30 Jan 2019 13:22:37 +0100	[thread overview]
Message-ID: <2531806.X9HWgi9ZUd@xps> (raw)
In-Reply-To: <20190130113527.GD157424@bricha3-MOBL.ger.corp.intel.com>

30/01/2019 12:35, Bruce Richardson:
> On Wed, Jan 30, 2019 at 12:31:21PM +0100, Thomas Monjalon wrote:
> > 30/01/2019 12:29, Bruce Richardson:
> > > On Wed, Jan 30, 2019 at 11:15:44AM +0000, Ferruh Yigit wrote:
> > > > On 1/29/2019 8:41 PM, Thomas Monjalon wrote:
> > > > > 29/01/2019 16:30, Ferruh Yigit:
> > > > >> Fixes line commit id length defined as 12 in fixline alias:
> > > > >> fixline = log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %ae'
> > > > >>
> > > > >> Check if the Fixes line commit id length matches the defined value.
> > > > > 
> > > > > This check was missing on purpose, in order to not be too strict.
> > > > > I think it's OK if the length of the SHA1 is not always the same.
> > > > 
> > > > That is OK, if we don't want to be strict on this, I will update patch as rejected.
> > > > 
> > > I think having this check is still good. It's not enforcing the rule, just
> > > warning when violated. In 99% of cases this warning should be fixed IMHO,
> > > especially if you guys are fixing these manually anyway.
> > 
> > I don't fix it manually. I think SHA1 length has no importance.
> > Why do you think it should be fixed?
> > 
> Neatness and consistency. Since we provide on the site the expected syntax
> for the fixes line, why not check for its use?

OK, I'm not against the check.

      reply	other threads:[~2019-01-30 12:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-29 15:30 Ferruh Yigit
2019-01-29 17:34 ` David Marchand
2019-01-29 18:07   ` Ferruh Yigit
2019-01-30  9:58     ` David Marchand
2019-01-30 11:17       ` Ferruh Yigit
2019-01-30 11:24         ` Bruce Richardson
2019-01-30 11:27         ` Thomas Monjalon
2019-01-30 11:31           ` Bruce Richardson
2019-01-30 12:23             ` Thomas Monjalon
2019-01-29 20:41 ` Thomas Monjalon
2019-01-30 11:15   ` Ferruh Yigit
2019-01-30 11:29     ` Bruce Richardson
2019-01-30 11:31       ` Thomas Monjalon
2019-01-30 11:35         ` Bruce Richardson
2019-01-30 12:22           ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2531806.X9HWgi9ZUd@xps \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=qi.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).