From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C737AA0546; Wed, 7 Apr 2021 00:40:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4D6AA407FF; Wed, 7 Apr 2021 00:40:08 +0200 (CEST) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by mails.dpdk.org (Postfix) with ESMTP id EE1EB4069F for ; Wed, 7 Apr 2021 00:40:06 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 3D1EC580984; Tue, 6 Apr 2021 18:40:05 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 06 Apr 2021 18:40:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= O+B+fXhcwigcYtCr2W4Qbmz2QvFACviAY0ewF3RpkHY=; b=rniyNsdHTZ8R+cjo GRsLhtLHZBH2TN/BpdTaDRsU4IfhmKz5xv3oDdzj7J73RZbLPUcOlnVcu76xe2fH bDhl6ANZMM8ZqmjRYctFMdKFkHTHcULNlsSaOZ1ZESGw8cSaPMDuDgVl7dEQR9qr 4MGqEVu/6wUmNpMsgxwz4UQ2ckG/4KV7dWOz7zJljCQlsVobIy1h9acgPL+KD5l4 WL23gUdyX5SzbYrT/EYUNbvmpiPf8s1Mye8RoTM4W6FJ8zOP02UfgASgJcnQ19J8 4eKYD37LODeZjZMtrZpaxu8cV0sE6ggAQ6xSMkRQO/xRayVn+LaDPPeDZwp5F6Q4 vDb+6g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=O+B+fXhcwigcYtCr2W4Qbmz2QvFACviAY0ewF3Rpk HY=; b=D0huPuh6ANz/20/DdonmBIxLX2TcAtcE2gSSUrnVXEqFPauZrJW/fFKtY /02CsqHt2uuL7sKV3mUV13ZBBpX4LbPeePVPkcxX2JZl9oycWE3JJr7Er8clzjOZ 61iMY4JKsgWit3DgLcG5Hltyp8mfYz03srMLSGVU3+JOF50svf6gsFAWPOhDzr0e q8fCeZZN1/PV36wCNA7wrw1c+HZmEO09EE1oGEJJgkn3t3GJ1RdQ0QjJyHbQOVZ5 VuHTCAlJEI4luMclL8xgUS7pqQIbJciWUxWtKC4wHxBV8ZrXdz2vlSvWA+vmfzQA AiavhR77DEIyQMxz+Apqr6LpZnGTQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudejiedgudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4A7F9240057; Tue, 6 Apr 2021 18:40:03 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: dev , Bruce Richardson , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Ray Kinsella , Neil Horman , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko Date: Wed, 07 Apr 2021 00:39:59 +0200 Message-ID: <2532967.nAU1F58lTY@thomas> In-Reply-To: References: <20210406163231.19663-1-david.marchand@redhat.com> <4303766.JfoNgE5a7G@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] build: list symbols exports in a single file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 06/04/2021 22:09, David Marchand: > On Tue, Apr 6, 2021 at 8:53 PM Thomas Monjalon wrote: > > > > About the title, it is not a single file but one file per lib/driver. > > I think it would better convey the idea by saying "remove .def files". > > Ok. > > > > > 06/04/2021 19:59, David Marchand: > > > Rather than have two files that keeps getting out of sync, let's > > > annotate the version.map to generate the Windows export file. > > > > > > Note: Existing version.map annotation achieved with: > > > $ for dir in lib/librte_eal drivers/common/mlx5; do > > > ./buildtools/map-list-symbol.sh $dir/*.map | > > > while read file version sym; do > > > ! git grep -qw $sym $dir/*.def || continue; > > > sed -i -e "s/$sym;/$sym; # WINDOWS_NO_EXPORT/" $dir/*.map; > > > done; > > > done > > > > This patch keeps the exact same behaviour, right? > > I checked by sorting/diff'ing previously committed .def files for EAL > and common/mlx5 with the newly generated ones. > No difference, once aligning the mlx5 version.map. > > There is one change in behavior. > I thought as exports.def being a subset of the map files, and this > patch enforces it. > It seems there were some tries at going the opposite way, looking at > the comment in check-symbol-maps.sh. > But looking at the current common/mlx5 state, I don't see this as a > requirement (Linux and Windows share the same interface). > > > > There are a lot of symbols in EAL and mlx5 which should > > be exported for Windows too, but it is open for future fixes, right? > > Not sure I get this question. > > We have exports missing in EAL for some series posted on the ml > waiting for merges. > I suspect some recent merged changes have issues too (but did not check yet). > This current patch does not address such issues and we need fixes > afterwards if this is what you mean. Yes this is what I mean. I wanted to make clear to people in Cc list that some fixes are required as follow-up: some symbols in EAL and mlx5 are missing for Windows.