From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id E7F548E69 for ; Wed, 25 Apr 2018 19:07:30 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 73F3421497; Wed, 25 Apr 2018 13:07:30 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 25 Apr 2018 13:07:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=fQ8E7KOMDOAsEcEzW5tEZ2EVrw eor03pgAqyCINcMzU=; b=AM7AI3czpl76izQUQvEC/9GsEf/E94F1PS6qEnRKw8 7AlxGMaUIX93CwtIZ/dc0AnrOZe2lIXtFZ2h2Ni444hQpt4RaLTPDzyJXBnCD8K4 XTWG8I/ffQqlapq/muPTlLtZY7onZlynHyWdySkNpLaAK3wYh0EGrzhfVAc8u3iT M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=fQ8E7K OMDOAsEcEzW5tEZ2EVrweor03pgAqyCINcMzU=; b=UvycLRpqaW8nifiWrlm6vQ ST7Ib6+bc5CE3P9x+SAL8yH+oEYQJqXWIAhT4HNyUORmwE8EeJNzNOth1Hduvkgm ySeab8Kq9pPIk3e3Dm0SE8dBMfNBSrqaD36pEGhtUt2dNUaQYZMxZhlXjLiePkFU NMzM9NrFPWZBwj9oLLa2srjoN2Xd1Td749ObK1bsSPUVxS9c21Gueiv1yTwLtcZ9 0cCQb/pIhJpFOcSOXCI992xs5jDnhgc+iA6a7/ag3EXmmdh6uQ7Dkmw/2fxWmupW duLiOoeX+iIiA4aXwlB8rq0Edpx8VuHITjXDstuvT0NzWnVB03MaMWkzNVK8sHDA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A1C16E4B94; Wed, 25 Apr 2018 13:07:29 -0400 (EDT) From: Thomas Monjalon To: Phil Yang Cc: dev@dpdk.org, nd@arm.com, anatoly.burakov@intel.com, herbert.guan@arm.com Date: Wed, 25 Apr 2018 19:07:28 +0200 Message-ID: <2533962.DYNjplGVFj@xps> In-Reply-To: <1517883698-12921-1-git-send-email-phil.yang@arm.com> References: <1517883698-12921-1-git-send-email-phil.yang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] test/eal_flags: Optimize memory flags test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2018 17:07:31 -0000 Hi, Your patch has been forgotten for months. Do not hesitate to ping if no reply. I have a question below. 06/02/2018 03:21, Phil Yang: > --- a/test/test/test_eal_flags.c > +++ b/test/test/test_eal_flags.c > -#define SOCKET_MEM_STRLEN (RTE_MAX_NUMA_NODES * 10) > +#define SOCKET_MEM_STRLEN (RTE_MAX_NUMA_NODES * 20) Why the above change? > @@ -1138,10 +1138,11 @@ test_memory_flags(void) > - int i, num_sockets = get_number_of_sockets(); > + int i, num_sockets = RTE_MIN(get_number_of_sockets(), > + RTE_MAX_NUMA_NODES); > #endif > > - if (num_sockets <= 0 || num_sockets > RTE_MAX_NUMA_NODES) { > + if (num_sockets <= 0) { > printf("Error - cannot get number of sockets!\n"); > return -1; > } >