From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <shreyansh.jain@nxp.com>
Received: from NAM02-CY1-obe.outbound.protection.outlook.com
(mail-cys01nam02on0069.outbound.protection.outlook.com [104.47.37.69])
by dpdk.org (Postfix) with ESMTP id 54D472B9B
for <dev@dpdk.org>; Fri, 20 Jan 2017 06:01:55 +0100 (CET)
Received: from DM5PR03CA0024.namprd03.prod.outlook.com (10.175.104.34) by
BN1PR0301MB0739.namprd03.prod.outlook.com (10.160.78.146) with Microsoft SMTP
Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id
15.1.860.13; Fri, 20 Jan 2017 05:01:53 +0000
Received: from BN1AFFO11FD017.protection.gbl (2a01:111:f400:7c10::170) by
DM5PR03CA0024.outlook.office365.com (2603:10b6:3:118::34) with Microsoft SMTP
Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id
15.1.860.13 via Frontend Transport; Fri, 20 Jan 2017 05:01:53 +0000
Authentication-Results: spf=fail (sender IP is 192.88.168.50)
smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed)
header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com;
Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not
designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com;
client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net;
Received: from tx30smr01.am.freescale.net (192.88.168.50) by
BN1AFFO11FD017.mail.protection.outlook.com (10.58.52.77) with Microsoft SMTP
Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.803.8
via Frontend Transport; Fri, 20 Jan 2017 05:01:52 +0000
Received: from [10.232.14.39] ([10.232.14.39])
by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v0K51nFe003427;
Thu, 19 Jan 2017 22:01:50 -0700
To: Ferruh Yigit <ferruh.yigit@intel.com>, Hemant Agrawal
<hemant.agrawal@nxp.com>, <dev@dpdk.org>
References: <1484679174-4174-1-git-send-email-hemant.agrawal@nxp.com>
<1484832240-2048-1-git-send-email-hemant.agrawal@nxp.com>
<1484832240-2048-7-git-send-email-hemant.agrawal@nxp.com>
<55ece068-d1b9-acb1-d279-a6da5e594614@intel.com>
CC: <thomas.monjalon@6wind.com>, <bruce.richardson@intel.com>,
<john.mcnamara@intel.com>, <jerin.jacob@caviumnetworks.com>
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Message-ID: <2533f939-d037-d2fa-719a-abb4f989e7d2@nxp.com>
Date: Fri, 20 Jan 2017 10:35:17 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
Thunderbird/45.6.0
MIME-Version: 1.0
In-Reply-To: <55ece068-d1b9-acb1-d279-a6da5e594614@intel.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-EOPAttributedMessage: 0
X-Matching-Connectors: 131293621129561724;
(91ab9b29-cfa4-454e-5278-08d120cd25b8); ()
X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI;
SFV:NSPM;
SFS:(10009020)(6009001)(7916002)(336005)(39450400003)(39860400002)(39840400002)(39380400002)(39410400002)(39400400002)(39850400002)(2980300002)(1109001)(1110001)(339900001)(3190300001)(76104003)(199003)(189002)(377454003)(51444003)(24454002)(33646002)(305945005)(23746002)(54356999)(230700001)(77096006)(76176999)(38730400001)(50986999)(8656002)(8676002)(81156014)(6666003)(31686004)(5660300001)(47776003)(81166006)(31696002)(229853002)(86362001)(85426001)(65826007)(68736007)(626004)(93886004)(65956001)(92566002)(54906002)(64126003)(83506001)(65806001)(4326007)(2950100002)(8936002)(53936002)(104016004)(2906002)(106466001)(189998001)(356003)(36756003)(97736004)(50466002)(5001770100001)(105606002)(4001350100001);
DIR:OUT; SFP:1101; SCL:1; SRVR:BN1PR0301MB0739; H:tx30smr01.am.freescale.net;
FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en;
X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD017;
1:73eoB3ZezK+ET51/cSrRXURp8s1lW05kccoqy3rJcz95dN4l+VHC7fB5yjDWeEaYPbc8RXVy330w+ok1NE9/y9BSJsdTLVOz9+GSrtXDGWsccwYU27LLyTBhgNzSvpzmz5UdN5rSi4zj537pFE6tvwQHnffXxQWzJxuFrM43F6EAkbRlAGy+V0M2MTdoalzay/pThLlBXVVmLaUrBjkJY3LyZ4EvCYupRaBuplySqjyi6iHNHwGL7KjuMNx0793BZaVvQ7JdSYaHIm/oaynxSHfFC6LgPo+PIO65pr75MpdmyKgFCUxcTvxOSsQhjl7r7W2llD4kvzCs1Blyhel5iJuKeEuNrOczcL56a/OQkmv/5/8Feedd+fZE5Dv//0vgBRobRa8L447HbEi8NJf9pt1vy3AnAvKDBefGNAj7qn55ISdSHeTQQ9xHCmvETEAJnQ10oyH708dsMFWY5XDhwuBblHwmY1k5XE14iS5u4hl+fk95Ee8rP/+1mFIW3bnCrRmMRp8ZKvCQl0bPUg+8jZgs7XJG+ZdH+HX6gnnWvm+euLqg9G5P2JRdLmCeLpRbJRD63IPHe18K4kwcii2xf/1HXFyv7JjmfXGT5GeA4Y0Lj6T92eHOk/p+6Cx7uRnr
X-MS-Office365-Filtering-Correlation-Id: dbd98179-9f93-470c-651f-08d440f17328
X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001);
SRVR:BN1PR0301MB0739;
X-Microsoft-Exchange-Diagnostics: 1; BN1PR0301MB0739;
3:+/NMx2nKLEJ0Bu7NVku/c8r5Z6FQSQWj2rouE0VVGeakqbaQvghFElaRDR/qe8xgJAJ7dwk3aA/g21p77J+DghbgWgBaIwVqV1KHBjrIMRcbEL9p6pXXUVOe1ElhKkZlTDU+CxZgZEcB/pqBq5RDjI7DGN3BA1CC2VaghSFkzsBgVuf4y9wRSjwFIPTcsFRfcYWcMnc880BH4WZKRn1gfdZcLV6n1Ksq/MLb8XVNaPzK/lWn5hRfYECOTEmkYjuJPVpwZI73g8c20o09JC8hiHuoZ3w1MmHmtQ2KSrpk3sk3EnNjjV++oXgsE4zaMiO+sRPWfPjOTal5mutaKFWikViY0q5Q7TFmbr71VxiGDkEBcMglLpl5/9NKKVLv6lAA;
25:pmN+aHoX8dAGjHHqclnUyYh6TkyhVvT9Y73BGKhtN45hQAzYLGJbrhBuXcOYPO13NaQL4gMiJKRUr6ZBvlEdNxkwZLiFt0qdd+HM6HuRxYentIXVq6MTv+xp8FHRO5IkWfqoRaL9nnrmoKtFmMRNBWOVdZn42IcFy+K3Hi7IC5x4zKhIeUVYh/MVByQM+IwINzu4xNGAZxdy4Z5l+e2Eg2KpzAUqAoqDpsKnxJxWUBzWStRSSFFLDqqqps7Mx2N1jbpmKAo8mUIjCAO/6JhW8QCSajElm+1aABka3Rf3gYPxjcuYxL6IzkI5ha13aeBSZw3OuK/psrvlcqc33KHK2lakZwqcDhiyoz/klYzSLoSVtNODLTZoIJLkN7vuuLwJe+o1yMJP868K4cBvpxi9CRyS8kUgCb1d0n4/3FHT7MpP8G2x7qMbB5gLPMfmbjWT3eG+oOI09YSL47mzIe6NpA==
X-Microsoft-Exchange-Diagnostics: 1; BN1PR0301MB0739;
31:MkRUQ0fawIX0xFhzkZmQCtY5YSTEq7cEPg4IE9NVwCgBHTxB2tlfpffDMuUy44+PaFw7sPDtReNtbNSOFwO+HlPSFUd25zGKLPEG1qz8AV5Qm9YUy3gmnzNeZJfsSDpVTKnltIubX1z36M7gccbISp5JeFpi7cT1R/1dZhl173F5Yuej+EQrBHyds4crMdDfOzVlGVQA+kLxkdycxPmI7MPn09jgR3OH8IeIATiX6upMJsi+vv59+3rMt1gErBsSQiREfi8aKkj1w25ThXM5AxveqGcemHCsA3bplss4bPs=
X-Microsoft-Antispam-PRVS: <BN1PR0301MB0739889495E500D75CBC4DBE90710@BN1PR0301MB0739.namprd03.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:(185117386973197);
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0;
RULEID:(6095060)(601004)(2401047)(13024025)(13023025)(13015025)(13018025)(13017025)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6096035)(20161123561025)(20161123556025)(20161123563025)(20161123559025)(20161123565025);
SRVR:BN1PR0301MB0739; BCL:0; PCL:0; RULEID:(400006); SRVR:BN1PR0301MB0739;
X-Microsoft-Exchange-Diagnostics: 1; BN1PR0301MB0739;
4:+GIx8aGf1REG4Bz+0tPVxQBslehODWYNVZfW2O+jTW8tWbWOfDaKbtTtnPmoFFQfxhaBLoNpVKIZqWZ+PsdUZSAwBQdza7Pvcas2ugl1kRvK0IpqaJb7x0YR/VVZDwssENy8xfWOg1gw4UKifs1NePSCrCgM08Yy6B2zcqV/CInOnkP1xGcTud4lCKg+UouhbtEcqiZWPcJBlL9TSBrP7wU9J9tTO6rE/nvh8hCAP2p9hL7FMFXcgNGQ1VvXJR0DjmUTlSgph7AvPiS6QY0H4kIoByFNWMdYRNYy0bSAPkQzv6XWC1JV2iFZ2xGsbIe2dkQKHazA+Pel2s0zB4OzBlA5kXUwfBTNVA859kl1ylXQqVLXnvuTRp01nTgZ+DjGIX7E4n4uPPnWf6U8zwwszqHlb14k0xfG/zgeVaUOqIyTaWsnvwmydNaqP85KG36xVemIox2LjX16unD6WGGkNbiTpT6QscADP6uCRuHzvrT7SeVSEOSGW7J9vSmBRpjCTPPO9MaBhhOWdqnHNQZJUrdZkZ4aL0BvtKAuEwakQzZUE5olzy3gLCnbZMtkkhugyIxy6v/ydEgx1QM5P6zO8yw6+elx4Wf38t2QI9hkaKbyNlVeEqslIvFmv554v01u4aWKY7VzQBX7zq60CIX5yr97PfjKMOtXib7kDlMu3/CN9RX1OxYwyjYg5LNEZ91EIpuUXb8gaZ9KdeDKaz9q/exF1rGe6wOoQA5Amdbgb6BjyY8GiBc8+cw0BJnNbSWH
X-Forefront-PRVS: 01930B2BA8
X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BN1PR0301MB0739;
23:FL0984luVfL40oR0HQAXJWU5/DqRab92DyX?=
=?Windows-1252?Q?RJUSqd+vajup9jmdRErv1v3ojVAhx87lFKcCSmGkw0h77mQA7NMSh08E?=
=?Windows-1252?Q?aqu3z8GTJquN/DFfwE44CYCmKTQxHM91dFhpFiPEG9aUot8Rz/VjNp76?=
=?Windows-1252?Q?lz1PzUaQ/7UUWrDmOrC2XOGFLnQxM3ks/LO96b4pB9jD7mArBoAxfRfH?=
=?Windows-1252?Q?ZLjtxCMcF3cpks5n0zf5kYNEhUWM9HnqgKmftbOZyxFHIaanYXVYCQuX?=
=?Windows-1252?Q?tZ+Ao/qBjgqD9xM+46g+/gpeiO7rHymKoHxqb5MMCy1ePAbxU+Jub5ku?=
=?Windows-1252?Q?VNK/SryeihTd2qehKL0mQpanYGwu64sIywdTT4QgwcNw7vHjs4+8uUaO?=
=?Windows-1252?Q?Ttijb2TQvl4UZqV//BGUQCDVbsCJOZ//fVFuYsT2f4H/cvcNxJLutfg5?=
=?Windows-1252?Q?Kg1rpvRgz1dXCTd7qUNMyzQZzraVlu0o4Gcj8EEH8OnKft4qRzArPg5/?=
=?Windows-1252?Q?kry3a0e/LZAI6I8gOmAeiIrrlSBaIztEdJcKnFu6BaxTdJUI+YFhHvDX?=
=?Windows-1252?Q?m5TSGVXRYA2s3CV1t3/GErTidZ2l9muJ0jkQMAig40DJNv62tVmXkNYh?=
=?Windows-1252?Q?G+DuAuRS/LsUOC/IzE8qZGu3DwLNh9bF08Lr9Y7keuYBs0TCBu69vfs5?=
=?Windows-1252?Q?bIOIgzBo82Y7j1+QfawsbgKkX5KNsbm3qSPBPwUYIXb21udAMzb6MP6C?=
=?Windows-1252?Q?wL0p9tETNmJ0G5D3mVNwLXlVC4MOS0d+OczPAH0EVIU3cavhjkNsBmlm?=
=?Windows-1252?Q?FONdJuLh+ah9dIUN1gIcryshkRjttwLztvXkSRjBNpQoJ4u+0qQWewpF?=
=?Windows-1252?Q?EVON2k2XAVfG4iMJpUusZbgC37i7Fs4xouMko0nmwWFdCSFZFvEC1HHM?=
=?Windows-1252?Q?WgnYQEMOjP3CU5bjQosS7bcomKJFdTlAOh90dINX69wnDUSWFOlZlRj+?=
=?Windows-1252?Q?vyvZ2BgZB6eMUF6oaP4+za9CoIwFoMV4p/oyyMVN8eQp7TMWgxJFRRb2?=
=?Windows-1252?Q?6ezIFKnF3QiZzCfusalyWRCYgPKzG1fQUfDzCoQmbDLEtYCDE58FHcf+?=
=?Windows-1252?Q?6RysmJjWkRNYSAh9aHSG7v9urGAwsXEaV9WhvHOuv1oIcXIfVbf02+Ko?=
=?Windows-1252?Q?mw+DALwNWP+Fdn2oT/g3aOHL98t3lH/BZHzm4OwZP0770QrPmeCTupc7?=
=?Windows-1252?Q?H9Uqc5oylAXfESMfYDjj1EABOPS3UAPUq9bxB9jth0b2VwmEEu8uKI1D?=
=?Windows-1252?Q?RMXF2AdkIPs6MQJcxIn00KRL/lapfZhBXpQ6QH09gLscHxa11ntF7Y6p?=
=?Windows-1252?Q?GmPq/KzmMabNZWcD7pgt0DNfpk7wmnFwCw64JuI/go9xxzEwSdFMPGs8?=
=?Windows-1252?Q?IJKR7FY1Z//rZQA5BGdVHbVaeNjRhyHfq7P+nWdvr6P4zbMQke9yOQhX?=
=?Windows-1252?Q?IFF6lZkzIok28PV+8cxF1LmnZU0W1zT4GX4it/dYtONR2eCR+kX3QM57?=
=?Windows-1252?Q?EvRobissJhJBHqrtFlghrcLZJBdc5+Rhe+mVzVO+2gYWALbxXBRkLjbC?=
=?Windows-1252?Q?kVCyIOYQZYSn8owdadwJp8cueG10tfr6wx6i/8Qm/ALhPOKwSuDsMos/?=
=?Windows-1252?Q?OlXMX2BXBU5ettvRywjauP3R657sj0g6iV1+aRqpsjwDSMTdHO1B4yEt?=
=?Windows-1252?Q?Fug6U+jykZP16UlUS7g=3D=3D?=
X-Microsoft-Exchange-Diagnostics: 1; BN1PR0301MB0739;
6:woTrFyqYePqFvYZFy+1iCJGH2zhNn7M/hz8bwIrjWIwINyZ74ZG7bjhGgI1ZvQqWkejp/0ErgSuz2Im/cZlRhX3vAFnrTOLRFZvOewbN2wYLArjLEuwK3MOCfKyyBsKFOOc5JY6U7KsRAbvulrxT1SsI8WoR72colTtY4BTQy8bGIDYkX9UVi9f5lgnykJU+W4WDU1UkT0+eXLfIEsRO0aF21ag6wvGCxCyP+zk9ENWSusEUXqRAilr2eorVkLLeiOZVyVxJZP3U4mkaAr7uyuUqIU1N1qb2Oo1zRdjefaRW0h68Pu8+Yj+1WEbnPKb0YiON3b8Es2K/qX7qTpTIG+0v+ROVwlWS40Dlaj+A8HI49C7nUHz8aiT2dAecI/ldMQwXvgf4ZdFT2QS+ASIshAAb3Q7q2I10hZbyTSZMBGTN/kYLH9ECp/wyh8TQV4FK;
5:gsCCnrnxRIYTQFHQSB/aZCvZZcHArdOLlzem5EcEJoSQRzssW7vM0+Z1fx5KJs+F902JTzaejk/mp+7tmIBnOlX+j+1557hhQKAkykt1Yaob03x0HxI3ldC4nEpKu6L95l0JkfdgY/DYHrNb2eFcut41dqPhop1JGB8eEktwtumJj/d6Y92j6QWhOI34FbBX;
24:VIv8t6lAz6PUPqg5DKTfBOm1z1ktivGyUV/9lvvnXUslc2A12RZeFi8TgUtzHjIbJ4NBsIg2y9bJK4zhGXRU2GlyZ/yIe5NLhMZnZSV0nAk=
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-Microsoft-Exchange-Diagnostics: 1; BN1PR0301MB0739;
7:wh2POxUHcOCXsCDF5q44SHXYett71CzJ6Ed+ErqNozK71vTfEhIrwgqiT6omHBUv6DDzcl1ITzXfQkgLXK/zD6fk7QdL57IQJvFCQiB+KiJXwZRGRs+T1ia4+U9f5dXkSRoQrfpcf6xbnGHHfjnCtAMZeoi9GeYkhWep3iHNel6HmiIhz9+kLWw+m/Myuilxn0jVCt9H307vhyBBmtQ90LAivNCIVuhzFG3NnF0xPTfpNQ7eOoTN7LBIVs5ywHiXcRXKyqBNDNTfXWg2tuXtA/wLvBYnukO67jK2y8ZdDsGDGKU0UKjvszflL/XQJ+JReTeli7W8LZ3OOndERizpWy0G5OiPhFfSkhQLNtHEUz9Q+kLlbjqsQ9NeOFwbhvFD2rFi0mXB3na5l+E9u0moX7DydmNB+jZ1k1y2GXSYDd2U97vZstezGHTvb20I/m0imOrosZFj+bYTdVXVrm0g2g==
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jan 2017 05:01:52.7377 (UTC)
X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50];
Helo=[tx30smr01.am.freescale.net]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR0301MB0739
Subject: Re: [dpdk-dev] [PATCHv5 04/33] bus/fslmc: introducing fsl-mc bus
driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Jan 2017 05:01:55 -0000
On Friday 20 January 2017 12:38 AM, Ferruh Yigit wrote:
> On 1/19/2017 1:23 PM, Hemant Agrawal wrote:
>> The fslmc bus driver is a rte_bus driver which scans the fsl-mc bus
>> for NXP DPAA2 SoCs.
>>
>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>> ---
>
> <...>
>
>> +#
>> +# library name
>> +#
>> +LIB = librte_pmd_fslmcbus.a
>
> Since now there is a bus folder/driver, what do you think nameming
> library with librte_bus_ prefix, like: librte_bus_fslmc.a
>
> <...>
>
>> +
>> +static int
>> +rte_fslmc_probe(void)
>> +{
>> + int ret = -1;
>
> If any bus->probe() fails, rte_bus_probe() breaks and returns error,
> which cause app to exit.
> Here if there is no device or driver in the bus, function is returning
> error, I guess it should be returning zero for this case.
It is a nice point of discussion (even in the bus patch). Should Bus
iteration for scan/probe fail if any bus implementation fails?
In the initial series I had placed a 'TODO' in the bus patch to get some
comments - I couldn't make a decision so the final bus scan/probe loop
'fails if any bus fails whether in scan or probe'.
I think that EAL should continue looping over buses irrespective of bus
failure - specially removing such dependencies on bus implementations to
return a valid code compatible with EAL's design.
>
>> + struct rte_dpaa2_device *dev;
>> + struct rte_dpaa2_driver *drv;
>> +
>> + TAILQ_FOREACH(dev, &rte_fslmc_bus.device_list, next) {
>> + TAILQ_FOREACH(drv, &rte_fslmc_bus.driver_list, next) {
>> + ret = rte_fslmc_match(drv, dev);
>> + if (ret)
>> + continue;
>> +
>> + if (!drv->probe)
>> + continue;
>> +
>> + ret = drv->probe(drv, dev);
>> + if (ret)
>> + FSLMC_BUS_LOG(ERR, "Unable to probe.\n");
>> + break;
>> + }
>> + }
>> + return ret;
>> +}
>
> <...>
>