From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4EAF5A0A05; Wed, 20 Jan 2021 11:24:28 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3B47C140E97; Wed, 20 Jan 2021 11:24:28 +0100 (CET) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id E8401140E97 for ; Wed, 20 Jan 2021 11:24:26 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 585FF12A6; Wed, 20 Jan 2021 05:24:24 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 20 Jan 2021 05:24:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= KPyb4owSO5CAJA0Kb6BNkEHdo85OY8KjwDu/aKE6y80=; b=g6Nx5zRzXX1zekkR K1hlJYPA4w1O+x/qaNsWuQlH1ploCHemPIzHUgkm0xjS0M/IFN7Ly339jmLyxFv4 Xl/v7yLGf1qGcq1sFDffScxdjprifybk6FOwEye8eid2WyOZ1Xz7CI1tSqpif8Vr HUieWJQ/6hEo/nKKw09VkvZhxm8eP17oEpmfzKhTySamdyMjTdzppHExrHp94xfJ 39eDNhS03Jt54kDXe6W7GGG+BWlgbDJCfewgvoqxoFSai75Ib5XzlZUrjQKJVBn8 bCz/MkV42IzhHNU5JNsNNAd79Li14v+MllmdCFg8G4xILI/3AupXi7JmUKNtbuh6 MPqQCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=KPyb4owSO5CAJA0Kb6BNkEHdo85OY8KjwDu/aKE6y 80=; b=ngpIwwKzxnevf+u5taI9oy6uyJkYzD6Dcz/YDZwbt+2gf3I5xuxEXx6jh 6ZNJBl1jO35N5BRxjtjSvcR7G7EC/kUsHF0yixrG/jCdtvv51qEiqvoD7Rv85/57 7+JJj9s/SK/iRWxpKgTeg/fI9Piq3NvYeaAcdYYBgdbTTyuw7AfxtNL8OcIYvgJU mIfceAUjHHRN1fh7B2anfCUC74sb8gDnRqSN337x0hFWwQr+S3JuN4c3RKa5D9jv atfOC/zT0gPKVALJLTsf2sVlpu8VGZgRjWKxAf68M26atFKIBhZabecAqsGi+PxD IhsgwWeNdjI14QBQ1xAMShnNs2eAg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddvgddujecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5D5B91080057; Wed, 20 Jan 2021 05:24:22 -0500 (EST) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: dev@dpdk.org, Stephen Hemminger , David Marchand , Maxime Coquelin , Aaron Conole , Bruce Richardson , ferruh.yigit@intel.com Date: Wed, 20 Jan 2021 11:24:21 +0100 Message-ID: <2534344.1dmFBEvUxf@thomas> In-Reply-To: <20210120102314.0235dfc1@sovereign> References: <20201014183136.22239-1-dmitry.kozliuk@gmail.com> <5629972.kJsfQy86Dy@thomas> <20210120102314.0235dfc1@sovereign> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 2/3] build: use Python pmdinfogen X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 20/01/2021 08:23, Dmitry Kozlyuk: > On Wed, 20 Jan 2021 01:05:59 +0100, Thomas Monjalon wrote: > > This is now the right timeframe to introduce this change > > with the new Python module dependency. > > Unfortunately, the ABI check is returning an issue: > > > > 'const char mlx5_common_pci_pmd_info[62]' was changed > > to 'const char mlx5_common_pci_pmd_info[60]' at rte_common_mlx5.pmd.c > > Will investigate and fix ASAP. > > > Few more comments below: > > > > 20/10/2020 19:44, Dmitry Kozlyuk: > > > --- a/buildtools/meson.build > > > +++ b/buildtools/meson.build > > > +if host_machine.system() != 'windows' > > > > You can use "is_windows". > > It's defined by config/meson.build, which is processed after > buidtools/meson.build, because of the dependency, if swapped: > > config/x86/meson.build:6:1: ERROR: Unknown variable > "binutils_avx512_check". OK > > > --- a/doc/guides/linux_gsg/sys_reqs.rst > > > +++ b/doc/guides/linux_gsg/sys_reqs.rst > > > +* ``pyelftools`` (version 0.22+) > > > > This requirement is missing in doc/guides/freebsd_gsg/build_dpdk.rst > > OK. > > > > --- a/meson.build > > > +++ b/meson.build > > > -subdir('buildtools/pmdinfogen') > > > > This could be in patch 3 (removing the code). > > It would redefine "pmdinfogen" variable to old pmdinfogen. > Besides, why build what's not used at this patch already? Just trying to find the best patch split. If needed, OK to keep as is.