From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com
 [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id 8914C5937
 for <dev@dpdk.org>; Thu, 27 Mar 2014 11:28:08 +0100 (CET)
Received: by mail-wi0-f177.google.com with SMTP id cc10so2955419wib.16
 for <dev@dpdk.org>; Thu, 27 Mar 2014 03:29:41 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=LLfjqjpwX0+rvvLeKj85rnPyb2bGeAXj65Xmfcok9nk=;
 b=l0gqI4BuHc6BppZE5ZmdLmOM1vsfyVvMBnZIDprB1cQ7oNbvrL8fQWUCACtirSGlFr
 mOPJn99hcgts7xS4BLePWTO7urUjNm/4oyn/BlKQ4zz7DUDIAq/qgbYK3xLZBXpSolJy
 OfrKMQ7FlF1DCliGkFRj0Lr8MlG2cKEkkHE+OB7TmbZUpbehP3VDlAT2mgGtj3z1Vsvo
 QvpwWC/GLUW6ZzzY6jO4T/VVDL9dtyl6s92xmr/NyksWAUTYaMyql8f55Q2yqmKJMYis
 uRCmUdIN5IKW80EmNx/LDkEYArz84vnp58YKSr4ec4NZN+cwtgwZPoPnIiMXra4ZDN0e
 hbAA==
X-Gm-Message-State: ALoCoQkyJn8r1K48HB3DjJjVeSlURh8w/6JAB1SBU1nnpaG0vlfdUmMOZebhsVR+EcVt9xMnVl5I
X-Received: by 10.180.21.225 with SMTP id y1mr3908809wie.24.1395916181616;
 Thu, 27 Mar 2014 03:29:41 -0700 (PDT)
Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237])
 by mx.google.com with ESMTPSA id h8sm5906368wiz.12.2014.03.27.03.29.40
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 27 Mar 2014 03:29:40 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Olivier MATZ <olivier.matz@6wind.com>
Date: Thu, 27 Mar 2014 11:29:40 +0100
Message-ID: <2538842.0sWbMQBLAx@xps13>
Organization: 6WIND
User-Agent: KMail/4.12.3 (Linux/3.13.6-1-ARCH; KDE/4.12.3; x86_64; ; )
In-Reply-To: <5333E2F3.6060503@6wind.com>
References: <1391529271-24606-1-git-send-email-thomas.monjalon@6wind.com>
 <1391529271-24606-14-git-send-email-thomas.monjalon@6wind.com>
 <5333E2F3.6060503@6wind.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [memnic PATCH 13/16] pmd: rename doc when installing
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Mar 2014 10:28:08 -0000

> > MEMNIC doc may be installed with other DPDK docs.
> > So more descriptive naming is required.
> > 
> > A rule is created in order to have the same rule style for lib and doc.
> > 
> > Signed-off-by: Thomas Monjalon<thomas.monjalon@6wind.com>
> 
>   [...]
> 
> > +$(DESTDIR)$(docdir)/$(DOC) : $S/README.rst
> > +	install -D -m 644 $< $@
> 
> What about renaming README.rst in dpdk-memnic.rst in source ?

I'm not convinced. README is a good name when looking in source tree.

> The rest of the patch looks good to me.
> 
> Reviewed-by: Olivier Matz <olivier.matz@6wind.com>

Applied

-- 
Thomas