From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id E7E1437B7 for ; Mon, 2 May 2016 18:10:31 +0200 (CEST) Received: by mail-wm0-f54.google.com with SMTP id v200so23410020wmv.1 for ; Mon, 02 May 2016 09:10:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=Dr0lwRG3xw3zdiv9D15E3WWyf+GV854IGQ0Qmz4bW8g=; b=jlNmKbLDAD1AmxzcDC/AqjBky3TITyCMtxsVpiZZ+e83H/AZ2TCVHE6pp98N/YCn2T dEjfqYyKp4S1u9RekZqLSraSKSuDCQaBP4FL5qgbi1sDB1KbCWXjkJNQb6z0Z+PL/gY3 J/brzuveQq7apDwOUlIHFRUqJTI/IfNbcRJEgoLVFpKz/7ZfufraGPOvqRQv8F79mXwp 4enAMUm/sLV4h6v3sqPNGxd8jLMdHdWa0ivlO+u7vBLLQ+kQp/20JXdnm8ZJ78RUG+p9 um/W6YOj7vWXIPtuOUrUU5auO7X3GpiKxCBTGGTsI239hpuLJBCzCIaLNlVtJ8hr0FGr u0Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=Dr0lwRG3xw3zdiv9D15E3WWyf+GV854IGQ0Qmz4bW8g=; b=gAT0WINgZJkEYLsTfDrBJKwNMhK/SbwjDQONgxeZjdvvSQINb9nL2x9sSZO0wN89Rf fhbMZ10GcNORouYxLn8TkpW5vl2ikk6yRs69eU1mwj4v8bZ1lJHJwZxIuuQ8Qf7TL1yL 1tJR+pbP0XqC8VbQ7nuhgcxGu59PY63eKKsa98uztZ29BVQ1KWFULXTNfnOabE0678Zp VbtFHCM0vgi5aHofaSfm6PoeCb74ejjUujJCanvGPmZfiyzCpOtO6gpcJgENTyvpg21Y 1v1pygHX5f3fAh+bZ/EqlB75KL3xa6P+Jhe3ulLSBr4eLr1zzufhZfeElJPdgFeJCL+k oOKg== X-Gm-Message-State: AOPr4FUpeJFwXKfNCrjH1QVrlsng7DuLB2s5o+bhq7x04dQLf4B6FZ0TzLw8sWyJg3ljxcdJ X-Received: by 10.28.92.69 with SMTP id q66mr20726730wmb.102.1462205431718; Mon, 02 May 2016 09:10:31 -0700 (PDT) Received: from xps13.localnet (207.111.75.86.rev.sfr.net. [86.75.111.207]) by smtp.gmail.com with ESMTPSA id a207sm19671918wma.8.2016.05.02.09.10.30 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 02 May 2016 09:10:30 -0700 (PDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org Date: Mon, 02 May 2016 18:10:29 +0200 Message-ID: <2540046.4XauHpbFhJ@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1461947665-1086-1-git-send-email-ferruh.yigit@intel.com> References: <1461947665-1086-1-git-send-email-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] mk: add rpath for applications X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 May 2016 16:10:32 -0000 2016-04-29 17:34, Ferruh Yigit: > Add default library output folder to the library search folder. > > This is useful for development environment, in production environment > DPDK libraries already should be in know locations. Yes it is useful in dev environment, but can be risky or strange when packaged for production environment. Shouldn't we have a switch to avoid a development garbage in production? I suggest to use RTE_DEVEL_BUILD. > Patch removes requirement to set LD_LIBRARY_PATH variable when DPDK > compiled as shared library. Yes, this patch could remove export LD_LIBRARY_PATH=$build/lib:$LD_LIBRARY_PATH in scripts/test-null.sh. [...] > +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) > +LDFLAGS += --rpath=$(RTE_SDK_BIN)/lib > +endif Isn't it -rpath, with a single dash? As it is a variable setting, it should be added before the rules, just after LDLIBS settings.