* [dpdk-dev] [PATCH] ethdev: clarify API comment for imissed stats
@ 2016-09-09 8:15 Olivier Matz
2016-10-04 9:37 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Olivier Matz @ 2016-09-09 8:15 UTC (permalink / raw)
To: dev, thomas.monjalon
The "imissed" stats represent RX packets dropped by the HW,
so we should not talk about mbufs as the hardware is not aware
of this structure. Buffer seems to be a better word.
Fixes: 4eadb8ba11b7 ("ethdev: do not deprecate imissed counter")
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
lib/librte_ether/rte_ethdev.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index b0fe033..f4bc272 100644
--- a/lib/librte_ether/rte_ethdev.h
+++ b/lib/librte_ether/rte_ethdev.h
@@ -198,7 +198,7 @@ struct rte_eth_stats {
uint64_t obytes; /**< Total number of successfully transmitted bytes. */
uint64_t imissed;
/**< Total of RX packets dropped by the HW,
- * because there are no available mbufs (i.e. RX queues are full).
+ * because there are no available buffer (i.e. RX queues are full).
*/
uint64_t ierrors; /**< Total number of erroneous received packets. */
uint64_t oerrors; /**< Total number of failed transmitted packets. */
--
2.8.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] ethdev: clarify API comment for imissed stats
2016-09-09 8:15 [dpdk-dev] [PATCH] ethdev: clarify API comment for imissed stats Olivier Matz
@ 2016-10-04 9:37 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2016-10-04 9:37 UTC (permalink / raw)
To: Olivier Matz; +Cc: dev
2016-09-09 10:15, Olivier Matz:
> The "imissed" stats represent RX packets dropped by the HW,
> so we should not talk about mbufs as the hardware is not aware
> of this structure. Buffer seems to be a better word.
>
> Fixes: 4eadb8ba11b7 ("ethdev: do not deprecate imissed counter")
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-04 9:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-09 8:15 [dpdk-dev] [PATCH] ethdev: clarify API comment for imissed stats Olivier Matz
2016-10-04 9:37 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).