From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 54C94727A; Fri, 12 Jan 2018 01:04:47 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 088C120CB0; Thu, 11 Jan 2018 19:04:47 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Thu, 11 Jan 2018 19:04:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=SCjE3eTXaGMcTYyiIz1JMiTJPO SrtOXjD+b/8wWjcYg=; b=W5lV/KVfzRKWFxOSj6biFgU5kYnCysqWmP1g3+i/Jx vd0NjlKCAwKN+xBpqr2/e+WRiVwdEeC+PrrhjVItYU94+wIeUAQyz4bxM9QKC5YW yx7QTKyx5iymVTTwbTuG/DQ/cIQ5jU7D1LT0tBHg6b/UarxwdoX+wf5oxYP5WloM E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=SCjE3e TXaGMcTYyiIz1JMiTJPOSrtOXjD+b/8wWjcYg=; b=DQvBLy1B5gy4EtqVZ/xXzQ cEW4KAkcuW5ODX5fvwKRjraFoe0eH71sbQMmctvbqUcfXCdcyRjE8XGkyU+YoMQ7 TITe8vdR5iKlc9Fafh4Z5TiInfvnkvSQgec0lJZlhh9ygQWXVmFnsocBu2bY5niI dTJIeDw4G08DlneEOFgd8z+cUHrVDt5qZ85Ioc0eMpFyBPwVXS/RKZvYS/NKpgbS saBy5UxCM54f+ViYSpt1rzz3DhFzNwve3R9jtuL5ozaO2U+dUXGMWhySj4W18JxW 7PlojGf9W6YMPCF6cvkQy11aaFmoFmuTWs9PydYcS61FHdofL1Mh3/Zr5UKiySkQ == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id AD29424599; Thu, 11 Jan 2018 19:04:46 -0500 (EST) From: Thomas Monjalon To: Zhiyong Yang Cc: dev@dpdk.org, ferruh.yigit@intel.com, stable@dpdk.org Date: Fri, 12 Jan 2018 01:04:18 +0100 Message-ID: <2541614.81fTKLe5WG@xps> In-Reply-To: <20180110023226.37133-1-zhiyong.yang@intel.com> References: <20171229075511.33180-1-zhiyong.yang@intel.com> <20180110023226.37133-1-zhiyong.yang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] bus/pci: fix wrong intr_handle.type with uio_pci_generic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jan 2018 00:04:48 -0000 10/01/2018 03:32, Zhiyong Yang: > For virtio legacy device, testpmd startup fails when using uio_pci_generic. > > The issue is caused by invoking the function pci_ioport_map. The correct > value of intr_handle.type is already set before calling it, we should avoid > overwriting the default value "RTE_INTR_HANDLE_UNKNOWN" in this function. > Besides, the removal has no harm to other cases because it is set to 0 by a > memset on the whole struct during allocation in the function pci_scan_one. > > Such assignments are removed in the meanwhile in pci_uio_map_resource(), > pci_vfio_map_resource_primary() and pci_vfio_map_resource_secondary() in > order to keep consistencies and avoid future questions. > > Fixes: 756ce64b1ecd ("eal: introduce PCI ioport API") > Cc: stable@dpdk.org > Signed-off-by: Zhiyong Yang Reviewed-by: Thomas Monjalon Applied, thanks