From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16F95A04B0; Fri, 7 Aug 2020 18:31:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0176F1C031; Fri, 7 Aug 2020 18:31:58 +0200 (CEST) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by dpdk.org (Postfix) with ESMTP id 07EB52BF1 for ; Fri, 7 Aug 2020 18:31:55 +0200 (CEST) Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 077FWxhv124507; Fri, 7 Aug 2020 12:31:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=+ttJpqe/8wcuEUdbZX/NzW5YBRU+E3DD5aejYK/jB5U=; b=tVoHcVhRZXzbn04H8YZnM5Yx3qIpyUCT71wKmN07se2ImC6nOHsTNlQS3sveP23mJ9Xs ve6VhXFM7FEs50GyX+ZuF6UVB91chlNW4dwJiyKAgzLNFlhXFwwvr6OtX7WjeWo1kOf0 ugEn/IWTipZHeq+Ip/mpXm7vdNiCNK4UdRfPG4/jJUjnsO+nFHhh6VraB8YnER9U84ff bmoF5RDtes8vVxvYmbqGCjALs3lppP9voCMa3v6vhCfYkR8ZPJmCbT7q5tuIopqD3swg cCU/fFtlwKtygVnds9GhBO1/A2s0QntClEpDpX3UvgYaiLiRWBMktAfHXX30IYEKokXd XQ== Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0a-001b2d01.pphosted.com with ESMTP id 32rfvwm62d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 07 Aug 2020 12:31:53 -0400 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 077GUwwX009628; Fri, 7 Aug 2020 16:31:52 GMT Received: from b01cxnp23033.gho.pok.ibm.com (b01cxnp23033.gho.pok.ibm.com [9.57.198.28]) by ppma04dal.us.ibm.com with ESMTP id 32n01a0jdk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 07 Aug 2020 16:31:52 +0000 Received: from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com [9.57.199.107]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 077GVpWL54723044 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 7 Aug 2020 16:31:51 GMT Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 74831124055; Fri, 7 Aug 2020 16:31:51 +0000 (GMT) Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B8F0512405B; Fri, 7 Aug 2020 16:31:50 +0000 (GMT) Received: from Davids-MBP.randomparity.org (unknown [9.163.7.45]) by b01ledav002.gho.pok.ibm.com (Postfix) with ESMTP; Fri, 7 Aug 2020 16:31:50 +0000 (GMT) To: Ciara Power , dev@dpdk.org Cc: bruce.richardson@intel.com, Ruifeng Wang , Jerin Jacob , Honnappa Nagarahalli References: <20200807155859.63888-1-ciara.power@intel.com> <20200807155859.63888-3-ciara.power@intel.com> From: David Christensen Message-ID: <25416a77-6ce1-0770-d304-2dfa1fe23c73@linux.vnet.ibm.com> Date: Fri, 7 Aug 2020 09:31:50 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200807155859.63888-3-ciara.power@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-08-07_12:2020-08-06, 2020-08-07 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 mlxlogscore=999 suspectscore=0 clxscore=1011 impostorscore=0 mlxscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008070107 Subject: Re: [dpdk-dev] [PATCH 20.11 02/12] eal: add default SIMD bitwidth values X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/7/20 8:58 AM, Ciara Power wrote: > Each arch has a define for the default SIMD bitwidth value, this is used > on EAL init to set the config max SIMD bitwidth. What's the intended use case? > > Cc: Ruifeng Wang > Cc: Jerin Jacob > Cc: Honnappa Nagarahalli > Cc: David Christensen > > Signed-off-by: Ciara Power > --- > lib/librte_eal/arm/include/rte_vect.h | 2 ++ > lib/librte_eal/common/eal_common_options.c | 3 +++ > lib/librte_eal/include/generic/rte_vect.h | 2 ++ > lib/librte_eal/ppc/include/rte_vect.h | 2 ++ > lib/librte_eal/x86/include/rte_vect.h | 2 ++ > 5 files changed, 11 insertions(+) > > diff --git a/lib/librte_eal/arm/include/rte_vect.h b/lib/librte_eal/arm/include/rte_vect.h > index 01c51712a1..7487a53862 100644 > --- a/lib/librte_eal/arm/include/rte_vect.h > +++ b/lib/librte_eal/arm/include/rte_vect.h > @@ -14,6 +14,8 @@ > extern "C" { > #endif > > +#define RTE_DEFAULT_SIMD_BITWIDTH 256 > + > typedef int32x4_t xmm_t; > > #define XMM_SIZE (sizeof(xmm_t)) > diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c > index 90f4e8f5c3..c2a9624f89 100644 > --- a/lib/librte_eal/common/eal_common_options.c > +++ b/lib/librte_eal/common/eal_common_options.c > @@ -35,6 +35,7 @@ > #ifndef RTE_EXEC_ENV_WINDOWS > #include > #endif > +#include > > #include "eal_internal_cfg.h" > #include "eal_options.h" > @@ -344,6 +345,8 @@ eal_reset_internal_config(struct internal_config *internal_cfg) > internal_cfg->user_mbuf_pool_ops_name = NULL; > CPU_ZERO(&internal_cfg->ctrl_cpuset); > internal_cfg->init_complete = 0; > + internal_cfg->max_simd_bitwidth.bitwidth = RTE_DEFAULT_SIMD_BITWIDTH; > + internal_cfg->max_simd_bitwidth.locked = 0; > } Build error on HEAD: ../lib/librte_eal/common/eal_common_options.c: In function ‘eal_reset_internal_config’: ../lib/librte_eal/common/eal_common_options.c:347:14: error: ‘struct internal_config’ has no member named ‘max_simd_bitwidth’ internal_cfg->max_simd_bitwidth.bitwidth = RTE_DEFAULT_SIMD_BITWIDTH; ^~ ../lib/librte_eal/common/eal_common_options.c:348:14: error: ‘struct internal_config’ has no member named ‘max_simd_bitwidth’ internal_cfg->max_simd_bitwidth.locked = 0; ^~ Dave