From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B96A94317E; Mon, 16 Oct 2023 14:50:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A866040269; Mon, 16 Oct 2023 14:50:57 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2051.outbound.protection.outlook.com [40.107.94.51]) by mails.dpdk.org (Postfix) with ESMTP id 8032A4021D; Mon, 16 Oct 2023 14:50:55 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nw2TMI9tDk//zqsunUj2H/Wz+SuHFKN2jq3d0DhuRphiO5hAEkpFmBdqTYQRe6DS7cwvTnE+h0zMKwEXPlj7p/bLTAMRXw6hv3FduxtUy7g+7ExQbphd/Q+Hv41s3tVvej5J3t5vfUT4UTsMle+8/2IhLC7WuQQOMKFliz46dHwTtca2iVcW2rCpxcb9L23MEarXyQdkHUi/GNkJOwd2L5eYBxFv0erN3fIpefsNIxeakDnkXF4C/j7MnViIcZWEch9kMCN9b1gaDj8NhylxyZCVuAbBZEN6Ky8QyM1wOOtizJ32xAUg0FN62nMk+KeR+xQD8fe99tl3MZQ7r6abtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=syUpJcUS10csHwuHOXxRC5UGL8Dbihpta5CJ7JPqT0U=; b=Sjc+dCJuok757DEFjuAolmzkQCqXodz2cx3kSn1o1ShdM1J9/3XpBOHiB3Ue6GHh2xHBxQYfpXnnq6gxFct+3mtX3/Qm4bVkaq4hGMv9JPxii1Z5ZBHJ26oLePVeuKXG79ZPCPGacQDcXtEIkIzqWmwE+4zQVIyuHn4hk6Af1/2cpnVv7SLSLudnw9wHFPe5SvwaKXPgTlefQ4lcUkapMLrbX5dA32bcaI3x/hB74I+hCLmKphiftTG2zZoO11SsRZL0uUpJiGwsNCDyDkKBDnhuPkyFYEdriIzzBizSur4kCMMFdcmpKFyXyK6oE1YnVHHr2WP7IFC8szgtPNhHrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=syUpJcUS10csHwuHOXxRC5UGL8Dbihpta5CJ7JPqT0U=; b=32jvkmmnrxhS95LWuMQKo5UwaHM+krYY1HTMXoDm1z2FpiL9nnMKfwV09ClGYWFv2DsNURcOX76OEiP7Dubk9iQXaTtV+lwSDJesGD9dFjiixGqf8/IiHLcHrUEcDEl+nkUWD2uMzTL6/WvAMGUV6XVQ0Dh1ZR1J8s395pwVfL0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SJ0PR12MB6927.namprd12.prod.outlook.com (2603:10b6:a03:483::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.36; Mon, 16 Oct 2023 12:50:51 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6863.032; Mon, 16 Oct 2023 12:50:51 +0000 Message-ID: <25419eca-e0ef-4064-aced-3432649f3647@amd.com> Date: Mon, 16 Oct 2023 13:50:44 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net/nfp: fix the Tx performance issue Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, Zerun Fu , shihong.wang@corigine.com, stable@dpdk.org, Long Wu , Peng Zhang References: <20231013074653.3429-1-chaoyong.he@corigine.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: <20231013074653.3429-1-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PA7P264CA0411.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:39b::6) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SJ0PR12MB6927:EE_ X-MS-Office365-Filtering-Correlation-Id: 0881ef66-918e-41a8-29e1-08dbce4686e5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vfqc9kwTjHh3L9vVa1okt3iBSJeMpQ/reVmcw9AHm1pSiCtWD84BbpmxayIIRPgsYcisiSILIFgn7j0A2HASEE859raT02oKIMe8OBitd5sx2rAMDBUgJ3gSSowVL8+jt0G2qrozONxmoMR2EfArMdLAEpZeEPLA6CruzEXJmDStpf3KOEWtMUcRN9+8OYNgPEkN3hqiubYpqV6bondBfRv00n0Y3virqDdZh6QjNW86Eik0umWSi/lmnr61TlAN5zm+unaS9MK/j3+VIleeBpOW7ww0yjrlQPNQI2ujC9lZuZv9zCEI9/GM4xxay00KGLjdwxAY1EgYR6FeUI8vQGar+G5tgKD5nTtfZd8t4MILRek1NktnD+lEkureCPkTy9VJERiO114Ts27zZZfiLEUsgh/adhsph3thjchtSOkCn3YrK3TPiesITHfC5h/vXXppQDpZvURGdp7wAPTJl6NehaWqn79hJTP6hcPZ36VgzLPett1eoCrd1o5z7j5F8hCMqDYtYYNeL0MoAVVv+QvRfdhMQgUsH6pPiXewYP8kGX8bnNbz2sVuC9vIUN5TaKqkhNm/msRX1ki8WnCQFKJwgqvaSt8MRNL+L7ORfrDL+IY4ui5RlByNgEwHEqfe3lHtNm7M80W/gfwS8Gvmfg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(396003)(376002)(366004)(346002)(39860400002)(230922051799003)(1800799009)(186009)(64100799003)(451199024)(6486002)(54906003)(478600001)(66476007)(66556008)(66946007)(316002)(2616005)(6506007)(6512007)(26005)(53546011)(5660300002)(8676002)(8936002)(4326008)(6666004)(44832011)(2906002)(4744005)(41300700001)(31696002)(86362001)(36756003)(38100700002)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bHV1bE1KYVVNR001M284ZENiazFPL3BEYmFoditEdjJlWGYvRjBpSFR3Vi9s?= =?utf-8?B?OE5mRXp0ZUp4dm9MN3J1NWNYQnRBYWp5VkxaekhFeWVTK2FmMytkdnBRaUh6?= =?utf-8?B?V1p0WW15eWpGd25wd1R4Z1JnbzVJYmRPWUNqeHpoZnpHQnRJcHhpcWNUSnJt?= =?utf-8?B?a20zNkhKM3owdUZydDM1aWFWd2s0aFRUaVJhd3dMTGdiZ3RTUlZ5VHgyV00r?= =?utf-8?B?SmsrN295ZUhEcVlWZ3EzdjdYalcwQjljSjZTc3diVWNWRmNSZjJhbnFCMkJU?= =?utf-8?B?WWlUMjVKdVd5NXlFRThWWXhBZCsvZStOQzNZZURDOFVESWFFNi9xL1ZyaU9v?= =?utf-8?B?eGpxeWJxc3loTlF2blFURG13UDZqVHl1em1uV2ZCYkxvc2RzcUNUU3Z4TU5y?= =?utf-8?B?RnM3aGZXTFBYUElMVVUxcG5WVkxORVc3TTcrcW1PNE04cll0cXY0Ly9OQkxj?= =?utf-8?B?SGF5T25UZElsd0lGN3hHRndhTzc0SG5tL0Q0cUs1SVYrMTlSNFBXbjFJSTVP?= =?utf-8?B?TzVhZjRBdVBKRmd5bmJna0pTSDY0QUdUaU85VmlFcmxMd2tPTUhiUHZqQ0Rr?= =?utf-8?B?UVY3YXJDbU9IVTlpeXV2TXJhKyt4YnVyUGZ3N3lETXZxSTQwTDlmQU5kZnBa?= =?utf-8?B?T3lac0UyODYraXZyVnNjcWMzNFJWbUM3cVhBOHNxa09ZTjIyZW9iZU80ZGpv?= =?utf-8?B?Ymd6eXlJVjRtVlZGR3BnVlNVbGpyNXFYV1B6d2NDMm92SE5jMEQ4RHVmbXJH?= =?utf-8?B?UGJ1YnVwTWFkZVphK0JHR0RzRVNkeUcreGdEdVc2LzFDYnZyb1VaWVI5N3hq?= =?utf-8?B?NjlWVkFVWVZraHBGb2pkTVExTEs4Sm8vSDdRY3g5ek1FWFJzTmZYUWpEYkFV?= =?utf-8?B?QWk4RFVKazZpWXZxVGlMMW1HdFgyM3MrMTVVaGc5NTQxV1Q2c0t4aHJKZ3Rt?= =?utf-8?B?REh0RU8xWlBxeEtSd1JZWnZuOEs2S2tXZ1Z5eEFtNjFPdW1kdnE5d0ZyNjNJ?= =?utf-8?B?MnAvTjc0a05sMWR4cmhETHpFaktrK28xRk5tK1V5dWVpOTJHUkp3VUFJamd5?= =?utf-8?B?SjZWMG5TVllZSi9sVklzeG8vb2FqaUw5d2lyeWJ6Um8yVmVMRi9KakhLbHlD?= =?utf-8?B?ZlU5UG52Qng0Ym1pOWpoRFVMbVp5VktQNzhSVDNkUkdJcFUyTEhpU1g1SURj?= =?utf-8?B?eEpFbmlxNC9EWkR2MGxJRmhGWm52YXFIRm1NRjdtSUdnekNlRVptMkZiaE9M?= =?utf-8?B?VnFNL2RXM1VFdXd1RjUwOTZWL0diQkxGZXpZMXZJTTEyV01FbjdMSERXRVl6?= =?utf-8?B?T3FTUVhqK29xaVdJRVV3UHZCcnhRbzdISit5L0dQbGljS0ZHRmhzTUVkWVI0?= =?utf-8?B?bW1rV3RabTlHSEp2amo0bWFwUTRFcmhzcm1TaWUvd0tNdTRrRW9GTzU5a3dQ?= =?utf-8?B?UnY3ejhNZkNVZmhJdHRjS1J5VFd6ZzJOQ1lneVgyOTJYYXArV01CWXZuMEx3?= =?utf-8?B?WWNnRmJUYUw3QlFacVpiTXlxWmp3MS9HZ09nYThkV3ZGbmF4amtQYnlBNENF?= =?utf-8?B?MnJ4UnpwWExmbUNGSkFsWklHV09WRGg2TTlKMlEyOGhWNXFkWmtOY0E3cDk0?= =?utf-8?B?SlVNbnZyaDczMUswcmZRQ0xFTkZnTHpmenVuWjJISUI5ckxEQ1M2dm50RUY5?= =?utf-8?B?SXI0ZGx1Y3dOdHhyZzdFZCtac0cxRjUvaFNsTk4rK256ODk1ZkhkUHZsQXBj?= =?utf-8?B?VWdGN2Rld3Z6MktVdWpudmcvcko3N1R3WEY5YzdDRlljVVVXdkh3ZEY5RmlK?= =?utf-8?B?MGdGdURkNllrQ05MZzVaR1lIWUZNQjdFY1RaNlhrRHhwdUFWejRmYys2MHhl?= =?utf-8?B?TUI5VFZIRkpwcm1tVlR0YjkwSG44cUVONHc4dVpVTldndHNXeEJIOFczRk4w?= =?utf-8?B?UFAxS2txU29mcU9NTGNGeE1EZW5yNDZUWnY0TnEvQldBSEhqVXJOUkM4L0VX?= =?utf-8?B?NmN0YXNRYjUrcmhVNXpIbmJLT3pmMG5tQWtTMVJSK2g0Wk5VODNobFE5aURM?= =?utf-8?B?Ti9LMzA4cFZIY2FBTGJwaVVCdkdLdmt2VVJISDdZQ2JmcXRDcUpjMjlrWU9E?= =?utf-8?Q?b/uoVxrwN3bUXszwH0Oe9Wid9?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0881ef66-918e-41a8-29e1-08dbce4686e5 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2023 12:50:51.2961 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uPIuKU9pLFZnZMdwix0vhwU2HVRdORgu1gPYlFc7PWHFT76fdX75PgbThdYMYRv5 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6927 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/13/2023 8:46 AM, Chaoyong He wrote: > From: Zerun Fu > > The former commit imports a register read operation into the data path > logic, which will severely degrade performance. > Fix this bug by moving the register read logic out of the data path. > Read 'cap_extend' only once in the initialisation logic and store it > in the data structure. And all other logics that need this value should > get it from the data structure. > > Fixes: 310a1780581e ("net/nfp: support IPsec Rx and Tx offload") > Cc: shihong.wang@corigine.com > Cc: stable@dpdk.org > > Signed-off-by: Zerun Fu > Reviewed-by: Long Wu > Reviewed-by: Peng Zhang > Reviewed-by: Chaoyong He > Applied to dpdk-next-net/main, thanks.