From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id AE90D1B48D; Tue, 23 Apr 2019 00:12:46 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5C2492208A; Mon, 22 Apr 2019 18:12:46 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 22 Apr 2019 18:12:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=6Y9mZVWobT3lPfny2ikmXMfkDeVkBvBxlj/6Tit3X9U=; b=GQjErUH8ciFF GG8YShp/x72UetwV/1UBD5MM16laPbO1zEAi576EbTLccT6FKR6wIUa5CSxlS8Wu GviO3PIAGzvgiJrDZf93HUZKd57DQad3sqRhp0gJbd44WcVpiFiOOYIePmlKDrXv NMfiTnTtXV4NVsDNYMcIC9ACHhfZxoc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=6Y9mZVWobT3lPfny2ikmXMfkDeVkBvBxlj/6Tit3X 9U=; b=PxzzqgZuePPC7B6OHoJmSjYN3M1iycYORSs/NWYzJdCtbpVbDgjIRyGPI 5er3XErbr4APJOx2ei49k5NSBQqqw1lDkNvpQ9ixBqdXYthAV0EyjXxnvi311DBo 6uRL0Spo+SPbGAxbfjMkr75a6m/91dbNGBZsY3E5THKKFA3GZtxrz0j29ZXceb1m jc0L2xVqijq1YhjHxjGxU+upkDvsWiDirIQXFu1BUEKtS5B+jjcUUyqs2Mwynfde DY5z2aKOy4/JtrTSy29OOeso/KxNgK/Qt8ASA2K3Q8M0iiAWveOiZF5Llj2TPMhG O190Y5CAeTjkQIsNgKGp7Tpr66fpQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrgeejgddtvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epkeefrdduudehrdduheehrddufeeknecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (acaen-257-1-30-138.w83-115.abo.wanadoo.fr [83.115.155.138]) by mail.messagingengine.com (Postfix) with ESMTPA id 225A9E4067; Mon, 22 Apr 2019 18:12:44 -0400 (EDT) From: Thomas Monjalon To: Lee Daly Cc: dev@dpdk.org, "Hunt, David" , liang.j.ma@intel.com, stable@dpdk.org Date: Tue, 23 Apr 2019 00:12:42 +0200 Message-ID: <2544567.6fWz8dBWoG@xps> In-Reply-To: <0e4ce484-1ae1-e759-9e81-e6328e0911bc@intel.com> References: <1555084647-75896-1-git-send-email-lee.daly@intel.com> <0e4ce484-1ae1-e759-9e81-e6328e0911bc@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] lib/librte_power: set new frequecy on turbo_disable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Apr 2019 22:12:47 -0000 15/04/2019 11:21, Hunt, David: > On 12/4/2019 4:57 PM, Lee Daly wrote: > > This patch will ensure the correct max frequency of a core is set in > > the lcore_power_info struct when disabling turbo, while using the > > intel pstate driver. > > > > Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility") > > Cc: liang.j.ma@intel.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Lee Daly > > --- > > - > > + if ((pi->turbo_available) && (pi->curr_idx <= 1)) { > > + /* Try to set freq to max by default coming out of turbo */ > > + if (power_pstate_cpufreq_freq_max(lcore_id) < 0) { > > + RTE_LOG(ERR, POWER, > > + "Failed to set frequency of lcore %u to max\n", > > + lcore_id); > > + return -1; > > + } > > + } > > return 0; > > } > > Acked-by: David Hunt Applied without extra parentheses and with blank line restored. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id EFEEDA05D3 for ; Tue, 23 Apr 2019 00:12:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 40DEF1B497; Tue, 23 Apr 2019 00:12:48 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id AE90D1B48D; Tue, 23 Apr 2019 00:12:46 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5C2492208A; Mon, 22 Apr 2019 18:12:46 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 22 Apr 2019 18:12:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=6Y9mZVWobT3lPfny2ikmXMfkDeVkBvBxlj/6Tit3X9U=; b=GQjErUH8ciFF GG8YShp/x72UetwV/1UBD5MM16laPbO1zEAi576EbTLccT6FKR6wIUa5CSxlS8Wu GviO3PIAGzvgiJrDZf93HUZKd57DQad3sqRhp0gJbd44WcVpiFiOOYIePmlKDrXv NMfiTnTtXV4NVsDNYMcIC9ACHhfZxoc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=6Y9mZVWobT3lPfny2ikmXMfkDeVkBvBxlj/6Tit3X 9U=; b=PxzzqgZuePPC7B6OHoJmSjYN3M1iycYORSs/NWYzJdCtbpVbDgjIRyGPI 5er3XErbr4APJOx2ei49k5NSBQqqw1lDkNvpQ9ixBqdXYthAV0EyjXxnvi311DBo 6uRL0Spo+SPbGAxbfjMkr75a6m/91dbNGBZsY3E5THKKFA3GZtxrz0j29ZXceb1m jc0L2xVqijq1YhjHxjGxU+upkDvsWiDirIQXFu1BUEKtS5B+jjcUUyqs2Mwynfde DY5z2aKOy4/JtrTSy29OOeso/KxNgK/Qt8ASA2K3Q8M0iiAWveOiZF5Llj2TPMhG O190Y5CAeTjkQIsNgKGp7Tpr66fpQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrgeejgddtvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epkeefrdduudehrdduheehrddufeeknecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (acaen-257-1-30-138.w83-115.abo.wanadoo.fr [83.115.155.138]) by mail.messagingengine.com (Postfix) with ESMTPA id 225A9E4067; Mon, 22 Apr 2019 18:12:44 -0400 (EDT) From: Thomas Monjalon To: Lee Daly Cc: dev@dpdk.org, "Hunt, David" , liang.j.ma@intel.com, stable@dpdk.org Date: Tue, 23 Apr 2019 00:12:42 +0200 Message-ID: <2544567.6fWz8dBWoG@xps> In-Reply-To: <0e4ce484-1ae1-e759-9e81-e6328e0911bc@intel.com> References: <1555084647-75896-1-git-send-email-lee.daly@intel.com> <0e4ce484-1ae1-e759-9e81-e6328e0911bc@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] lib/librte_power: set new frequecy on turbo_disable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190422221242.P0GJmhynNX5yWUjR7_ivU2ovc6E31DCyVP53uWjkOZY@z> 15/04/2019 11:21, Hunt, David: > On 12/4/2019 4:57 PM, Lee Daly wrote: > > This patch will ensure the correct max frequency of a core is set in > > the lcore_power_info struct when disabling turbo, while using the > > intel pstate driver. > > > > Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility") > > Cc: liang.j.ma@intel.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Lee Daly > > --- > > - > > + if ((pi->turbo_available) && (pi->curr_idx <= 1)) { > > + /* Try to set freq to max by default coming out of turbo */ > > + if (power_pstate_cpufreq_freq_max(lcore_id) < 0) { > > + RTE_LOG(ERR, POWER, > > + "Failed to set frequency of lcore %u to max\n", > > + lcore_id); > > + return -1; > > + } > > + } > > return 0; > > } > > Acked-by: David Hunt Applied without extra parentheses and with blank line restored.