From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com
 [209.85.212.172]) by dpdk.org (Postfix) with ESMTP id 5FF62AFCD
 for <dev@dpdk.org>; Thu, 22 May 2014 15:25:28 +0200 (CEST)
Received: by mail-wi0-f172.google.com with SMTP id hi2so9228999wib.17
 for <dev@dpdk.org>; Thu, 22 May 2014 06:25:38 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=tT1Aef45jc3ZqpyT2w7FUJaQ2YnrpBfO/t1zVhvkI+Y=;
 b=S1xbd9OHsmZPFtGpSogWt2R6RMfBm5dUiZGxTHeiRXhm3rOmpWP1Ob1d3A+55ZaS5b
 PTOTke9Gmj8meXf8Gpy+YkccbgREk5bjgiHPKARWfGOJkRBB3VequeEcnqnrld4WdbWK
 WWwLW+3muOIbMMkWlx81i26TljwbtXCWGdkm2L8DgOS4GmtLHTX2PRrpxMpUQkE+TjJD
 CnIQ3j2QqBIDyMD8XjcgfVyTjWA1HUPCSF89WueR62+MIYNIk4/SSAqRRgqLZCKHQXhX
 zVBE/NaOnfZccberv/8ywUjolYorNM+XbtQuVH1NEKGY0lRwXpduX3+PFKVAYa1Z1//P
 EdIg==
X-Gm-Message-State: ALoCoQkPXv30Bz3ws9kbPYM6o66m6EzGZDv18izpMmtVWF469qvgKZeFJqBELaLoH8ccaKFJOZHj
X-Received: by 10.181.13.195 with SMTP id fa3mr3086760wid.1.1400765138023;
 Thu, 22 May 2014 06:25:38 -0700 (PDT)
Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237])
 by mx.google.com with ESMTPSA id be6sm26747652wjb.41.2014.05.22.06.25.36
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 22 May 2014 06:25:37 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Date: Thu, 22 May 2014 15:25:34 +0200
Message-ID: <2547752.EpYF82KJeU@xps13>
Organization: 6WIND
User-Agent: KMail/4.13 (Linux/3.14.4-1-ARCH; KDE/4.13.0; x86_64; ; )
In-Reply-To: <1400514709-24087-17-git-send-email-anatoly.burakov@intel.com>
References: <C6ECDF3AB251BE4894318F4E45123697592AA9BE@IRSMSX101.ger.corp.intel.com>
 <1400514709-24087-17-git-send-email-anatoly.burakov@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 16/16] Adding support for VFIO to setup.sh
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 22 May 2014 13:25:28 -0000

2014-05-19 16:51, Anatoly Burakov:
> Support for loading/unloading VFIO drivers, binding/unbinding
> devices to/from VFIO, also setting up correct userspace permissions.
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>

> -		${RTE_SDK}/tools/igb_uio_bind.py --status
> +		${RTE_SDK}/tools/dpdk_nic_bind.py --status

Please merge this kind of change in the patch renaming the script, in order to 
make it atomic.

Last comment: there are some trailing whitespaces to remove.

Thanks for this important patch serie.
-- 
Thomas