From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 9DCEE1BD87 for ; Thu, 12 Apr 2018 14:41:02 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0BC5F21A1D; Thu, 12 Apr 2018 08:41:01 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 12 Apr 2018 08:41:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=bTdRFQm3O85ru0c7ad52ZWNqf6 xRZ3kDJUEFNUdRgGo=; b=J3UPlr0t8pqppMZKrP3pf/cDiA+HiIuIrVjFwg/mOV QzQMFIeEHQdjbR5rBl3+suSbAfkfdczYCs71ReSMwhR8XghOKe4yQ67KCjR6x71H NZmWCUcmA/VcgtSqhXqXe4KjwiqZDwybvYswjgnf78DkN5U8Bf3nu6nrFVl8MmFp A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=bTdRFQ m3O85ru0c7ad52ZWNqf6xRZ3kDJUEFNUdRgGo=; b=QCvnGZKTZhRhcA16Fkw0P/ FYFZ8we7RpeD7gnrToNjxPway3K+b5/34gPCQtzajjTeXV3WEvbcBZBOg8CXtD2m GjyTJ4s7/2VwVc/6YRjbXduONlsb0Fdfzy3x+RWCisKl3m156+autP48oyQwtOek OBabftIVO00Chrqa14ChkeRkjeHwn6z8rxNrL2oWiSoXEOXrSJ76XNpFBmMcd54k Nt5yJDJBvIzIPpqCI69njeSy4aCSlPzWzv3RWbGGKA0iJufUsxT91fkNMUCycSTQ EZ7Ovxj9zJE0mZYHUs+/X9WYrf6puCDNcFncrKdLs86r5wznKIm8A3TTxGIEWOvA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8B983E5096; Thu, 12 Apr 2018 08:41:00 -0400 (EDT) From: Thomas Monjalon To: Neil Horman Cc: "Burakov, Anatoly" , dev@dpdk.org, Ferruh Yigit Date: Thu, 12 Apr 2018 14:40:59 +0200 Message-ID: <2548468.iqp3a771xh@xps> In-Reply-To: References: <20180402120619.30404-1-nhorman@tuxdriver.com> <20180412111640.8977-1-nhorman@tuxdriver.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCHv2] linuxapp eal: set fd to -1 for MAP_ANONYMOUS cases X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Apr 2018 12:41:02 -0000 12/04/2018 14:05, Burakov, Anatoly: > On 12-Apr-18 12:16 PM, Neil Horman wrote: > > https://dpdk.org/tracker/show_bug.cgi?id=18 > > > > Indicated that several mmap call sites in the [linux|bsd]app eal code > > set fd that was not -1 in their calls while using MAP_ANONYMOUS. While > > probably not a huge deal, the man page does say the fd should be -1 for > > portability, as some implementations don't ignore fd as they should for > > MAP_ANONYMOUS. > > > > Signed-off-by: Neil Horman > > CC: Thomas Monjalon > > CC: Ferruh Yigit > > > > --- > > Change notes > > > > v2) Rebased to HEAD again to adjust for patches that landed ahead of > > this > > --- > > Acked-by: Anatoly Burakov Applied, thanks