From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com
 [209.85.212.179]) by dpdk.org (Postfix) with ESMTP id 350128019
 for <dev@dpdk.org>; Mon, 27 Oct 2014 15:15:09 +0100 (CET)
Received: by mail-wi0-f179.google.com with SMTP id h11so4566544wiw.0
 for <dev@dpdk.org>; Mon, 27 Oct 2014 07:23:52 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=KRdwLymhFfkM2NAFD17aY7qjHObuUmyKvXJL3MEjMJw=;
 b=iJib+cUz8lPlTpA/aMjJ4gjIk7reUxDazdTfNU8QBY3DALIuRa2+u9sI8tlCzvs2OM
 GlFXN3B0YEVpvo1ZQ/BHWDdJoqVH637D5By0rrBszhkda42R651jfuMETtAeQtrxAFCX
 CiJMVn77lc4h2BFA7HE99y9kCz/ZzoW6SM/qfbpXEEvyHDAzpJJ+drcE01+BVRdlpfUo
 OYJz9Cb03ztasD5kqPYn0vAOvm6TRK0KWGKfO8KeXL4YpXXOAldhpsmb7A7YcBhzN9Ar
 ezXDlmvShaJylEEfHMl9NRtVeKhiTSgSTKZJI+u67sRaB0HmWx4TwupAmUo8u6IZ9b9/
 LsXw==
X-Gm-Message-State: ALoCoQlnfgfKUhy0dkKXJmquPtYzJUmlAmL/QeccNNpOWws8HP9Ryl0vdsXn7Yw+ShDehGnDEi1h
X-Received: by 10.194.158.4 with SMTP id wq4mr23455778wjb.58.1414419832186;
 Mon, 27 Oct 2014 07:23:52 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id dg3sm12055013wib.14.2014.10.27.07.23.50
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 27 Oct 2014 07:23:51 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Helin Zhang <helin.zhang@intel.com>
Date: Mon, 27 Oct 2014 15:23:34 +0100
Message-ID: <2549150.oVMv5n2oYl@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.2 (Linux/3.17.1-1-ARCH; KDE/4.14.2; x86_64; ; )
In-Reply-To: <1413978810-24610-8-git-send-email-helin.zhang@intel.com>
References: <1411634427-746-1-git-send-email-helin.zhang@intel.com>
 <1413978810-24610-1-git-send-email-helin.zhang@intel.com>
 <1413978810-24610-8-git-send-email-helin.zhang@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 7/8] ethdev: support of multiple sizes of
	redirection table
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Oct 2014 14:15:09 -0000

2014-10-22 19:53, Helin Zhang:
> +#define RTE_BIT_WIDTH_64 (CHAR_BIT * sizeof(uint64_t))

How can it be different of 64?
Using 64 would be simpler to understand than RTE_BIT_WIDTH_64.

> +	uint8_t reta[RTE_BIT_WIDTH_64]; /**< 64 redirection table entries. */

Even your comment is saying that it's 64.

-- 
Thomas