From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by dpdk.org (Postfix) with ESMTP id 4155F16E for ; Mon, 16 Jul 2018 21:50:59 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 4AE341290; Mon, 16 Jul 2018 15:50:58 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 16 Jul 2018 15:50:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=C8TZc7DCnRH/UyW5z8smlphyFR avp6jn/+7Z5ZktsfM=; b=DOd+dGR8TNiC4nsbUiYfbYVV1DMuh3BMDyR3P898nS 8uq6PxLuLMZJyfykGFApxdB/2HgmnOV5dDwrDREvdXA+9LoOhMjaxz8u5NaKtbjA 6Zu9stYoTvJy6H41Aonx8daIO6koD2gJ7vy7lqVivDMQ0cHNB55Wq39mx3RhFp5A Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=C8TZc7 DCnRH/UyW5z8smlphyFRavp6jn/+7Z5ZktsfM=; b=diQaLCl3y4kBuUuAUvy/89 3nSk3IOku44Xbp5cQGLfQqnvPNDeFOnVeQEYqU7noU+IEX6cTTwo2ighFp8q8qPk HawP8lao+vXZ8/8u/KYtxHmQe0IQcWBCuTcmEJpMAGH9Yx5Pkm9vo2j3EWPNHkTt 2x0SyH3VCc/VODrxgB8QUVY3+6S+A9ThB1h5SgTLHG56CFUlOmL8J79sB0x59ewN imSVRW4oPelyNc1hqRYo/nvwDWWDtuQqDxlxNsRBJiJAR8MfUS/1Xx0IQx581kG+ 0Q/prRME285L/H5oia/QChF2L32X6BBvfonjtURFoWIVacH4EUVye36nz0+jm/6Q == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (unknown [207.232.18.42]) by mail.messagingengine.com (Postfix) with ESMTPA id 26711E454E; Mon, 16 Jul 2018 15:50:56 -0400 (EDT) From: Thomas Monjalon To: "De Lara Guarch, Pablo" Cc: "dev@dpdk.org" Date: Mon, 16 Jul 2018 21:50:53 +0200 Message-ID: <2549532.10hGl2W0VU@xps> In-Reply-To: References: <20180711071750.9872-1-pablo.de.lara.guarch@intel.com> <1571428.5RkRqaR3OR@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] devtools: add compressdev tests to test-build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jul 2018 19:50:59 -0000 16/07/2018 19:33, De Lara Guarch, Pablo: > HI Thomas, > > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > Sent: Wednesday, July 11, 2018 4:50 PM > > To: De Lara Guarch, Pablo > > Cc: dev@dpdk.org > > Subject: Re: [PATCH] devtools: add compressdev tests to test-build > > > > 11/07/2018 09:17, Pablo de Lara: > > > Compressdev tests depend on Zlib library, so they can only be enabled > > > if this is available. > > > > > > Signed-off-by: Pablo de Lara > > > --- > > > --- a/devtools/test-build.sh > > > +++ b/devtools/test-build.sh > > > @@ -154,6 +154,7 @@ config () # > > > test "$DPDK_DEP_ZLIB" != y || \ > > > sed -ri 's,(BNX2X_PMD=)n,\1y,' $1/.config > > > sed -ri 's,(NFP_PMD=)n,\1y,' $1/.config > > > + sed -ri 's,(COMPRESSDEV_TEST=)n,\1y,' $1/.config > > > > It is always enabled here. > > You need to repeat the ZLIB condition for NFP and COMPRESSDEV_TEST. > > > > I see. So, does this mean that NFP PMD is always enabled? Do we need a fix for that? Exact