From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 963BDA0A02; Wed, 14 Apr 2021 23:12:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 678E2161D34; Wed, 14 Apr 2021 23:12:17 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id 20720161D30 for ; Wed, 14 Apr 2021 23:12:15 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id D833F14F7; Wed, 14 Apr 2021 17:12:13 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 14 Apr 2021 17:12:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= K/MxbwzTlkaWkpwflDT/VmyWmuSi9nRHaxEwjIzbnB4=; b=RlDTKiLL2Tebzq3c gLgrtAlWDwtBQvebpa/7K2hQbGDzun5LUvjgD82jYjY+ttY/dpV+0pECKQ0yYGHe O1rGwNU4yhVS6OCd3z5SOwckh+phUviXTUcxT2c66FxcSmwkXdr0x7i7qB5jTVZ2 QT8EEzrnA0ISQ7yqF8Hki6LFLbyBfDWr80vwdis/pWq8or3nW3ktxwrDFf7LGfX/ b1wn7zIzPiqxL9fWPjrqvBJvLz4b2gwrjC6duBiSs7XGOSMam/wOmXBVbsBMpjB7 lCJhX8JSLafGXvqLkgHTd08WZ0g0ZwGMEYNkhW9/mwFoBddOG8axD7PgLVUyx67t StMWBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=K/MxbwzTlkaWkpwflDT/VmyWmuSi9nRHaxEwjIzbn B4=; b=YknH5WDCHUJpMc9eLg1lpldgsUqp+oHyi6g2tVANLr5etbsLC+oc1VKWq a/Ohb4ckm8t/Lz12biG5EcAFQlfyKyaqsJZzD7B3nIzXU0rUCNpGnZ5zm7seNvRN QU8HfZ/WzEv+eQvmt9XfYWWmoqK36J1BuDDdbQZmFPtiVBRAo2kwU6gf2HXpXTuF qJvCMua+frnav/uXGgzPkdLtOcgaQharrHqStqoBj8aeLix1xVoG0qXQ6fZXmGda 1z+zc1jqs8Pow8tApY0a37tkYlN9j6+vWilxakJLd+lKI4HEJXzLiQhr4aOvjkUa amwigXhRxbXr372kdEG9QzpHN8n+Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudeluddgudehlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id CFE1224005C; Wed, 14 Apr 2021 17:12:12 -0400 (EDT) From: Thomas Monjalon To: Ranjit Menon , Dmitry Kozlyuk Cc: dev@dpdk.org Date: Wed, 14 Apr 2021 23:12:11 +0200 Message-ID: <2549908.9JeyF6cTkx@thomas> In-Reply-To: <20210413100006.241c42fb@sovereign> References: <20210407222249.6729-1-dmitry.kozliuk@gmail.com> <138b06d2-ab7e-704e-5f9f-d369f2490b45@intel.com> <20210413100006.241c42fb@sovereign> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v9 0/4] eal/windows: do not expose POSIX symbols X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 13/04/2021 09:00, Dmitry Kozlyuk: > Hi Ranjit, > > 2021-04-12 21:46 (UTC-0700), Ranjit Menon: > [...] > > The change to remove the networking shim breaks l2fwd compilation on > > Windows, since l2fwd/main.c includes netinet/in.h explicitly. > > > > How do you propose we fix this, only for Windows? > > This include is redundant for this file on all platforms, it can be removed. > Since -Dexamples=all doesn't work on Windows because of missing dependencies, > I wonder which of them need fixing. Let's fix the examples which are supported on Windows. Other examples may require more updates anyway.